{"id":808310,"url":"http://patchwork.ozlabs.org/api/patches/808310/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170831165628.2D42343994318@oldenburg.str.redhat.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831165628.2D42343994318@oldenburg.str.redhat.com>","list_archive_url":null,"date":"2017-08-31T16:56:28","name":"[COMMITTED] io: Remove internal_function attribute","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"953aa54f33e62379e30ef968da68ae74fdd23af9","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/?format=json","name":"Florian Weimer","email":"fweimer@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170831165628.2D42343994318@oldenburg.str.redhat.com/mbox/","series":[{"id":875,"url":"http://patchwork.ozlabs.org/api/series/875/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=875","date":"2017-08-31T16:56:28","name":"[COMMITTED] io: Remove internal_function attribute","version":1,"mbox":"http://patchwork.ozlabs.org/series/875/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808310/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808310/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83955-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"lYHFsMry\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjpSN4n8Rz9s81\n\tfor ;\n\tFri, 1 Sep 2017 02:56:52 +1000 (AEST)","(qmail 35412 invoked by alias); 31 Aug 2017 16:56:41 -0000","(qmail 35335 invoked by uid 89); 31 Aug 2017 16:56:40 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; q=dns; s=default; b=\n\taw3oloDJVw44ROuFsvdR4BYrnLsNnVcO+3SJZ2rCDrBxg8AF45IcdrI4vdKgZ+hZ\n\ttSz6tFpG0tE93UvGQrBxxyxHUpHpk8LVgInjY14csKUN7tzMCPGKRKK8vxUUMMlJ\n\tYV75XMAFuQBHPXpsQNK2JyjjP+Dsr2Gt5ACmweSDmdE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; s=default; bh=SDwYf1\n\t/2GsNxXaSED8QBg3CN2iw=; b=lYHFsMryBQ6lmbaZvlsUVew/lWYePMFWdWN08I\n\telA0sM73Xi1HRWuoTM3tx8Fy2LaXBGhCjK20EcQWp1bICA/7A0su71eh1UTJrTcg\n\tyEmWbQStY5Vs5XH6DquEouI3yRdvLLN9/h+lg/HdV1wVzJXJ2wnC39LwS2hDTvX6\n\to9/Es=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=9517, 6287,\n\t9816","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0EFFA745D7","Date":"Thu, 31 Aug 2017 18:56:28 +0200","To":"libc-alpha@sourceware.org","Subject":"[PATCH COMMITTED] io: Remove internal_function attribute","User-Agent":"Heirloom mailx 12.5 7/5/10","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Message-Id":"<20170831165628.2D42343994318@oldenburg.str.redhat.com>","From":"fweimer@redhat.com (Florian Weimer)"},"content":"2017-08-31 Florian Weimer \n\n\t* io/fts.c (fts_alloc, fts_build, fts_lfree, fts_load)\n\t(fts_maxarglen, fts_padjust, fts_palloc, fts_sort, fts_stat)\n\t(fts_safe_changedir): Remove internal_function.\n\t* io/ftw.c (internal_function): Remove definition.\n\t(ftw_dir, process_entry, ftw_startup): Remove internal_function.","diff":"diff --git a/io/fts.c b/io/fts.c\nindex b68a51f333..32ffd7c32f 100644\n--- a/io/fts.c\n+++ b/io/fts.c\n@@ -85,17 +85,16 @@ static char sccsid[] = \"@(#)fts.c\t8.6 (Berkeley) 8/14/94\";\n # define LSTAT lstat\n #endif\n \n-static FTSENTRY\t*fts_alloc (FTSOBJ *, const char *, size_t) internal_function;\n-static FTSENTRY\t*fts_build (FTSOBJ *, int) internal_function;\n-static void\t fts_lfree (FTSENTRY *) internal_function;\n-static void\t fts_load (FTSOBJ *, FTSENTRY *) internal_function;\n-static size_t\t fts_maxarglen (char * const *) internal_function;\n-static void\t fts_padjust (FTSOBJ *, FTSENTRY *) internal_function;\n-static int\t fts_palloc (FTSOBJ *, size_t) internal_function;\n-static FTSENTRY\t*fts_sort (FTSOBJ *, FTSENTRY *, int) internal_function;\n-static u_short\t fts_stat (FTSOBJ *, FTSENTRY *, int) internal_function;\n-static int fts_safe_changedir (FTSOBJ *, FTSENTRY *, int, const char *)\n- internal_function;\n+static FTSENTRY\t*fts_alloc (FTSOBJ *, const char *, size_t);\n+static FTSENTRY\t*fts_build (FTSOBJ *, int);\n+static void\t fts_lfree (FTSENTRY *);\n+static void\t fts_load (FTSOBJ *, FTSENTRY *);\n+static size_t\t fts_maxarglen (char * const *);\n+static void\t fts_padjust (FTSOBJ *, FTSENTRY *);\n+static int\t fts_palloc (FTSOBJ *, size_t);\n+static FTSENTRY\t*fts_sort (FTSOBJ *, FTSENTRY *, int);\n+static u_short\t fts_stat (FTSOBJ *, FTSENTRY *, int);\n+static int fts_safe_changedir (FTSOBJ *, FTSENTRY *, int, const char *);\n \n #ifndef MAX\n #define MAX(a, b)\t({ __typeof__ (a) _a = (a); \\\n@@ -231,7 +230,6 @@ mem1:\tfree(sp);\n }\n \n static void\n-internal_function\n fts_load (FTSOBJ *sp, FTSENTRY *p)\n {\n \tint len;\n@@ -607,7 +605,6 @@ dirent_not_directory(const struct dirent *dp)\n * been found, cutting the stat calls by about 2/3.\n */\n static FTSENTRY *\n-internal_function\n fts_build (FTSOBJ *sp, int type)\n {\n \tstruct dirent *dp;\n@@ -870,7 +867,6 @@ mem1:\t\t\t\tsaved_errno = errno;\n }\n \n static u_short\n-internal_function\n fts_stat (FTSOBJ *sp, FTSENTRY *p, int follow)\n {\n \tFTSENTRY *t;\n@@ -951,7 +947,6 @@ err:\t\tmemset(sbp, 0, sizeof(struct STAT));\n }\n \n static FTSENTRY *\n-internal_function\n fts_sort (FTSOBJ *sp, FTSENTRY *head, int nitems)\n {\n \tFTSENTRY **ap, *p;\n@@ -986,7 +981,6 @@ fts_sort (FTSOBJ *sp, FTSENTRY *head, int nitems)\n }\n \n static FTSENTRY *\n-internal_function\n fts_alloc (FTSOBJ *sp, const char *name, size_t namelen)\n {\n \tFTSENTRY *p;\n@@ -1023,7 +1017,6 @@ fts_alloc (FTSOBJ *sp, const char *name, size_t namelen)\n }\n \n static void\n-internal_function\n fts_lfree (FTSENTRY *head)\n {\n \tFTSENTRY *p;\n@@ -1042,7 +1035,6 @@ fts_lfree (FTSENTRY *head)\n * plus 256 bytes so don't realloc the path 2 bytes at a time.\n */\n static int\n-internal_function\n fts_palloc (FTSOBJ *sp, size_t more)\n {\n \tchar *p;\n@@ -1074,7 +1066,6 @@ fts_palloc (FTSOBJ *sp, size_t more)\n * already returned.\n */\n static void\n-internal_function\n fts_padjust (FTSOBJ *sp, FTSENTRY *head)\n {\n \tFTSENTRY *p;\n@@ -1099,7 +1090,6 @@ fts_padjust (FTSOBJ *sp, FTSENTRY *head)\n }\n \n static size_t\n-internal_function\n fts_maxarglen (char * const *argv)\n {\n \tsize_t len, max;\n@@ -1116,7 +1106,6 @@ fts_maxarglen (char * const *argv)\n * Assumes p->fts_dev and p->fts_ino are filled in.\n */\n static int\n-internal_function\n fts_safe_changedir (FTSOBJ *sp, FTSENTRY *p, int fd, const char *path)\n {\n \tint ret, oerrno, newfd;\ndiff --git a/io/ftw.c b/io/ftw.c\nindex 106b6bf4ec..63448e188a 100644\n--- a/io/ftw.c\n+++ b/io/ftw.c\n@@ -109,8 +109,6 @@ extern char *xgetcwd (void);\n # define __tfind tfind\n # undef __tsearch\n # define __tsearch tsearch\n-# undef internal_function\n-# define internal_function /* empty */\n # undef dirent64\n # define dirent64 dirent\n # undef MAX\n@@ -222,7 +220,7 @@ static const int ftw_arr[] =\n \n /* Forward declarations of local functions. */\n static int ftw_dir (struct ftw_data *data, struct STAT *st,\n-\t\t struct dir_data *old_dir) internal_function;\n+\t\t struct dir_data *old_dir);\n \n \n static int\n@@ -377,7 +375,6 @@ open_dir_stream (int *dfdp, struct ftw_data *data, struct dir_data *dirp)\n \n \n static int\n-internal_function\n process_entry (struct ftw_data *data, struct dir_data *dir, const char *name,\n \t size_t namlen, int d_type)\n {\n@@ -477,7 +474,6 @@ process_entry (struct ftw_data *data, struct dir_data *dir, const char *name,\n \n static int\n __attribute ((noinline))\n-internal_function\n ftw_dir (struct ftw_data *data, struct STAT *st, struct dir_data *old_dir)\n {\n struct dir_data dir;\n@@ -628,7 +624,6 @@ fail:\n \n static int\n __attribute ((noinline))\n-internal_function\n ftw_startup (const char *dir, int is_nftw, void *func, int descriptors,\n \t int flags)\n {\n","prefixes":["COMMITTED"]}