{"id":808282,"url":"http://patchwork.ozlabs.org/api/patches/808282/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/fc45d77e-bb31-de8d-3d84-5deecbf05d00@redhat.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-08-31T15:23:35","name":"[COMMITTED] time: Remove the internal_function attribute","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"47d72c28612f7340d8ab41534297cfd0227e33ab","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/?format=json","name":"Florian Weimer","email":"fweimer@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/fc45d77e-bb31-de8d-3d84-5deecbf05d00@redhat.com/mbox/","series":[{"id":855,"url":"http://patchwork.ozlabs.org/api/series/855/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=855","date":"2017-08-31T15:23:35","name":"[COMMITTED] time: Remove the internal_function attribute","version":1,"mbox":"http://patchwork.ozlabs.org/series/855/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808282/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808282/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83931-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Ssb6FH5o\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmP82gq0z9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:23:56 +1000 (AEST)","(qmail 51133 invoked by alias); 31 Aug 2017 15:23:49 -0000","(qmail 51124 invoked by uid 89); 31 Aug 2017 15:23:48 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:to:from:subject:message-id:date:mime-version\n\t:content-type; q=dns; s=default; b=luOauUhAanPa0Oy6uFbJ19D93LwUZ\n\twND9eW8BqqoyJ19ksTGzjsLFysHgdVQBSq4boQY4CXV4WQGP3qWcmaNmYuQ/XDOC\n\tyFfyT//HFSLFs2e94/iD3PZerwPnz6dIBYqbJCYp9IJvK8Ykpp7D2IiWyjwsdLyu\n\timMvN2zNqlCmao=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:to:from:subject:message-id:date:mime-version\n\t:content-type; s=default; bh=jiilqCg/a7MkCoSD3mrh4VyP1Ng=; b=Ssb\n\t6FH5o6BK3z4NPY/xckLNzYcpdEqxAy9dH/5lIKnFAFwiRALeQqYs/oZHjxJZ1uBE\n\tS9cLoTeSFqiECWJW9jBAYXJYojTPtLT0YGXB5FkRj/yanYMORHwI9Qu46P3YPNYH\n\t/GgmSwIpYfV01LGYQHrP1Kl/l1scOxxGYsfMVWXg=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=4286, 4297","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6208BC056870","To":"GNU C Library ","From":"Florian Weimer ","Subject":"[PATCH COMMITTED] time: Remove the internal_function attribute","Message-ID":"","Date":"Thu, 31 Aug 2017 17:23:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","Content-Type":"multipart/mixed;\n\tboundary=\"------------D7C65A509041E232CE641852\""},"content":"","diff":"2017-08-31 Florian Weimer \n \n\t* include/time.h (__tz_compute, __strptime_internal): Remove\n\tinternal_function.\n\t* time/strptime_l.c (__strptime_internal): Likewise.\n\t* time/tzset.c (compute_change, update_vars, __tz_compute): Likewise.\n\ndiff --git a/include/time.h b/include/time.h\nindex 73696082cc..324913214f 100644\n--- a/include/time.h\n+++ b/include/time.h\n@@ -46,7 +46,7 @@ extern void __tzfile_default (const char *std, const char *dst,\n \t\t\t long int stdoff, long int dstoff);\n extern void __tzset_parse_tz (const char *tz);\n extern void __tz_compute (time_t timer, struct tm *tm, int use_localtime)\n- __THROW internal_function;\n+ __THROW;\n \n /* Subroutine of `mktime'. Return the `time_t' representation of TP and\n normalize TP, given that a `struct tm *' maps to a `time_t' as performed\n@@ -89,8 +89,7 @@ extern int __getclktck (void);\n /* strptime support. */\n extern char * __strptime_internal (const char *rp, const char *fmt,\n \t\t\t\t struct tm *tm, void *statep,\n-\t\t\t\t locale_t locparam)\n- internal_function;\n+\t\t\t\t locale_t locparam);\n \n extern double __difftime (time_t time1, time_t time0);\n \ndiff --git a/time/strptime_l.c b/time/strptime_l.c\nindex 185619e142..3afc33a74e 100644\n--- a/time/strptime_l.c\n+++ b/time/strptime_l.c\n@@ -231,7 +231,6 @@ day_of_the_year (struct tm *tm)\n \n #ifdef _LIBC\n char *\n-internal_function\n #else\n static char *\n #endif\ndiff --git a/time/tzset.c b/time/tzset.c\nindex cf5fe969b6..b5e95204b8 100644\n--- a/time/tzset.c\n+++ b/time/tzset.c\n@@ -63,7 +63,7 @@ typedef struct\n static tz_rule tz_rules[2];\n \n \n-static void compute_change (tz_rule *rule, int year) __THROW internal_function;\n+static void compute_change (tz_rule *rule, int year) __THROW;\n static void tzset_internal (int always);\n \f\n /* List of buffers containing time zone strings. */\n@@ -125,7 +125,6 @@ __tzstring (const char *s)\n static char *old_tz;\n \n static void\n-internal_function\n update_vars (void)\n {\n __daylight = tz_rules[0].offset != tz_rules[1].offset;\n@@ -429,7 +428,6 @@ tzset_internal (int always)\n when the change described by RULE will occur and\n put it in RULE->change, saving YEAR in RULE->computed_for. */\n static void\n-internal_function\n compute_change (tz_rule *rule, int year)\n {\n time_t t;\n@@ -518,7 +516,6 @@ compute_change (tz_rule *rule, int year)\n /* Figure out the correct timezone for TM and set `__tzname',\n `__timezone', and `__daylight' accordingly. */\n void\n-internal_function\n __tz_compute (time_t timer, struct tm *tm, int use_localtime)\n {\n compute_change (&tz_rules[0], 1900 + tm->tm_year);\n","prefixes":["COMMITTED"]}