{"id":808280,"url":"http://patchwork.ozlabs.org/api/patches/808280/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170831152232.0CFEE43994318@oldenburg.str.redhat.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831152232.0CFEE43994318@oldenburg.str.redhat.com>","list_archive_url":null,"date":"2017-08-31T15:22:32","name":"[COMMITTED] gmon: Remove internal_function attribute","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"52d1d5964268fd7223745673803998a5d55b99c1","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/?format=json","name":"Florian Weimer","email":"fweimer@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170831152232.0CFEE43994318@oldenburg.str.redhat.com/mbox/","series":[{"id":853,"url":"http://patchwork.ozlabs.org/api/series/853/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=853","date":"2017-08-31T15:22:32","name":"[COMMITTED] gmon: Remove internal_function attribute","version":1,"mbox":"http://patchwork.ozlabs.org/series/853/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808280/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808280/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83929-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"Pl/gsCBb\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmN00Bf4z9sD5\n\tfor ;\n\tFri, 1 Sep 2017 01:22:55 +1000 (AEST)","(qmail 46527 invoked by alias); 31 Aug 2017 15:22:44 -0000","(qmail 46463 invoked by uid 89); 31 Aug 2017 15:22:44 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; q=dns; s=default; b=\n\tG9tMnBAoo+euksKwc9PeY8JdbLfxc9QE8oAgykESSxXCt16m89J/gx/oQzV6EanG\n\tfBqHJJy1lu96SvpSa92mrjy+5nEMiXdCRgJJ2VaDbq3o0uIYEokZd5l77dEQfx/l\n\t/Jnwp3oUdYppbDRbSNBMhHceJFIQGUMmcFuDb8pQq2I=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; s=default; bh=/v7ES6\n\tiv2nf5037sXy/vEheAz3U=; b=Pl/gsCBbFLs2xc0lKzVQ3ZiDPeYZRLJw+QIt1q\n\tCCuPm8Kk0NTHxoqsBAgvxnot3P8x3uAHr78H15IDHEabxccabPmOv3MVXiFBqoPP\n\tydD0+7pGlDOuFKPMsc9fFiiaFiYjBkVOXAUBmavj12v4xe4kBHJec/S0sEC2prx0\n\tPlQE4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BFC23C047B8C","Date":"Thu, 31 Aug 2017 17:22:32 +0200","To":"libc-alpha@sourceware.org","Subject":"[PATCH COMMITTED] gmon: Remove internal_function attribute","User-Agent":"Heirloom mailx 12.5 7/5/10","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Message-Id":"<20170831152232.0CFEE43994318@oldenburg.str.redhat.com>","From":"fweimer@redhat.com (Florian Weimer)"},"content":"2017-08-31 Florian Weimer \n\n\t* gmon/gmon.c (write_hist, write_call_graph, write_bb_counts):\n\tRemove internal_function.\n\t* sysdeps/arm/machine-gmon.h (mcount_internal, _MCOUNT_DECL):\n\tLikewise.\n\t* sysdeps/sparc/machine-gmon.h (mcount_internal, _MCOUNT_DECL):\n\tLikewise.","diff":"diff --git a/gmon/gmon.c b/gmon/gmon.c\nindex c1d170170a..4e48eba1bf 100644\n--- a/gmon/gmon.c\n+++ b/gmon/gmon.c\n@@ -62,9 +62,9 @@ static int\ts_scale;\n \n void moncontrol (int mode);\n void __moncontrol (int mode);\n-static void write_hist (int fd) internal_function;\n-static void write_call_graph (int fd) internal_function;\n-static void write_bb_counts (int fd) internal_function;\n+static void write_hist (int fd);\n+static void write_call_graph (int fd);\n+static void write_bb_counts (int fd);\n \n /*\n * Control profiling\n@@ -171,7 +171,6 @@ weak_alias (__monstartup, monstartup)\n \n \n static void\n-internal_function\n write_hist (int fd)\n {\n u_char tag = GMON_TAG_TIME_HIST;\n@@ -222,7 +221,6 @@ write_hist (int fd)\n \n \n static void\n-internal_function\n write_call_graph (int fd)\n {\n #define NARCS_PER_WRITEV\t32\n@@ -284,7 +282,6 @@ write_call_graph (int fd)\n \n \n static void\n-internal_function\n write_bb_counts (int fd)\n {\n struct __bb *grp;\ndiff --git a/sysdeps/arm/machine-gmon.h b/sysdeps/arm/machine-gmon.h\nindex 8e9f43a662..e5483f0a79 100644\n--- a/sysdeps/arm/machine-gmon.h\n+++ b/sysdeps/arm/machine-gmon.h\n@@ -24,9 +24,9 @@\n /* We must not pollute the global namespace. */\n #define mcount_internal __mcount_internal\n \n-extern void mcount_internal (u_long frompc, u_long selfpc) internal_function;\n+extern void mcount_internal (u_long frompc, u_long selfpc);\n #define _MCOUNT_DECL(frompc, selfpc) \\\n- void internal_function mcount_internal (u_long frompc, u_long selfpc)\n+ void mcount_internal (u_long frompc, u_long selfpc)\n \n \n /* Define MCOUNT as empty since we have the implementation in another file. */\ndiff --git a/sysdeps/sparc/machine-gmon.h b/sysdeps/sparc/machine-gmon.h\nindex 361d98bb97..54de05debf 100644\n--- a/sysdeps/sparc/machine-gmon.h\n+++ b/sysdeps/sparc/machine-gmon.h\n@@ -22,10 +22,10 @@\n /* We must not pollute the global namespace. */\n #define mcount_internal __mcount_internal\n \n-extern void mcount_internal (u_long frompc, u_long selfpc) internal_function;\n+extern void mcount_internal (u_long frompc, u_long selfpc);\n \n #define _MCOUNT_DECL(frompc, selfpc) \\\n-void internal_function mcount_internal (u_long frompc, u_long selfpc)\n+void mcount_internal (u_long frompc, u_long selfpc)\n \n /* Define MCOUNT as empty since we have the implementation in another\n file. */\n","prefixes":["COMMITTED"]}