{"id":808279,"url":"http://patchwork.ozlabs.org/api/patches/808279/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170831152221.3EE2B43994318@oldenburg.str.redhat.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831152221.3EE2B43994318@oldenburg.str.redhat.com>","list_archive_url":null,"date":"2017-08-31T15:22:21","name":"[COMMITTED] dlfcn: Remove internal_function attribute","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f95d1a51ce6646db5659623ec8889c994dd7c137","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/?format=json","name":"Florian Weimer","email":"fweimer@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170831152221.3EE2B43994318@oldenburg.str.redhat.com/mbox/","series":[{"id":852,"url":"http://patchwork.ozlabs.org/api/series/852/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=852","date":"2017-08-31T15:22:21","name":"[COMMITTED] dlfcn: Remove internal_function attribute","version":1,"mbox":"http://patchwork.ozlabs.org/series/852/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808279/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808279/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83928-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"i9pzmM7I\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmMg5fGrz9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:22:39 +1000 (AEST)","(qmail 45147 invoked by alias); 31 Aug 2017 15:22:33 -0000","(qmail 45089 invoked by uid 89); 31 Aug 2017 15:22:33 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; q=dns; s=default; b=\n\tTUI49pECHyEPqB3/6DYL1jN9iDvWdq53SYxHTNd53HSytbE2VSmG2XNTiJUEL2we\n\tyEv3kUQT1XNz3trjAzPkl/olBY0dxkPDRJQmvngtQXYWQ1+aWh61fdFfGDKMdMVU\n\tROGD4Uc+/MfA34Lr3Gt4CxkCd1XC2VWywmdSaG1TjzA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; s=default; bh=ORA0wP\n\t61F5IONoaxnj51Fhgi0YA=; b=i9pzmM7Inoe6v1bP2BYQOeqtVxKXKJ+IpmB1zV\n\t9J/gLNfZntSKnAMbJT8zIHpVotA6m1vaAa3dNbbLSFsSdAxP7OMBOe+HpFG0EKMd\n\tPuNBvGs4sPU70MJ7kw0VjCygzJuBP3nlvp21dElG6407sW5zTu9FuBs8qp73CiaJ\n\tzm4eo=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=5920","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F15CC15561","Date":"Thu, 31 Aug 2017 17:22:21 +0200","To":"libc-alpha@sourceware.org","Subject":"[PATCH COMMITTED] dlfcn: Remove internal_function attribute","User-Agent":"Heirloom mailx 12.5 7/5/10","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Message-Id":"<20170831152221.3EE2B43994318@oldenburg.str.redhat.com>","From":"fweimer@redhat.com (Florian Weimer)"},"content":"2017-08-31 Florian Weimer \n\n\t* dlfcn/dlerror.c (_dlerror_run): Remove internal_function.\n\t* elf/dl-sym.c (_dl_vsym, _dl_sym): Likewise.\n\t* include/dlfcn.h (_dl_sym, _dl_vsym, _dlerror_run): Likewise.","diff":"diff --git a/dlfcn/dlerror.c b/dlfcn/dlerror.c\nindex c0ead7dcb6..fb5012ee85 100644\n--- a/dlfcn/dlerror.c\n+++ b/dlfcn/dlerror.c\n@@ -120,7 +120,6 @@ strong_alias (__dlerror, dlerror)\n # endif\n \n int\n-internal_function\n _dlerror_run (void (*operate) (void *), void *args)\n {\n struct dl_action_result *result;\ndiff --git a/elf/dl-sym.c b/elf/dl-sym.c\nindex fb54a91858..97cfcca712 100644\n--- a/elf/dl-sym.c\n+++ b/elf/dl-sym.c\n@@ -235,7 +235,6 @@ RTLD_NEXT used in code not dynamically loaded\"));\n \n \n void *\n-internal_function\n _dl_vsym (void *handle, const char *name, const char *version, void *who)\n {\n struct r_found_version vers;\n@@ -252,7 +251,6 @@ _dl_vsym (void *handle, const char *name, const char *version, void *who)\n \n \n void *\n-internal_function\n _dl_sym (void *handle, const char *name, void *who)\n {\n return do_sym (handle, name, who, NULL, DL_LOOKUP_RETURN_NEWEST);\ndiff --git a/include/dlfcn.h b/include/dlfcn.h\nindex 51cc1dfde8..888e84d4b8 100644\n--- a/include/dlfcn.h\n+++ b/include/dlfcn.h\n@@ -59,23 +59,20 @@ extern void _dl_close_worker (struct link_map *map, bool force)\n /* Look up NAME in shared object HANDLE (which may be RTLD_DEFAULT or\n RTLD_NEXT). WHO is the calling function, for RTLD_NEXT. Returns\n the symbol value, which may be NULL. */\n-extern void *_dl_sym (void *handle, const char *name, void *who)\n- internal_function;\n+extern void *_dl_sym (void *handle, const char *name, void *who);\n \n /* Look up version VERSION of symbol NAME in shared object HANDLE\n (which may be RTLD_DEFAULT or RTLD_NEXT). WHO is the calling\n function, for RTLD_NEXT. Returns the symbol value, which may be\n NULL. */\n extern void *_dl_vsym (void *handle, const char *name, const char *version,\n-\t\t void *who)\n- internal_function;\n+\t\t void *who);\n \n /* Helper function for functions. Runs the OPERATE function via\n _dl_catch_error. Returns zero for success, nonzero for failure; and\n arranges for `dlerror' to return the error details.\n ARGS is passed as argument to OPERATE. */\n-extern int _dlerror_run (void (*operate) (void *), void *args)\n- internal_function;\n+extern int _dlerror_run (void (*operate) (void *), void *args);\n \n #ifdef SHARED\n # define DL_CALLER_DECL /* Nothing */\n","prefixes":["COMMITTED"]}