{"id":808277,"url":"http://patchwork.ozlabs.org/api/patches/808277/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/patch/20170831152159.3E46243994318@oldenburg.str.redhat.com/","project":{"id":41,"url":"http://patchwork.ozlabs.org/api/projects/41/?format=json","name":"GNU C Library","link_name":"glibc","list_id":"libc-alpha.sourceware.org","list_email":"libc-alpha@sourceware.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831152159.3E46243994318@oldenburg.str.redhat.com>","list_archive_url":null,"date":"2017-08-31T15:21:59","name":"[COMMITTED] dirent: Remove internal_function attribute","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e719e3144bc9a8a19358816bb16b161227782d71","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/?format=json","name":"Florian Weimer","email":"fweimer@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/glibc/patch/20170831152159.3E46243994318@oldenburg.str.redhat.com/mbox/","series":[{"id":850,"url":"http://patchwork.ozlabs.org/api/series/850/?format=json","web_url":"http://patchwork.ozlabs.org/project/glibc/list/?series=850","date":"2017-08-31T15:21:59","name":"[COMMITTED] dirent: Remove internal_function attribute","version":1,"mbox":"http://patchwork.ozlabs.org/series/850/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808277/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808277/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83926-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"VUrI+5zM\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjmMJ3b20z9s83\n\tfor ;\n\tFri, 1 Sep 2017 01:22:20 +1000 (AEST)","(qmail 42377 invoked by alias); 31 Aug 2017 15:22:12 -0000","(qmail 42367 invoked by uid 89); 31 Aug 2017 15:22:11 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; q=dns; s=default; b=\n\tLlomsS70I3TbBYDPfF4TnQ1IgXw8vdcghYWyMY9z5gp3dH2UPY9MfTWMYJZOyz03\n\te3C+zdzq9vV1SRIfnqsnmoSd6leIysQYdgqbiL5wKOrjN9h1fKAVl9XocA1GttMh\n\tH68/PqDBoLWY4YToGtcU9ZjuwDh6muKWI/6AS1NZvKA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:to:subject:mime-version:content-type\n\t:content-transfer-encoding:message-id:from; s=default; bh=fA4+qn\n\tHJ7lEcwl7cPOqRqCZaWis=; b=VUrI+5zMU2Yi6dqGiZ3dZZ6jIi7iPQxbnTxak4\n\tB1dNLqk+bN0SK2D2ZysNyzl10++EuL/82hp5J4tGPiTNPNO4NQXMAgEaEQi/o02K\n\t5xFbYjTnBlj2ucM4/e53JhLikc0CbV1g9OPPOeuStCn9TGCT/7m0BhiLpxGbAIwI\n\tLzup4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1FDE681F13","Date":"Thu, 31 Aug 2017 17:21:59 +0200","To":"libc-alpha@sourceware.org","Subject":"[PATCH COMMITTED] dirent: Remove internal_function attribute","User-Agent":"Heirloom mailx 12.5 7/5/10","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Message-Id":"<20170831152159.3E46243994318@oldenburg.str.redhat.com>","From":"fweimer@redhat.com (Florian Weimer)"},"content":"2017-08-31 Florian Weimer \n\n\t* dirent/scandir-tail.c (SCANDIR_TAIL): Remove internal_function.\n\t* include/dirent.h (__opendirat, __getdents, __getdents64)\n\t(__alloc_dir, __scandir_tail, __scandir64_tail): Likewise.\n\t* sysdeps/posix/opendir.c (__opendirat, __alloc_dir): Likewise.\n\t* sysdeps/mach/hurd/opendir.c (__opendirat): Likewise.\n\t* sysdeps/unix/sysv/linux/i386/olddirent.h (__old_getdents64):\n\tLikewise.\n\t* sysdeps/unix/sysv/linux/getdents.c (__GETDENTS): Likewise.","diff":"diff --git a/dirent/scandir-tail.c b/dirent/scandir-tail.c\nindex 7810fb4d42..068c644c4e 100644\n--- a/dirent/scandir-tail.c\n+++ b/dirent/scandir-tail.c\n@@ -28,7 +28,6 @@\n # define DIRENT_TYPE\tstruct dirent\n #endif\n \n-internal_function\n int\n SCANDIR_TAIL (DIR *dp,\n DIRENT_TYPE ***namelist,\ndiff --git a/include/dirent.h b/include/dirent.h\nindex c792e53c96..bebcd52cdb 100644\n--- a/include/dirent.h\n+++ b/include/dirent.h\n@@ -16,8 +16,7 @@ struct scandir_cancel_struct\n \n /* Now define the internal interfaces. */\n extern DIR *__opendir (const char *__name);\n-extern DIR *__opendirat (int dfd, const char *__name)\n- internal_function attribute_hidden;\n+extern DIR *__opendirat (int dfd, const char *__name) attribute_hidden;\n extern DIR *__fdopendir (int __fd);\n extern int __closedir (DIR *__dirp);\n extern struct dirent *__readdir (DIR *__dirp);\n@@ -36,17 +35,16 @@ extern __ssize_t __getdirentries (int __fd, char *__restrict __buf,\n \t\t\t\t__off_t *__restrict __basep)\n __THROW __nonnull ((2, 4));\n extern __ssize_t __getdents (int __fd, char *__buf, size_t __nbytes)\n- internal_function attribute_hidden;\n+ attribute_hidden;\n extern __ssize_t __getdents64 (int __fd, char *__buf, size_t __nbytes)\n- internal_function attribute_hidden;\n+ attribute_hidden;\n extern int __alphasort64 (const struct dirent64 **a, const struct dirent64 **b)\n __attribute_pure__;\n extern int __versionsort64 (const struct dirent64 **a,\n \t\t\t const struct dirent64 **b)\n __attribute_pure__;\n extern DIR *__alloc_dir (int fd, bool close_fd, int flags,\n-\t\t\t const struct stat64 *statp)\n- internal_function attribute_hidden;\n+\t\t\t const struct stat64 *statp) attribute_hidden;\n extern __typeof (rewinddir) __rewinddir;\n \n extern void __scandir_cancel_handler (void *arg) attribute_hidden;\n@@ -55,7 +53,7 @@ extern int __scandir_tail (DIR *dp,\n \t\t\t int (*select) (const struct dirent *),\n \t\t\t int (*cmp) (const struct dirent **,\n \t\t\t\t const struct dirent **))\n- internal_function attribute_hidden;\n+ attribute_hidden;\n # ifdef _DIRENT_MATCHES_DIRENT64\n # define __scandir64_tail (dp, namelist, select, cmp) \\\n __scandir_tail (dp, (struct dirent ***) (namelist), \\\n@@ -68,7 +66,7 @@ extern int __scandir64_tail (DIR *dp,\n \t\t\t int (*select) (const struct dirent64 *),\n \t\t\t int (*cmp) (const struct dirent64 **,\n \t\t\t\t\t const struct dirent64 **))\n- internal_function attribute_hidden;\n+ attribute_hidden;\n # endif\n \n libc_hidden_proto (__rewinddir)\ndiff --git a/sysdeps/mach/hurd/opendir.c b/sysdeps/mach/hurd/opendir.c\nindex d3757f00fa..2e1d1a07b2 100644\n--- a/sysdeps/mach/hurd/opendir.c\n+++ b/sysdeps/mach/hurd/opendir.c\n@@ -69,7 +69,6 @@ _hurd_fd_opendir (struct hurd_fd *d)\n \n \n DIR *\n-internal_function\n __opendirat (int dfd, const char *name)\n {\n if (name[0] == '\\0')\ndiff --git a/sysdeps/posix/opendir.c b/sysdeps/posix/opendir.c\nindex 880ebc904c..99869b4eb4 100644\n--- a/sysdeps/posix/opendir.c\n+++ b/sysdeps/posix/opendir.c\n@@ -139,7 +139,6 @@ opendir_tail (int fd)\n \n #if IS_IN (libc)\n DIR *\n-internal_function\n __opendirat (int dfd, const char *name)\n {\n if (__glibc_unlikely (invalid_name (name)))\n@@ -193,7 +192,6 @@ __opendir (const char *name)\n weak_alias (__opendir, opendir)\n \n DIR *\n-internal_function\n __alloc_dir (int fd, bool close_fd, int flags, const struct stat64 *statp)\n {\n /* We have to set the close-on-exit flag if the user provided the\ndiff --git a/sysdeps/unix/sysv/linux/getdents.c b/sysdeps/unix/sysv/linux/getdents.c\nindex 4794eb737d..fb2bc1c056 100644\n--- a/sysdeps/unix/sysv/linux/getdents.c\n+++ b/sysdeps/unix/sysv/linux/getdents.c\n@@ -76,7 +76,6 @@ struct kernel_dirent64\n reset the file descriptor. In practice the kernel is limiting the\n amount of data returned much more then the reduced buffer size. */\n ssize_t\n-internal_function\n __GETDENTS (int fd, char *buf, size_t nbytes)\n {\n ssize_t retval;\ndiff --git a/sysdeps/unix/sysv/linux/i386/olddirent.h b/sysdeps/unix/sysv/linux/i386/olddirent.h\nindex 8f2fcb7a9c..0b4c81da0e 100644\n--- a/sysdeps/unix/sysv/linux/i386/olddirent.h\n+++ b/sysdeps/unix/sysv/linux/i386/olddirent.h\n@@ -34,8 +34,7 @@ extern struct __old_dirent64 *__old_readdir64 (DIR *__dirp);\n libc_hidden_proto (__old_readdir64);\n extern int __old_readdir64_r (DIR *__dirp, struct __old_dirent64 *__entry,\n \t\t\t struct __old_dirent64 **__result);\n-extern __ssize_t __old_getdents64 (int __fd, char *__buf, size_t __nbytes)\n-\tinternal_function;\n+extern __ssize_t __old_getdents64 (int __fd, char *__buf, size_t __nbytes);\n int __old_scandir64 (const char * __dir,\n \t\t struct __old_dirent64 *** __namelist,\n \t\t int (*__selector) (const struct __old_dirent64 *),\n","prefixes":["COMMITTED"]}