{"id":808227,"url":"http://patchwork.ozlabs.org/api/patches/808227/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831121828.85885-1-pasic@linux.vnet.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831121828.85885-1-pasic@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-08-31T12:18:28","name":"[1/1] s390x/css: fix cc handling for XSCH","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"01fa0b7fcd3d7bd7e6750e841713ed4b96a0735e","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/?format=json","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831121828.85885-1-pasic@linux.vnet.ibm.com/mbox/","series":[{"id":816,"url":"http://patchwork.ozlabs.org/api/series/816/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=816","date":"2017-08-31T12:18:28","name":"[1/1] s390x/css: fix cc handling for XSCH","version":1,"mbox":"http://patchwork.ozlabs.org/series/816/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808227/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808227/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjhHs3TnQz9sMN\n\tfor ;\n\tThu, 31 Aug 2017 22:19:05 +1000 (AEST)","from localhost ([::1]:55506 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnOR5-0006xC-Hn\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 08:19:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40918)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnOQi-0006wv-4L\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:18:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnOQe-00023E-1A\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:18:40 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35724\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnOQd-000237-S1\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 08:18:35 -0400","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7VCA2nP011375\n\tfor ; Thu, 31 Aug 2017 08:18:35 -0400","from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cpe3mx4gp-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 31 Aug 2017 08:18:35 -0400","from localhost\n\tby e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 31 Aug 2017 13:18:33 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 13:18:31 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7VCIUD417629302; Thu, 31 Aug 2017 12:18:30 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C455AA4051;\n\tThu, 31 Aug 2017 13:14:57 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8073BA4053;\n\tThu, 31 Aug 2017 13:14:57 +0100 (BST)","from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS;\n\tThu, 31 Aug 2017 13:14:57 +0100 (BST)"],"From":"Halil Pasic ","To":"Cornelia Huck ","Date":"Thu, 31 Aug 2017 14:18:28 +0200","X-Mailer":"git-send-email 2.13.5","X-TM-AS-GCONF":"00","x-cbid":"17083112-0012-0000-0000-00000573B2D7","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083112-0013-0000-0000-000018EBD953","Message-Id":"<20170831121828.85885-1-pasic@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310184","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"[Qemu-devel] [PATCH 1/1] s390x/css: fix cc handling for XSCH","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dong Jia Shi ,\n\tHalil Pasic ,\n\tPierre Morel ,\n\tThomas Huth , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The function ioinst_handle_xsch is presenting cc 2 when it's supposed to\npresent cc 1 and the other way around, because css_do_xsch has the error\ncodes mixed up. Because cc 1 has precedence over cc 2 we also have to\nswap the two checks.\n\nLet us fix this.\n\nSigned-off-by: Halil Pasic \nReported-by: Pierre Morel \n---\n\nWas previously a part of a series (due to an accident the\nseries had no name). This version also fixes the priority\n(aka precedence) problem.\n\n---\n hw/s390x/css.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/hw/s390x/css.c b/hw/s390x/css.c\nindex 1880b1a0ff..e04e0ea3a8 100644\n--- a/hw/s390x/css.c\n+++ b/hw/s390x/css.c\n@@ -1276,16 +1276,16 @@ int css_do_xsch(SubchDev *sch)\n goto out;\n }\n \n+ if (s->ctrl & SCSW_CTRL_MASK_STCTL) {\n+ ret = -EINPROGRESS;\n+ goto out;\n+ }\n+\n if (!(s->ctrl & SCSW_CTRL_MASK_FCTL) ||\n ((s->ctrl & SCSW_CTRL_MASK_FCTL) != SCSW_FCTL_START_FUNC) ||\n (!(s->ctrl &\n (SCSW_ACTL_RESUME_PEND | SCSW_ACTL_START_PEND | SCSW_ACTL_SUSP))) ||\n (s->ctrl & SCSW_ACTL_SUBCH_ACTIVE)) {\n- ret = -EINPROGRESS;\n- goto out;\n- }\n-\n- if (s->ctrl & SCSW_CTRL_MASK_STCTL) {\n ret = -EBUSY;\n goto out;\n }\n","prefixes":["1/1"]}