{"id":808218,"url":"http://patchwork.ozlabs.org/api/patches/808218/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-21-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831103432.6007-21-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-08-31T10:34:23","name":"[PULL,20/29] usb-hub: use DIV_ROUND_UP","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f52bc7c72d41d7be627604d6b2a4f90446eb3ffb","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-21-marcandre.lureau@redhat.com/mbox/","series":[{"id":788,"url":"http://patchwork.ozlabs.org/api/series/788/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788","date":"2017-08-31T10:34:03","name":"[PULL,01/29] i386: use ROUND_UP macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/788/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808218/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808218/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjgmQ4XN5z9s72\n\tfor ;\n\tThu, 31 Aug 2017 21:55:18 +1000 (AEST)","from localhost ([::1]:54952 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnN6V-0007W8-QQ\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:53:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41666)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMpY-0002iu-5L\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMpX-0006Ku-8H\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:12 -0400","from mx1.redhat.com ([209.132.183.28]:58572)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnMpX-0006KZ-1j; Thu, 31 Aug 2017 06:36:11 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1ACF4C047B6F;\n\tThu, 31 Aug 2017 10:36:10 +0000 (UTC)","from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 730AC9ABBC;\n\tThu, 31 Aug 2017 10:36:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1ACF4C047B6F","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Thu, 31 Aug 2017 12:34:23 +0200","Message-Id":"<20170831103432.6007-21-marcandre.lureau@redhat.com>","In-Reply-To":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","References":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 10:36:10 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 20/29] usb-hub: use DIV_ROUND_UP","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, peter.maydell@linaro.org, Gerd Hoffmann\n\t, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Richard Henderson \n---\n hw/usb/dev-hub.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c\nindex e82a6a6c44..752e30c305 100644\n--- a/hw/usb/dev-hub.c\n+++ b/hw/usb/dev-hub.c\n@@ -109,7 +109,7 @@ static const USBDescIface desc_iface_hub = {\n {\n .bEndpointAddress = USB_DIR_IN | 0x01,\n .bmAttributes = USB_ENDPOINT_XFER_INT,\n- .wMaxPacketSize = 1 + (NUM_PORTS + 7) / 8,\n+ .wMaxPacketSize = 1 + DIV_ROUND_UP(NUM_PORTS, 8),\n .bInterval = 0xff,\n },\n }\n@@ -442,14 +442,14 @@ static void usb_hub_handle_control(USBDevice *dev, USBPacket *p,\n data[2] = NUM_PORTS;\n \n /* fill DeviceRemovable bits */\n- limit = ((NUM_PORTS + 1 + 7) / 8) + 7;\n+ limit = DIV_ROUND_UP(NUM_PORTS + 1, 8) + 7;\n for (n = 7; n < limit; n++) {\n data[n] = 0x00;\n var_hub_size++;\n }\n \n /* fill PortPwrCtrlMask bits */\n- limit = limit + ((NUM_PORTS + 7) / 8);\n+ limit = limit + DIV_ROUND_UP(NUM_PORTS, 8);\n for (;n < limit; n++) {\n data[n] = 0xff;\n var_hub_size++;\n@@ -477,7 +477,7 @@ static void usb_hub_handle_data(USBDevice *dev, USBPacket *p)\n unsigned int status;\n uint8_t buf[4];\n int i, n;\n- n = (NUM_PORTS + 1 + 7) / 8;\n+ n = DIV_ROUND_UP(NUM_PORTS + 1, 8);\n if (p->iov.size == 1) { /* FreeBSD workaround */\n n = 1;\n } else if (n > p->iov.size) {\n","prefixes":["PULL","20/29"]}