{"id":808196,"url":"http://patchwork.ozlabs.org/api/patches/808196/?format=json","web_url":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170831105109.58224-1-nixiaoming@huawei.com/","project":{"id":23,"url":"http://patchwork.ozlabs.org/api/projects/23/?format=json","name":"KVM PowerPC development","link_name":"kvm-ppc","list_id":"kvm-ppc.vger.kernel.org","list_email":"kvm-ppc@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831105109.58224-1-nixiaoming@huawei.com>","list_archive_url":null,"date":"2017-08-31T10:51:09","name":"[RESEND] KVM:PPC:Book3s: fix memory leak in kvm_vm_ioctl_get_htab_fd","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a846ad87a0fc5c34ec4c987113ad2d0ee3094abe","submitter":{"id":72208,"url":"http://patchwork.ozlabs.org/api/people/72208/?format=json","name":"Xiaoming Ni","email":"nixiaoming@huawei.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170831105109.58224-1-nixiaoming@huawei.com/mbox/","series":[{"id":796,"url":"http://patchwork.ozlabs.org/api/series/796/?format=json","web_url":"http://patchwork.ozlabs.org/project/kvm-ppc/list/?series=796","date":"2017-08-31T10:51:09","name":"[RESEND] KVM:PPC:Book3s: fix memory leak in kvm_vm_ioctl_get_htab_fd","version":1,"mbox":"http://patchwork.ozlabs.org/series/796/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808196/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808196/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjfhS5dS2z9t2R\n\tfor ;\n\tThu, 31 Aug 2017 21:06:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750893AbdHaLGe (ORCPT );\n\tThu, 31 Aug 2017 07:06:34 -0400","from szxga05-in.huawei.com ([45.249.212.191]:5065 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750772AbdHaLGd (ORCPT\n\t); Thu, 31 Aug 2017 07:06:33 -0400","from 172.30.72.60 (EHLO DGGEMS405-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DGI47193; Thu, 31 Aug 2017 19:06:26 +0800 (CST)","from linux.huawei.com (10.67.187.180) by\n\tDGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP\n\tServer id 14.3.301.0; Thu, 31 Aug 2017 19:06:20 +0800"],"From":"nixiaoming ","To":", , ,\n\t, , ","CC":", ,\n\t, ","Subject":"[PATCH] [RESEND] KVM:PPC:Book3s: fix memory leak in\n\tkvm_vm_ioctl_get_htab_fd","Date":"Thu, 31 Aug 2017 18:51:09 +0800","Message-ID":"<20170831105109.58224-1-nixiaoming@huawei.com>","X-Mailer":"git-send-email 2.11.0.1","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.67.187.180]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020205.59A7EDB4.017A, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"ca17152b8f72eacf2dc0732e337c88f8","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"},"content":"ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);\nbut no free when anon_inode_getfd return fail\nso, add kfree(ctx) to fix memory leak\n\nSigned-off-by: nixiaoming \nReviewed-by: Paolo Bonzini \n---\n arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c\nindex b42812e..be3d08f 100644\n--- a/arch/powerpc/kvm/book3s_64_mmu_hv.c\n+++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c\n@@ -1940,6 +1940,7 @@ int kvm_vm_ioctl_get_htab_fd(struct kvm *kvm, struct kvm_get_htab_fd *ghf)\n \trwflag = (ghf->flags & KVM_GET_HTAB_WRITE) ? O_WRONLY : O_RDONLY;\n \tret = anon_inode_getfd(\"kvm-htab\", &kvm_htab_fops, ctx, rwflag | O_CLOEXEC);\n \tif (ret < 0) {\n+\t\tkfree(ctx);\n \t\tkvm_put_kvm(kvm);\n \t\treturn ret;\n \t}\n","prefixes":["RESEND"]}