{"id":808187,"url":"http://patchwork.ozlabs.org/api/patches/808187/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-23-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831103432.6007-23-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-08-31T10:34:25","name":"[PULL,22/29] ppc: use DIV_ROUND_UP","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"326633216df01d032c51f208fa3096b393ea8673","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-23-marcandre.lureau@redhat.com/mbox/","series":[{"id":788,"url":"http://patchwork.ozlabs.org/api/series/788/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788","date":"2017-08-31T10:34:03","name":"[PULL,01/29] i386: use ROUND_UP macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/788/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808187/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808187/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjfTw5kKXz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 20:57:40 +1000 (AEST)","from localhost ([::1]:54979 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnNAI-0007xI-Rh\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:57:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41836)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMpg-0002rr-K7\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMpf-0006Tg-JB\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:20 -0400","from mx1.redhat.com ([209.132.183.28]:54092)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnMpf-0006SG-D4; Thu, 31 Aug 2017 06:36:19 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4C6E8C0587C6;\n\tThu, 31 Aug 2017 10:36:18 +0000 (UTC)","from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8A74F77DCE;\n\tThu, 31 Aug 2017 10:36:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4C6E8C0587C6","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Thu, 31 Aug 2017 12:34:25 +0200","Message-Id":"<20170831103432.6007-23-marcandre.lureau@redhat.com>","In-Reply-To":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","References":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 31 Aug 2017 10:36:18 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 22/29] ppc: use DIV_ROUND_UP","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, qemu-trivial@nongnu.org, Alexander Graf\n\t, \"open list:PowerPC\" , \n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau \nAcked-by: David Gibson \nReviewed-by: Richard Henderson \n---\n target/ppc/mem_helper.c | 2 +-\n target/ppc/translate.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c\nindex e6383c6bfa..a34e604db3 100644\n--- a/target/ppc/mem_helper.c\n+++ b/target/ppc/mem_helper.c\n@@ -111,7 +111,7 @@ void helper_lswx(CPUPPCState *env, target_ulong addr, uint32_t reg,\n uint32_t ra, uint32_t rb)\n {\n if (likely(xer_bc != 0)) {\n- int num_used_regs = (xer_bc + 3) / 4;\n+ int num_used_regs = DIV_ROUND_UP(xer_bc, 4);\n if (unlikely((ra != 0 && lsw_reg_in_range(reg, num_used_regs, ra)) ||\n lsw_reg_in_range(reg, num_used_regs, rb))) {\n raise_exception_err_ra(env, POWERPC_EXCP_PROGRAM,\ndiff --git a/target/ppc/translate.c b/target/ppc/translate.c\nindex 01233e8b6d..606b605ba0 100644\n--- a/target/ppc/translate.c\n+++ b/target/ppc/translate.c\n@@ -2880,7 +2880,7 @@ static void gen_lswi(DisasContext *ctx)\n }\n if (nb == 0)\n nb = 32;\n- nr = (nb + 3) / 4;\n+ nr = DIV_ROUND_UP(nb, 4);\n if (unlikely(lsw_reg_in_range(start, nr, ra))) {\n gen_inval_exception(ctx, POWERPC_EXCP_INVAL_LSWX);\n return;\n","prefixes":["PULL","22/29"]}