{"id":808171,"url":"http://patchwork.ozlabs.org/api/patches/808171/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-15-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831103432.6007-15-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-08-31T10:34:17","name":"[PULL,14/29] virtio-gpu: use DIV_ROUND_UP","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d53bc4957fcabc12434bc7703aab38cf4f00a543","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-15-marcandre.lureau@redhat.com/mbox/","series":[{"id":788,"url":"http://patchwork.ozlabs.org/api/series/788/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788","date":"2017-08-31T10:34:03","name":"[PULL,01/29] i386: use ROUND_UP macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/788/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808171/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808171/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjf8Z44Bcz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 20:42:38 +1000 (AEST)","from localhost ([::1]:54896 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnMvk-0007kR-HC\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:42:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41385)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMpA-0002O7-7S\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:35:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMp7-0005xe-3e\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:35:48 -0400","from mx1.redhat.com ([209.132.183.28]:33508)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnMp6-0005wX-KQ; Thu, 31 Aug 2017 06:35:45 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B0A2E37EE9;\n\tThu, 31 Aug 2017 10:35:43 +0000 (UTC)","from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0223B92B93;\n\tThu, 31 Aug 2017 10:35:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B0A2E37EE9","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Thu, 31 Aug 2017 12:34:17 +0200","Message-Id":"<20170831103432.6007-15-marcandre.lureau@redhat.com>","In-Reply-To":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","References":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 31 Aug 2017 10:35:43 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 14/29] virtio-gpu: use DIV_ROUND_UP","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, peter.maydell@linaro.org, \"Michael S. Tsirkin\"\n\t, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n hw/display/virtio-gpu.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c\nindex 6aae147324..f0761cf18b 100644\n--- a/hw/display/virtio-gpu.c\n+++ b/hw/display/virtio-gpu.c\n@@ -408,7 +408,7 @@ static void virtio_gpu_transfer_to_host_2d(VirtIOGPU *g,\n }\n \n format = pixman_image_get_format(res->image);\n- bpp = (PIXMAN_FORMAT_BPP(format) + 7) / 8;\n+ bpp = DIV_ROUND_UP(PIXMAN_FORMAT_BPP(format), 8);\n stride = pixman_image_get_stride(res->image);\n \n if (t2d.offset || t2d.r.x || t2d.r.y ||\n@@ -570,7 +570,7 @@ static void virtio_gpu_set_scanout(VirtIOGPU *g,\n scanout = &g->scanout[ss.scanout_id];\n \n format = pixman_image_get_format(res->image);\n- bpp = (PIXMAN_FORMAT_BPP(format) + 7) / 8;\n+ bpp = DIV_ROUND_UP(PIXMAN_FORMAT_BPP(format), 8);\n offset = (ss.r.x * bpp) + ss.r.y * pixman_image_get_stride(res->image);\n if (!scanout->ds || surface_data(scanout->ds)\n != ((uint8_t *)pixman_image_get_data(res->image) + offset) ||\n","prefixes":["PULL","14/29"]}