{"id":808163,"url":"http://patchwork.ozlabs.org/api/patches/808163/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-3-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831103432.6007-3-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-08-31T10:34:05","name":"[PULL,02/29] vnc: use QEMU_ALIGN_DOWN","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"00b605a35a1a19cd579f01e1517ba3ffcc9b75ab","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-3-marcandre.lureau@redhat.com/mbox/","series":[{"id":788,"url":"http://patchwork.ozlabs.org/api/series/788/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788","date":"2017-08-31T10:34:03","name":"[PULL,01/29] i386: use ROUND_UP macro","version":1,"mbox":"http://patchwork.ozlabs.org/series/788/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808163/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808163/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjf3c6B51z9s2G\n\tfor ;\n\tThu, 31 Aug 2017 20:38:20 +1000 (AEST)","from localhost ([::1]:54864 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnMra-0003tC-Tw\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:38:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40664)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnMoB-00017z-FO\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:34:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnMoA-0005FL-Lr\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:34:47 -0400","from mx1.redhat.com ([209.132.183.28]:52126)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnMoA-0005F3-Fa; Thu, 31 Aug 2017 06:34:46 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 773D87E437;\n\tThu, 31 Aug 2017 10:34:45 +0000 (UTC)","from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6B7C0841C7;\n\tThu, 31 Aug 2017 10:34:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 773D87E437","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Thu, 31 Aug 2017 12:34:05 +0200","Message-Id":"<20170831103432.6007-3-marcandre.lureau@redhat.com>","In-Reply-To":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","References":"<20170831103432.6007-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 31 Aug 2017 10:34:45 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 02/29] vnc: use QEMU_ALIGN_DOWN","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, peter.maydell@linaro.org, Gerd Hoffmann\n\t, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Richard Henderson \n---\n ui/vnc.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/ui/vnc.c b/ui/vnc.c\nindex 651cbb8606..2c1c0cb5ed 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -2624,8 +2624,8 @@ static int vnc_refresh_lossy_rect(VncDisplay *vd, int x, int y)\n int stx = x / VNC_STAT_RECT;\n int has_dirty = 0;\n \n- y = y / VNC_STAT_RECT * VNC_STAT_RECT;\n- x = x / VNC_STAT_RECT * VNC_STAT_RECT;\n+ y = QEMU_ALIGN_DOWN(y, VNC_STAT_RECT);\n+ x = QEMU_ALIGN_DOWN(x, VNC_STAT_RECT);\n \n QTAILQ_FOREACH(vs, &vd->clients, next) {\n int j;\n@@ -2714,8 +2714,8 @@ double vnc_update_freq(VncState *vs, int x, int y, int w, int h)\n double total = 0;\n int num = 0;\n \n- x = (x / VNC_STAT_RECT) * VNC_STAT_RECT;\n- y = (y / VNC_STAT_RECT) * VNC_STAT_RECT;\n+ x = QEMU_ALIGN_DOWN(x, VNC_STAT_RECT);\n+ y = QEMU_ALIGN_DOWN(y, VNC_STAT_RECT);\n \n for (j = y; j <= y + h; j += VNC_STAT_RECT) {\n for (i = x; i <= x + w; i += VNC_STAT_RECT) {\n","prefixes":["PULL","02/29"]}