{"id":808150,"url":"http://patchwork.ozlabs.org/api/patches/808150/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1708311215030.14191@zhemvz.fhfr.qr/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-08-31T10:15:54","name":"Fix PR82054","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"001b582808d885858d9d52f252d851d6e1a4cdb7","submitter":{"id":4338,"url":"http://patchwork.ozlabs.org/api/people/4338/?format=json","name":"Richard Biener","email":"rguenther@suse.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/alpine.LSU.2.20.1708311215030.14191@zhemvz.fhfr.qr/mbox/","series":[{"id":782,"url":"http://patchwork.ozlabs.org/api/series/782/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=782","date":"2017-08-31T10:15:54","name":"Fix PR82054","version":1,"mbox":"http://patchwork.ozlabs.org/series/782/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808150/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808150/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461201-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"GcjGnQ5v\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjdZ954Pyz9sNr\n\tfor ;\n\tThu, 31 Aug 2017 20:16:15 +1000 (AEST)","(qmail 56640 invoked by alias); 31 Aug 2017 10:16:07 -0000","(qmail 56572 invoked by uid 89); 31 Aug 2017 10:16:07 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tThu, 31 Aug 2017 10:15:56 +0000","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id 8233FABDD\tfor\n\t; Thu, 31 Aug 2017 10:15:54 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; q=dns; s=\n\tdefault; b=k2ZD1QNxJ9q34ohruym4IeQxmwAjAANbs3Im3g2tGj10x/PlDJvFl\n\tTnFK81mQU/99B6iMqY1Va8Vdl23aDglyKM87Ou5kEEQaO9Hs7u2Qspb+5u+INOUp\n\trn76vHcOTZZqrAqT7gBe2bFtvPoVVqUbpnarRtDBlA72+9ocB7eLiw=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=LdoilVN0QBmyA0yxXQww70AnK1Q=; b=GcjGnQ5vkf3AL2RCQMA/\n\tnIYDJKUTuIc0wUJmMAaMwyzlWitz4c4xn8/8m5ushLAMuvpjGdWskfwauNkKaeL6\n\tfiGWXvbiCngcLGKs8vI+Y8FRKjed36tK/ezVYqebLUwBvZCXKEKv9LusiW1MFfRx\n\tzJSlPkBXbaxnDZ68wBqdZmE=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, KAM_ASCII_DIVIDERS, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","Date":"Thu, 31 Aug 2017 12:15:54 +0200 (CEST)","From":"Richard Biener ","To":"gcc-patches@gcc.gnu.org","Subject":"[PATCH] Fix PR82054","Message-ID":"","User-Agent":"Alpine 2.20 (LSU 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII"},"content":"I am testing the following patch to fix another fallout of the\nassert that we dont' add duplicated dwarf attributes.\n\nLTO bootstrapped / bootstrapped on x86_64-unknown-linux-gnu, testing\nin progress.\n\nRichard.\n\n2017-08-31 Richard Biener \n\n\tPR middle-end/82054\n\t* dwarf2out.c (dwarf2out_early_global_decl): Process each\n\tfunction only once.\n\n\t* g++.dg/gomp/pr82054.C: New testcase.","diff":"Index: gcc/dwarf2out.c\n===================================================================\n--- gcc/dwarf2out.c\t(revision 251553)\n+++ gcc/dwarf2out.c\t(working copy)\n@@ -25492,9 +25492,10 @@ dwarf2out_early_global_decl (tree decl)\n if (TREE_CODE (decl) != TYPE_DECL\n && TREE_CODE (decl) != PARM_DECL)\n {\n- tree save_fndecl = current_function_decl;\n if (TREE_CODE (decl) == FUNCTION_DECL)\n \t{\n+\t tree save_fndecl = current_function_decl;\n+\n \t /* For nested functions, make sure we have DIEs for the parents first\n \t so that all nested DIEs are generated at the proper scope in the\n \t first shot. */\n@@ -25521,11 +25522,19 @@ dwarf2out_early_global_decl (tree decl)\n \t dwarf2out_decl (origin);\n \t }\n \n-\t current_function_decl = decl;\n+\t /* Emit the DIE for decl but avoid doing that multiple times. */\n+\t dw_die_ref old_die;\n+\t if ((old_die = lookup_decl_die (decl)) == NULL\n+\t || is_declaration_die (old_die))\n+\t {\n+\t current_function_decl = decl;\n+\t dwarf2out_decl (decl);\n+\t }\n+\n+\t current_function_decl = save_fndecl;\n \t}\n- dwarf2out_decl (decl);\n- if (TREE_CODE (decl) == FUNCTION_DECL)\n-\tcurrent_function_decl = save_fndecl;\n+ else\n+\tdwarf2out_decl (decl);\n }\n symtab->global_info_ready = save;\n }\nIndex: gcc/testsuite/g++.dg/gomp/pr82054.C\n===================================================================\n--- gcc/testsuite/g++.dg/gomp/pr82054.C\t(revision 0)\n+++ gcc/testsuite/g++.dg/gomp/pr82054.C\t(working copy)\n@@ -0,0 +1,13 @@\n+// { dg-do compile }\n+// { dg-additional-options \"-g\" }\n+\n+class a\n+{\n+ bool b ();\n+};\n+bool\n+a::b ()\n+{\n+#pragma omp parallel\n+ ;\n+}\n","prefixes":[]}