{"id":808141,"url":"http://patchwork.ozlabs.org/api/patches/808141/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com/","date":"2017-08-31T09:14:56","name":"[v2] perf test powerpc: Fix 'Object code reading' test","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"193e558746696577af7e48e6175e6009d7d87ca6","submitter":{"id":68445,"url":"http://patchwork.ozlabs.org/api/people/68445/?format=json","name":"Ravi Bangoria","email":"ravi.bangoria@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com/mbox/","series":[{"id":774,"url":"http://patchwork.ozlabs.org/api/series/774/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=774","date":"2017-08-31T09:14:56","name":"[v2] perf test powerpc: Fix 'Object code reading' test","version":2,"mbox":"http://patchwork.ozlabs.org/series/774/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808141/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808141/checks/","tags":{},"related":[],"headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjcFD5Qcpz9sRW\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 19:16:32 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjcFD4SVXzDqYs\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 19:16:32 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjcCh6G1szDqjk\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 31 Aug 2017 19:15:12 +1000 (AEST)","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7V9ELRr085459\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Aug 2017 05:15:10 -0400","from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cpca8k0ad-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Aug 2017 05:15:09 -0400","from localhost\n\tby e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from\n\t<ravi.bangoria@linux.vnet.ibm.com>; \n\tThu, 31 Aug 2017 19:15:06 +1000","from d23relay07.au.ibm.com (202.81.31.226)\n\tby e23smtp05.au.ibm.com (202.81.31.211) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 19:15:04 +1000","from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7V9F4xY34275574\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Aug 2017 19:15:04 +1000","from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7V9F3AZ004113\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Aug 2017 19:15:04 +1000","from bangoria.in.ibm.com ([9.109.223.110])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7V9EvgI003703; Thu, 31 Aug 2017 19:14:59 +1000"],"From":"Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>","To":"acme@kernel.org","Subject":"[PATCH v2] perf test powerpc: Fix 'Object code reading' test","Date":"Thu, 31 Aug 2017 14:44:56 +0530","X-Mailer":"git-send-email 2.1.4","X-TM-AS-MML":"disable","x-cbid":"17083109-0016-0000-0000-00000261BF32","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17083109-0017-0000-0000-000006E490EF","Message-Id":"<1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310141","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"peterz@infradead.org, adrian.hunter@intel.com,\n\tlinux-kernel@vger.kernel.org, \n\talexander.shishkin@linux.intel.com, mingo@redhat.com, jolsa@kernel.org,\n\tnamhyung@kernel.org, Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,\n\tlinuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"},"content":"'Object code reading' test always fails on powerpc guest. Two reasons\nfor the failure are:\n\n1. When elf section is too big (size beyond 'unsigned int' max value).\nobjdump fails to disassemble from such section. This was fixed with\ncommit 0f6329bd7fc (\"binutils/objdump: Fix disassemble for huge elf\nsections\") in binutils.\n\n2. When the sample is from hypervisor. Hypervisor symbols can not\nbe resolved within guest and thus thread__find_addr_map() fails for\nsuch symbols. Fix this by ignoring hypervisor symbols in the test.\n\nSigned-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>\n---\nChanges in v2:\n - Add pr_debug()\n\n tools/perf/tests/code-reading.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c\nindex 761c5a4..466a462 100644\n--- a/tools/perf/tests/code-reading.c\n+++ b/tools/perf/tests/code-reading.c\n@@ -237,6 +237,11 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,\n \n \tthread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al);\n \tif (!al.map || !al.map->dso) {\n+\t\tif (cpumode == PERF_RECORD_MISC_HYPERVISOR) {\n+\t\t\tpr_debug(\"Hypervisor address can not be resolved - skipping\\n\");\n+\t\t\treturn 0;\n+\t\t}\n+\n \t\tpr_debug(\"thread__find_addr_map failed\\n\");\n \t\treturn -1;\n \t}\n","prefixes":["v2"]}