{"id":808130,"url":"http://patchwork.ozlabs.org/api/patches/808130/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831082210.8362-9-stefanha@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831082210.8362-9-stefanha@redhat.com>","list_archive_url":null,"date":"2017-08-31T08:22:03","name":"[PULL,for-2.10,08/15] throttle: Test the valid range of config values","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7c759b5ac96f574f04393881309bc580691c1849","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/?format=json","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831082210.8362-9-stefanha@redhat.com/mbox/","series":[{"id":766,"url":"http://patchwork.ozlabs.org/api/series/766/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=766","date":"2017-08-31T08:21:55","name":"[PULL,for-2.10,01/15] nvme: Fix get/set number of queues feature, again","version":1,"mbox":"http://patchwork.ozlabs.org/series/766/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808130/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808130/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjbCS01jKz9s7c\n\tfor ;\n\tThu, 31 Aug 2017 18:29:56 +1000 (AEST)","from localhost ([::1]:54495 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKrK-0002em-36\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 04:29:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42526)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKkN-0005QM-La\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:22:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKkM-0005ur-OV\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:22:43 -0400","from mx1.redhat.com ([209.132.183.28]:41402)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnKkM-0005ul-GN\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:22:42 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A7420C05A1BA;\n\tThu, 31 Aug 2017 08:22:41 +0000 (UTC)","from localhost (ovpn-117-89.ams2.redhat.com [10.36.117.89])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3020392D0F;\n\tThu, 31 Aug 2017 08:22:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A7420C05A1BA","From":"Stefan Hajnoczi ","To":"","Date":"Thu, 31 Aug 2017 09:22:03 +0100","Message-Id":"<20170831082210.8362-9-stefanha@redhat.com>","In-Reply-To":"<20170831082210.8362-1-stefanha@redhat.com>","References":"<20170831082210.8362-1-stefanha@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 08:22:41 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL for-2.10 08/15] throttle: Test the valid range\n\tof config values","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tAlberto Garcia , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Alberto Garcia \n\nSigned-off-by: Alberto Garcia \nMessage-id: a57dd6274e1b6dc9c28769fec4c7ea543be5c5e3.1503580370.git.berto@igalia.com\nSigned-off-by: Stefan Hajnoczi \n---\n tests/test-throttle.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 77 insertions(+)","diff":"diff --git a/tests/test-throttle.c b/tests/test-throttle.c\nindex 41c0dd2529..bf7a5a648a 100644\n--- a/tests/test-throttle.c\n+++ b/tests/test-throttle.c\n@@ -378,6 +378,82 @@ static void test_is_valid(void)\n test_is_valid_for_value(1, true);\n }\n \n+static void test_ranges(void)\n+{\n+ int i;\n+\n+ for (i = 0; i < BUCKETS_COUNT; i++) {\n+ LeakyBucket *b = &cfg.buckets[i];\n+ throttle_config_init(&cfg);\n+\n+ /* avg = 0 means throttling is disabled, but the config is valid */\n+ b->avg = 0;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+ g_assert(!throttle_enabled(&cfg));\n+\n+ /* These are valid configurations (values <= THROTTLE_VALUE_MAX) */\n+ b->avg = 1;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = THROTTLE_VALUE_MAX;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = THROTTLE_VALUE_MAX;\n+ b->max = THROTTLE_VALUE_MAX;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ /* Values over THROTTLE_VALUE_MAX are not allowed */\n+ b->avg = THROTTLE_VALUE_MAX + 1;\n+ g_assert(!throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = THROTTLE_VALUE_MAX;\n+ b->max = THROTTLE_VALUE_MAX + 1;\n+ g_assert(!throttle_is_valid(&cfg, NULL));\n+\n+ /* burst_length must be between 1 and THROTTLE_VALUE_MAX */\n+ b->avg = 1;\n+ b->max = 1;\n+ b->burst_length = 0;\n+ g_assert(!throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = 1;\n+ b->max = 1;\n+ b->burst_length = 1;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = 1;\n+ b->max = 1;\n+ b->burst_length = THROTTLE_VALUE_MAX;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = 1;\n+ b->max = 1;\n+ b->burst_length = THROTTLE_VALUE_MAX + 1;\n+ g_assert(!throttle_is_valid(&cfg, NULL));\n+\n+ /* burst_length * max cannot exceed THROTTLE_VALUE_MAX */\n+ b->avg = 1;\n+ b->max = 2;\n+ b->burst_length = THROTTLE_VALUE_MAX / 2;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = 1;\n+ b->max = 3;\n+ b->burst_length = THROTTLE_VALUE_MAX / 2;\n+ g_assert(!throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = 1;\n+ b->max = THROTTLE_VALUE_MAX;\n+ b->burst_length = 1;\n+ g_assert(throttle_is_valid(&cfg, NULL));\n+\n+ b->avg = 1;\n+ b->max = THROTTLE_VALUE_MAX;\n+ b->burst_length = 2;\n+ g_assert(!throttle_is_valid(&cfg, NULL));\n+ }\n+}\n+\n static void test_max_is_missing_limit(void)\n {\n int i;\n@@ -669,6 +745,7 @@ int main(int argc, char **argv)\n g_test_add_func(\"/throttle/config/enabled\", test_enabled);\n g_test_add_func(\"/throttle/config/conflicting\", test_conflicting_config);\n g_test_add_func(\"/throttle/config/is_valid\", test_is_valid);\n+ g_test_add_func(\"/throttle/config/ranges\", test_ranges);\n g_test_add_func(\"/throttle/config/max\", test_max_is_missing_limit);\n g_test_add_func(\"/throttle/config/iops_size\",\n test_iops_size_is_missing_limit);\n","prefixes":["PULL","for-2.10","08/15"]}