{"id":808124,"url":"http://patchwork.ozlabs.org/api/patches/808124/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831082210.8362-10-stefanha@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831082210.8362-10-stefanha@redhat.com>","list_archive_url":null,"date":"2017-08-31T08:22:04","name":"[PULL,for-2.10,09/15] oslib-posix: Print errors before aborting on qemu_alloc_stack()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"22b752fd1265d55ebe3fe4f583b6b94bc56dc420","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/?format=json","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831082210.8362-10-stefanha@redhat.com/mbox/","series":[{"id":766,"url":"http://patchwork.ozlabs.org/api/series/766/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=766","date":"2017-08-31T08:21:55","name":"[PULL,for-2.10,01/15] nvme: Fix get/set number of queues feature, again","version":1,"mbox":"http://patchwork.ozlabs.org/series/766/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/808124/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/808124/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjb6Q2kfgz9t16\n\tfor ;\n\tThu, 31 Aug 2017 18:25:34 +1000 (AEST)","from localhost ([::1]:54476 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnKn6-00075D-C8\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 04:25:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42537)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnKkQ-0005SW-3a\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:22:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnKkP-0005vJ-5E\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:22:46 -0400","from mx1.redhat.com ([209.132.183.28]:38784)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnKkO-0005vD-VF\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 04:22:45 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 23D0D4024B;\n\tThu, 31 Aug 2017 08:22:44 +0000 (UTC)","from localhost (ovpn-117-89.ams2.redhat.com [10.36.117.89])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 14BAF92D01;\n\tThu, 31 Aug 2017 08:22:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 23D0D4024B","From":"Stefan Hajnoczi ","To":"","Date":"Thu, 31 Aug 2017 09:22:04 +0100","Message-Id":"<20170831082210.8362-10-stefanha@redhat.com>","In-Reply-To":"<20170831082210.8362-1-stefanha@redhat.com>","References":"<20170831082210.8362-1-stefanha@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 31 Aug 2017 08:22:44 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL for-2.10 09/15] oslib-posix: Print errors before\n\taborting on qemu_alloc_stack()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tEduardo Habkost ,\n\tStefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Eduardo Habkost \n\nIf QEMU is running on a system that's out of memory and mmap()\nfails, QEMU aborts with no error message at all, making it hard\nto debug the reason for the failure.\n\nAdd perror() calls that will print error information before\naborting.\n\nSigned-off-by: Eduardo Habkost \nReviewed-by: Philippe Mathieu-Daudé \nTested-by: Philippe Mathieu-Daudé \nMessage-id: 20170829212053.6003-1-ehabkost@redhat.com\nSigned-off-by: Stefan Hajnoczi \n---\n util/oslib-posix.c | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/util/oslib-posix.c b/util/oslib-posix.c\nindex cacf0ef5e3..80086c549f 100644\n--- a/util/oslib-posix.c\n+++ b/util/oslib-posix.c\n@@ -530,6 +530,7 @@ void *qemu_alloc_stack(size_t *sz)\n ptr = mmap(NULL, *sz, PROT_READ | PROT_WRITE,\n MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);\n if (ptr == MAP_FAILED) {\n+ perror(\"failed to allocate memory for stack\");\n abort();\n }\n \n@@ -544,6 +545,7 @@ void *qemu_alloc_stack(size_t *sz)\n guardpage = ptr;\n #endif\n if (mprotect(guardpage, pagesz, PROT_NONE) != 0) {\n+ perror(\"failed to set up stack guard page\");\n abort();\n }\n \n","prefixes":["PULL","for-2.10","09/15"]}