{"id":807998,"url":"http://patchwork.ozlabs.org/api/patches/807998/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/patch/20170831033846.23538-1-sam@mendozajonas.com/","project":{"id":56,"url":"http://patchwork.ozlabs.org/api/projects/56/?format=json","name":"OpenBMC development","link_name":"openbmc","list_id":"openbmc.lists.ozlabs.org","list_email":"openbmc@lists.ozlabs.org","web_url":"http://github.com/openbmc/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170831033846.23538-1-sam@mendozajonas.com>","list_archive_url":null,"date":"2017-08-31T03:38:46","name":"[net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"7b7887e7ee1f11dfac7ac0d552028bdcb78a8483","submitter":{"id":68013,"url":"http://patchwork.ozlabs.org/api/people/68013/?format=json","name":"Sam Mendoza-Jonas","email":"sam@mendozajonas.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openbmc/patch/20170831033846.23538-1-sam@mendozajonas.com/mbox/","series":[{"id":732,"url":"http://patchwork.ozlabs.org/api/series/732/?format=json","web_url":"http://patchwork.ozlabs.org/project/openbmc/list/?series=732","date":"2017-08-31T03:38:46","name":"[net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI","version":1,"mbox":"http://patchwork.ozlabs.org/series/732/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807998/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807998/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjSlw2F6Nz9s2G\n\tfor ;\n\tThu, 31 Aug 2017 13:39:08 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjSlv4ffBzDq5b\n\tfor ;\n\tThu, 31 Aug 2017 13:39:07 +1000 (AEST)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjSlh31rGzDqF4\n\tfor ; Thu, 31 Aug 2017 13:38:56 +1000 (AEST)","from compute2.internal (compute2.nyi.internal [10.202.2.42])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 2C40121B9C;\n\tWed, 30 Aug 2017 23:38:54 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute2.internal (MEProxy); Wed, 30 Aug 2017 23:38:54 -0400","from v4.ozlabs.ibm.com (unknown [122.99.82.10])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 9443724253;\n\tWed, 30 Aug 2017 23:38:51 -0400 (EDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"pWGbfMK4\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"VYKFKdiD\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"pWGbfMK4\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"VYKFKdiD\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mendozajonas.com header.i=@mendozajonas.com\n\theader.b=\"pWGbfMK4\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"VYKFKdiD\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmendozajonas.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=JXJECG\n\t3H6ciM/5gVUYz80mVFOrhDE0+4TToYiQcz0Ao=; b=pWGbfMK46l3uXGQseLWelm\n\t5oCyKXvQpZfpk1/7voYl5sC+cPraf/fbK4o8sfleRNaROLJ4TXS2Y48+KLKCWNb0\n\t14XroXgJccg/fkG1xaKYZbL42YrJ0uYNt0VmvI1Y2hhES7UFBp9WCLmqxVu/qKyJ\n\tL69yQJunk3EI8XdpJ3192ctpqGRicVJdwlkkAKrW+wIPsP9Nqsc5OKs8iad3EOkO\n\tfq4LjIakmJspceVparMZ1eH0pdMz//f19qJ4+2mFpgzKu+NdSa0EeViXVm8gjqAT\n\tUJIkVOYEPgZ+ZbHKl+HrSswXY+5JdCs2u5mPJDyWCl+ZC1LTnBthC0rlOjYHJFBQ\n\t==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=JXJECG\n\t3H6ciM/5gVUYz80mVFOrhDE0+4TToYiQcz0Ao=; b=VYKFKdiDZgVaNcY3fxwX7v\n\tzaSmkN6Z8QU7u20EDFnhAhgPv9IsquvzT9gN1+sJhCmQdgGShR6qvyD7VuVdqj/p\n\te60tLmP97WnBBdibN0qo3238uzaBltJM0YFP5NLTSsXxOYrbEEPcKVQ+AxDjqem6\n\tYF6ujMdqTQ/aSzYwhnHxAxdkfkKdv1IIdbMZ3+ylJmAc0I7+FcixHlpOdqi+7r/8\n\tcrErG75xI8Gk8RYs3toPSf4Gt5cUBIjush+1pDEFDZx4EU8+OZd0N9JWOGClExQI\n\to7R7qrh+R0dqbItoh2EUFdeYXkKspz6hOBUR1AuGEWhAygE+FBbBvaGdRjPqrGdQ\n\t=="],"X-ME-Sender":"","X-Sasl-enc":"y3pcSWo2N44HlpTsdsYWbj6RazPd5ZOtrQJ18+3O8aiO 1504150733","From":"Samuel Mendoza-Jonas ","To":"\"David S . Miller\" , netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, OpenBMC Maillist ","Subject":"[PATCH net-next] net/ncsi: Define {add,\n\tkill}_vid callbacks for !CONFIG_NET_NCSI","Date":"Thu, 31 Aug 2017 13:38:46 +1000","Message-Id":"<20170831033846.23538-1-sam@mendozajonas.com>","X-Mailer":"git-send-email 2.14.1","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Development list for OpenBMC ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Samuel Mendoza-Jonas ,\n\tGavin Shan ","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t"},"content":"Patch \"net/ncsi: Configure VLAN tag filter\" defined two new callback\nfunctions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI\ncase. This can cause a build error if these are referenced elsewhere\nwithout NCSI enabled, for example in ftgmac100:\n\n>>> ERROR: \"ncsi_vlan_rx_kill_vid\" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n>>> ERROR: \"ncsi_vlan_rx_add_vid\" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined!\n\nAdd definitions for !CONFIG_NET_NCSI to bring it into line with the rest\nof ncsi.h\n\nSigned-off-by: Samuel Mendoza-Jonas \n---\n include/net/ncsi.h | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/include/net/ncsi.h b/include/net/ncsi.h\nindex 1f96af46df49..2b13b6b91a4d 100644\n--- a/include/net/ncsi.h\n+++ b/include/net/ncsi.h\n@@ -36,6 +36,14 @@ int ncsi_start_dev(struct ncsi_dev *nd);\n void ncsi_stop_dev(struct ncsi_dev *nd);\n void ncsi_unregister_dev(struct ncsi_dev *nd);\n #else /* !CONFIG_NET_NCSI */\n+int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)\n+{\n+\treturn -ENOTTY;\n+}\n+int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)\n+{\n+\treturn -ENOTTY;\n+}\n static inline struct ncsi_dev *ncsi_register_dev(struct net_device *dev,\n \t\t\t\t\tvoid (*notifier)(struct ncsi_dev *nd))\n {\n","prefixes":["net-next"]}