{"id":807946,"url":"http://patchwork.ozlabs.org/api/patches/807946/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-4-saeedm@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830222110.15737-4-saeedm@mellanox.com>","list_archive_url":null,"date":"2017-08-30T22:21:02","name":"[net,03/11] net/mlx5: Fix arm SRQ command for ISSI version 0","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"4d21a01ea362627078ab87024e8292d12371b733","submitter":{"id":65299,"url":"http://patchwork.ozlabs.org/api/people/65299/?format=json","name":"Saeed Mahameed","email":"saeedm@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-4-saeedm@mellanox.com/mbox/","series":[{"id":707,"url":"http://patchwork.ozlabs.org/api/series/707/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=707","date":"2017-08-30T22:21:00","name":"[net,01/11] net/mlx5e: Check for qos capability in dcbnl_initialize","version":1,"mbox":"http://patchwork.ozlabs.org/series/707/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807946/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807946/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKkS5G4Cz9s8w\n\tfor ;\n\tThu, 31 Aug 2017 08:22:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751488AbdH3WWS (ORCPT );\n\tWed, 30 Aug 2017 18:22:18 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:53228 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751286AbdH3WVc (ORCPT\n\t); Wed, 30 Aug 2017 18:21:32 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 31 Aug 2017 01:21:29 +0300","from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7UMLSB0009018;\n\tThu, 31 Aug 2017 01:21:28 +0300"],"From":"Saeed Mahameed ","To":"\"David S. Miller\" ","Cc":"netdev@vger.kernel.org, Noa Osherovich ,\n\tSaeed Mahameed ","Subject":"[net 03/11] net/mlx5: Fix arm SRQ command for ISSI version 0","Date":"Thu, 31 Aug 2017 01:21:02 +0300","Message-Id":"<20170830222110.15737-4-saeedm@mellanox.com>","X-Mailer":"git-send-email 2.13.0","In-Reply-To":"<20170830222110.15737-1-saeedm@mellanox.com>","References":"<20170830222110.15737-1-saeedm@mellanox.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Noa Osherovich \n\nSupport for ISSI version 0 was recently broken as the arm_srq_cmd\ncommand, which is used only for ISSI version 0, was given the opcode\nfor ISSI version 1 instead of ISSI version 0.\n\nChange arm_srq_cmd to use the correct command opcode for ISSI version\n0.\n\nFixes: af1ba291c5e4 ('{net, IB}/mlx5: Refactor internal SRQ API')\nSigned-off-by: Noa Osherovich \nSigned-off-by: Saeed Mahameed \n---\n drivers/net/ethernet/mellanox/mlx5/core/srq.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx5/core/srq.c b/drivers/net/ethernet/mellanox/mlx5/core/srq.c\nindex f774de6f5fcb..520f6382dfde 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/srq.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/srq.c\n@@ -201,13 +201,13 @@ static int destroy_srq_cmd(struct mlx5_core_dev *dev,\n static int arm_srq_cmd(struct mlx5_core_dev *dev, struct mlx5_core_srq *srq,\n \t\t u16 lwm, int is_srq)\n {\n-\t/* arm_srq structs missing using identical xrc ones */\n-\tu32 srq_in[MLX5_ST_SZ_DW(arm_xrc_srq_in)] = {0};\n-\tu32 srq_out[MLX5_ST_SZ_DW(arm_xrc_srq_out)] = {0};\n+\tu32 srq_in[MLX5_ST_SZ_DW(arm_rq_in)] = {0};\n+\tu32 srq_out[MLX5_ST_SZ_DW(arm_rq_out)] = {0};\n \n-\tMLX5_SET(arm_xrc_srq_in, srq_in, opcode, MLX5_CMD_OP_ARM_XRC_SRQ);\n-\tMLX5_SET(arm_xrc_srq_in, srq_in, xrc_srqn, srq->srqn);\n-\tMLX5_SET(arm_xrc_srq_in, srq_in, lwm, lwm);\n+\tMLX5_SET(arm_rq_in, srq_in, opcode, MLX5_CMD_OP_ARM_RQ);\n+\tMLX5_SET(arm_rq_in, srq_in, op_mod, MLX5_ARM_RQ_IN_OP_MOD_SRQ);\n+\tMLX5_SET(arm_rq_in, srq_in, srq_number, srq->srqn);\n+\tMLX5_SET(arm_rq_in, srq_in, lwm, lwm);\n \n \treturn mlx5_cmd_exec(dev, srq_in, sizeof(srq_in),\n \t\t\t srq_out, sizeof(srq_out));\n","prefixes":["net","03/11"]}