{"id":807942,"url":"http://patchwork.ozlabs.org/api/patches/807942/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-12-saeedm@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830222110.15737-12-saeedm@mellanox.com>","list_archive_url":null,"date":"2017-08-30T22:21:10","name":"[net,11/11] net/mlx5e: Fix CQ moderation mode not set properly","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"5466716dc6001fb7800b568e7a6c94c5af91c481","submitter":{"id":65299,"url":"http://patchwork.ozlabs.org/api/people/65299/?format=json","name":"Saeed Mahameed","email":"saeedm@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-12-saeedm@mellanox.com/mbox/","series":[{"id":707,"url":"http://patchwork.ozlabs.org/api/series/707/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=707","date":"2017-08-30T22:21:00","name":"[net,01/11] net/mlx5e: Check for qos capability in dcbnl_initialize","version":1,"mbox":"http://patchwork.ozlabs.org/series/707/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807942/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807942/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKk503dRz9sN5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 08:22:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751434AbdH3WVl (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 18:21:41 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:53278 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751375AbdH3WVd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 18:21:33 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 31 Aug 2017 01:21:29 +0300","from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7UMLSB8009018;\n\tThu, 31 Aug 2017 01:21:29 +0300"],"From":"Saeed Mahameed <saeedm@mellanox.com>","To":"\"David S. Miller\" <davem@davemloft.net>","Cc":"netdev@vger.kernel.org, Tal Gilboa <talgi@mellanox.com>,\n\tSaeed Mahameed <saeedm@mellanox.com>","Subject":"[net 11/11] net/mlx5e: Fix CQ moderation mode not set properly","Date":"Thu, 31 Aug 2017 01:21:10 +0300","Message-Id":"<20170830222110.15737-12-saeedm@mellanox.com>","X-Mailer":"git-send-email 2.13.0","In-Reply-To":"<20170830222110.15737-1-saeedm@mellanox.com>","References":"<20170830222110.15737-1-saeedm@mellanox.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Tal Gilboa <talgi@mellanox.com>\n\ncq_period_mode assignment was mistakenly removed so it was always set to \"0\",\nwhich is EQE based moderation, regardless of the device CAPs and\nrequested value in ethtool.\n\nFixes: 6a9764efb255 (\"net/mlx5e: Isolate open_channels from priv->params\")\nSigned-off-by: Tal Gilboa <talgi@mellanox.com>\nSigned-off-by: Saeed Mahameed <saeedm@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\nindex 57f31fa478ce..6ad7f07e7861 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n@@ -1969,6 +1969,7 @@ static void mlx5e_build_rx_cq_param(struct mlx5e_priv *priv,\n \t}\n \n \tmlx5e_build_common_cq_param(priv, param);\n+\tparam->cq_period_mode = params->rx_cq_period_mode;\n }\n \n static void mlx5e_build_tx_cq_param(struct mlx5e_priv *priv,\n","prefixes":["net","11/11"]}