{"id":807938,"url":"http://patchwork.ozlabs.org/api/patches/807938/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-9-saeedm@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830222110.15737-9-saeedm@mellanox.com>","list_archive_url":null,"date":"2017-08-30T22:21:07","name":"[net,08/11] net/mlx5e: Properly resolve TC offloaded ipv6 vxlan tunnel source address","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"e491307431e305acad2e79e7cf98d414df8aa21e","submitter":{"id":65299,"url":"http://patchwork.ozlabs.org/api/people/65299/?format=json","name":"Saeed Mahameed","email":"saeedm@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-9-saeedm@mellanox.com/mbox/","series":[{"id":707,"url":"http://patchwork.ozlabs.org/api/series/707/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=707","date":"2017-08-30T22:21:00","name":"[net,01/11] net/mlx5e: Check for qos capability in dcbnl_initialize","version":1,"mbox":"http://patchwork.ozlabs.org/series/707/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807938/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807938/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKjh2T63z9sN5\n\tfor ;\n\tThu, 31 Aug 2017 08:21:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751480AbdH3WVl (ORCPT );\n\tWed, 30 Aug 2017 18:21:41 -0400","from mail-il-dmz.mellanox.com ([193.47.165.129]:53266 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751372AbdH3WVd (ORCPT\n\t); Wed, 30 Aug 2017 18:21:33 -0400","from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 31 Aug 2017 01:21:29 +0300","from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7UMLSB5009018;\n\tThu, 31 Aug 2017 01:21:29 +0300"],"From":"Saeed Mahameed ","To":"\"David S. Miller\" ","Cc":"netdev@vger.kernel.org, Paul Blakey ,\n\tSaeed Mahameed ","Subject":"[net 08/11] net/mlx5e: Properly resolve TC offloaded ipv6 vxlan\n\ttunnel source address","Date":"Thu, 31 Aug 2017 01:21:07 +0300","Message-Id":"<20170830222110.15737-9-saeedm@mellanox.com>","X-Mailer":"git-send-email 2.13.0","In-Reply-To":"<20170830222110.15737-1-saeedm@mellanox.com>","References":"<20170830222110.15737-1-saeedm@mellanox.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Paul Blakey \n\nCurrently if vxlan tunnel ipv6 src isn't supplied the driver fails to\nresolve it as part of the route lookup. The resulting encap header\nis left with a zeroed out ipv6 src address so the packets are sent\nwith this src ip.\n\nUse an appropriate route lookup API that also resolves the source\nipv6 address if it's not supplied.\n\nFixes: ce99f6b97fcd ('net/mlx5e: Support SRIOV TC encapsulation offloads for IPv6 tunnels')\nSigned-off-by: Paul Blakey \nReviewed-by: Or Gerlitz \nReviewed-by: Roi Dayan \nSigned-off-by: Saeed Mahameed \n---\n drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c\nindex 3c536f560dd2..7f282e8f4e7f 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c\n@@ -1443,12 +1443,10 @@ static int mlx5e_route_lookup_ipv6(struct mlx5e_priv *priv,\n \tstruct mlx5_eswitch *esw = priv->mdev->priv.eswitch;\n \tint ret;\n \n-\tdst = ip6_route_output(dev_net(mirred_dev), NULL, fl6);\n-\tret = dst->error;\n-\tif (ret) {\n-\t\tdst_release(dst);\n+\tret = ipv6_stub->ipv6_dst_lookup(dev_net(mirred_dev), NULL, &dst,\n+\t\t\t\t\t fl6);\n+\tif (ret < 0)\n \t\treturn ret;\n-\t}\n \n \t*out_ttl = ip6_dst_hoplimit(dst);\n \n","prefixes":["net","08/11"]}