{"id":807810,"url":"http://patchwork.ozlabs.org/api/patches/807810/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504115149-26864-2-git-send-email-ktraynor@redhat.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504115149-26864-2-git-send-email-ktraynor@redhat.com>","list_archive_url":null,"date":"2017-08-30T17:45:48","name":"[ovs-dev,2/3] dpif-netdev: Fix a couple of coding style issues.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3e8e0482ff5b412464774837ffc9d553f5afaffe","submitter":{"id":70482,"url":"http://patchwork.ozlabs.org/api/people/70482/?format=json","name":"Kevin Traynor","email":"ktraynor@redhat.com"},"delegate":{"id":67810,"url":"http://patchwork.ozlabs.org/api/users/67810/?format=json","username":"darball1","first_name":"Darrell","last_name":"Ball","email":"dlu998@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504115149-26864-2-git-send-email-ktraynor@redhat.com/mbox/","series":[{"id":672,"url":"http://patchwork.ozlabs.org/api/series/672/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=672","date":"2017-08-30T17:45:47","name":"[ovs-dev,1/3] dpif-netdev: Rename rxq_interval.","version":1,"mbox":"http://patchwork.ozlabs.org/series/672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807810/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807810/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ktraynor@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCc82g5yz9sN5\n\tfor ;\n\tThu, 31 Aug 2017 03:46:32 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 376C0C0C;\n\tWed, 30 Aug 2017 17:46:03 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 6E3B6C04\n\tfor ; Wed, 30 Aug 2017 17:46:00 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id EC3D342E\n\tfor ; Wed, 30 Aug 2017 17:45:59 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 61AB95F7BD;\n\tWed, 30 Aug 2017 17:45:59 +0000 (UTC)","from ktraynor.remote.csb (ovpn-117-75.ams2.redhat.com\n\t[10.36.117.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DE18E9B519;\n\tWed, 30 Aug 2017 17:45:57 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 17:45:59 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 61AB95F7BD","From":"Kevin Traynor ","To":"dev@openvswitch.org, ktraynor@redhat.com, dball@vmware.com,\n\ti.maximets@samsung.com","Date":"Wed, 30 Aug 2017 18:45:48 +0100","Message-Id":"<1504115149-26864-2-git-send-email-ktraynor@redhat.com>","In-Reply-To":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>","References":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 2/3] dpif-netdev: Fix a couple of coding style\n\tissues.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"A couple of trivial fixes for a ternery operator placement\nand pointer declaration.\n\nFixes: 655856ef39b9 (\"dpif-netdev: Change rxq_scheduling to use rxq processing cycles.\")\nFixes: a2ac666d5265 (\"dpif-netdev: Change definitions of 'idle' & 'processing' cycles\")\nCc: ciara.loftus@intel.com\nReported-by: Ilya Maximets \nSigned-off-by: Kevin Traynor \n---\n lib/dpif-netdev.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)","diff":"diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex 55d5656..1db9f10 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -3429,6 +3429,6 @@ static int\n rxq_cycle_sort(const void *a, const void *b)\n {\n- struct dp_netdev_rxq * qa;\n- struct dp_netdev_rxq * qb;\n+ struct dp_netdev_rxq *qa;\n+ struct dp_netdev_rxq *qb;\n uint64_t total_qa, total_qb;\n unsigned i;\n@@ -3865,7 +3865,8 @@ dpif_netdev_run(struct dpif *dpif)\n port->rxqs[i].rx,\n port->port_no);\n- cycles_count_intermediate(non_pmd, NULL, process_packets ?\n- PMD_CYCLES_PROCESSING\n- : PMD_CYCLES_IDLE);\n+ cycles_count_intermediate(non_pmd, NULL,\n+ process_packets\n+ ? PMD_CYCLES_PROCESSING\n+ : PMD_CYCLES_IDLE);\n }\n }\n","prefixes":["ovs-dev","2/3"]}