{"id":807809,"url":"http://patchwork.ozlabs.org/api/patches/807809/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504115149-26864-1-git-send-email-ktraynor@redhat.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>","list_archive_url":null,"date":"2017-08-30T17:45:47","name":"[ovs-dev,1/3] dpif-netdev: Rename rxq_interval.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6ad8dafd08410ab199cc6a856168b11321edb924","submitter":{"id":70482,"url":"http://patchwork.ozlabs.org/api/people/70482/?format=json","name":"Kevin Traynor","email":"ktraynor@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504115149-26864-1-git-send-email-ktraynor@redhat.com/mbox/","series":[{"id":672,"url":"http://patchwork.ozlabs.org/api/series/672/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=672","date":"2017-08-30T17:45:47","name":"[ovs-dev,1/3] dpif-netdev: Rename rxq_interval.","version":1,"mbox":"http://patchwork.ozlabs.org/series/672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807809/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807809/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ktraynor@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCbY4LRWz9sN5\n\tfor ;\n\tThu, 31 Aug 2017 03:46:01 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 4ACF7BE5;\n\tWed, 30 Aug 2017 17:45:59 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id CBECEBD5\n\tfor ; Wed, 30 Aug 2017 17:45:57 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 363E742E\n\tfor ; Wed, 30 Aug 2017 17:45:57 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 81CF1883AE;\n\tWed, 30 Aug 2017 17:45:56 +0000 (UTC)","from ktraynor.remote.csb (ovpn-117-75.ams2.redhat.com\n\t[10.36.117.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0F5D49FFE0;\n\tWed, 30 Aug 2017 17:45:54 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 30 Aug 2017 17:45:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 81CF1883AE","From":"Kevin Traynor ","To":"dev@openvswitch.org, ktraynor@redhat.com, dball@vmware.com,\n\ti.maximets@samsung.com","Date":"Wed, 30 Aug 2017 18:45:47 +0100","Message-Id":"<1504115149-26864-1-git-send-email-ktraynor@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 1/3] dpif-netdev: Rename rxq_interval.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"rxq_interval was added before there was other #defines\nand code related to rxq intervals.\n\nRename to rxq_next_cycles_store in order to make it more intuitive.\n\nReported-by: Ilya Maximets \nSigned-off-by: Kevin Traynor \n---\n lib/dpif-netdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex 071ec14..55d5656 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -576,5 +576,5 @@ struct dp_netdev_pmd_thread {\n /* End of the next time interval for which processing cycles\n are stored for each polled rxq. */\n- long long int rxq_interval;\n+ long long int rxq_next_cycle_store;\n \n /* Statistics. */\n@@ -4507,5 +4507,5 @@ dp_netdev_configure_pmd(struct dp_netdev_pmd_thread *pmd, struct dp_netdev *dp,\n cmap_init(&pmd->classifiers);\n pmd->next_optimization = time_msec() + DPCLS_OPTIMIZATION_INTERVAL;\n- pmd->rxq_interval = time_msec() + PMD_RXQ_INTERVAL_LEN;\n+ pmd->rxq_next_cycle_store = time_msec() + PMD_RXQ_INTERVAL_LEN;\n hmap_init(&pmd->poll_list);\n hmap_init(&pmd->tx_ports);\n@@ -5951,5 +5951,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n long long int now = time_msec();\n \n- if (now > pmd->rxq_interval) {\n+ if (now > pmd->rxq_next_cycle_store) {\n /* Get the cycles that were used to process each queue and store. */\n for (unsigned i = 0; i < poll_cnt; i++) {\n@@ -5961,5 +5961,5 @@ dp_netdev_pmd_try_optimize(struct dp_netdev_pmd_thread *pmd,\n }\n /* Start new measuring interval */\n- pmd->rxq_interval = now + PMD_RXQ_INTERVAL_LEN;\n+ pmd->rxq_next_cycle_store = now + PMD_RXQ_INTERVAL_LEN;\n }\n \n","prefixes":["ovs-dev","1/3"]}