{"id":807792,"url":"http://patchwork.ozlabs.org/api/patches/807792/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-42-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-42-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:49","name":"[PULL,41/44] s390x/s390-stattrib: Mark the storage attribute as not user_creatable","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f42ff1b7744a579cfd0198ca947835da21fc4813","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-42-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807792/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807792/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCNQ1SYnz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 03:36:22 +1000 (AEST)","from localhost ([::1]:51826 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6ua-0007Tf-0r\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:36:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57871)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6HZ-0004Lw-Sa\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6HY-0006Cq-Nd\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:01 -0400","from mx1.redhat.com ([209.132.183.28]:40364)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn6HY-0006Bc-FL\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:00 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5B1A25F7BD;\n\tWed, 30 Aug 2017 16:55:59 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id DB59287FA8;\n\tWed, 30 Aug 2017 16:55:58 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5B1A25F7BD","From":"Cornelia Huck ","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:49 +0200","Message-Id":"<20170830165252.13421-42-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 16:55:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 41/44] s390x/s390-stattrib: Mark the storage\n\tattribute as not user_creatable","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, david@redhat.com, Cornelia Huck ,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\trth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Thomas Huth \n\nThe storage attribute devices are only meant to be instantiated one\ntime, internally. They can not be used by the user, so mark them with\nuser_creatable = false.\n\nSuggested-by: Claudio Imbrenda \nSigned-off-by: Thomas Huth \nMessage-Id: <1503576029-24264-1-git-send-email-thuth@redhat.com>\nReviewed-by: Claudio Imbrenda \nReviewed-by: Halil Pasic \nSigned-off-by: Cornelia Huck \n---\n hw/s390x/s390-stattrib-kvm.c | 4 ++++\n hw/s390x/s390-stattrib.c | 4 ++++\n 2 files changed, 8 insertions(+)","diff":"diff --git a/hw/s390x/s390-stattrib-kvm.c b/hw/s390x/s390-stattrib-kvm.c\nindex ed95d13c68..41770a7dec 100644\n--- a/hw/s390x/s390-stattrib-kvm.c\n+++ b/hw/s390x/s390-stattrib-kvm.c\n@@ -164,6 +164,7 @@ static int kvm_s390_stattrib_get_active(S390StAttribState *sa)\n static void kvm_s390_stattrib_class_init(ObjectClass *oc, void *data)\n {\n S390StAttribClass *sac = S390_STATTRIB_CLASS(oc);\n+ DeviceClass *dc = DEVICE_CLASS(oc);\n \n sac->get_stattr = kvm_s390_stattrib_get_stattr;\n sac->peek_stattr = kvm_s390_stattrib_peek_stattr;\n@@ -172,6 +173,9 @@ static void kvm_s390_stattrib_class_init(ObjectClass *oc, void *data)\n sac->get_dirtycount = kvm_s390_stattrib_get_dirtycount;\n sac->synchronize = kvm_s390_stattrib_synchronize;\n sac->get_active = kvm_s390_stattrib_get_active;\n+\n+ /* Reason: Can only be instantiated one time (internally) */\n+ dc->user_creatable = false;\n }\n \n static const TypeInfo kvm_s390_stattrib_info = {\ndiff --git a/hw/s390x/s390-stattrib.c b/hw/s390x/s390-stattrib.c\nindex 14a02711a2..2902f54f11 100644\n--- a/hw/s390x/s390-stattrib.c\n+++ b/hw/s390x/s390-stattrib.c\n@@ -306,6 +306,7 @@ static int qemu_s390_get_active(S390StAttribState *sa)\n static void qemu_s390_stattrib_class_init(ObjectClass *oc, void *data)\n {\n S390StAttribClass *sa_cl = S390_STATTRIB_CLASS(oc);\n+ DeviceClass *dc = DEVICE_CLASS(oc);\n \n sa_cl->synchronize = qemu_s390_synchronize_stub;\n sa_cl->get_stattr = qemu_s390_get_stattr_stub;\n@@ -314,6 +315,9 @@ static void qemu_s390_stattrib_class_init(ObjectClass *oc, void *data)\n sa_cl->set_migrationmode = qemu_s390_set_migrationmode_stub;\n sa_cl->get_dirtycount = qemu_s390_get_dirtycount_stub;\n sa_cl->get_active = qemu_s390_get_active;\n+\n+ /* Reason: Can only be instantiated one time (internally) */\n+ dc->user_creatable = false;\n }\n \n static const TypeInfo qemu_s390_stattrib_info = {\n","prefixes":["PULL","41/44"]}