{"id":807788,"url":"http://patchwork.ozlabs.org/api/patches/807788/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504114378.11498.124.camel@edumazet-glaptop3.roam.corp.google.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504114378.11498.124.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-08-30T17:32:58","name":"[net-next] xen-netfront: be more drop monitor friendly","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"f5cc8a74b6e7d617ea18a22345d9f3060d8ef54f","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/?format=json","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504114378.11498.124.camel@edumazet-glaptop3.roam.corp.google.com/mbox/","series":[{"id":667,"url":"http://patchwork.ozlabs.org/api/series/667/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=667","date":"2017-08-30T17:32:58","name":"[net-next] xen-netfront: be more drop monitor friendly","version":1,"mbox":"http://patchwork.ozlabs.org/series/667/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807788/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807788/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HsATkDYD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjCJc1Lvyz9sN7\n\tfor ;\n\tThu, 31 Aug 2017 03:33:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752412AbdH3RdC (ORCPT );\n\tWed, 30 Aug 2017 13:33:02 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:33069 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752016AbdH3RdB (ORCPT\n\t); Wed, 30 Aug 2017 13:33:01 -0400","by mail-pg0-f68.google.com with SMTP id m15so5545854pgc.0\n\tfor ; Wed, 30 Aug 2017 10:33:00 -0700 (PDT)","from ?IPv6:2620:15c:2c1:100:dc1f:953d:4193:6c45?\n\t([2620:15c:2c1:100:dc1f:953d:4193:6c45])\n\tby smtp.googlemail.com with ESMTPSA id\n\ta15sm10335144pfl.1.2017.08.30.10.32.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 10:32:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:mime-version\n\t:content-transfer-encoding;\n\tbh=ZIOFgTRl1luit0QX4N3dGRimU9cgronAZKKPzU0Udp8=;\n\tb=HsATkDYDiukqFVEMDahHw9vE2pXc+17mBZglc+mIluYjPaJVw7dsEKIl7VoJFIUOZT\n\tH64C/+Y9dM2htDN+aGF7oZ9iw7ZwJoxlAh4qdcEAwCeO1MLWtOkjEWGSjm3iPEO8SaZc\n\tgLioT0qfxgARRBygDs5jKB3Lf46p/jRQKMNu2SnH9ZdL7h6QeJ9T69GAyYzprmype7Aw\n\tvq3RqN6zXNJ2t8yvadySGz4P33e9LLyc4y4RpXNdC4tWA0UWffUUi74qiXZfGIGL2KKX\n\tJNPlOqpF01sh/LhEr4Ehi+EpY8X3oFetDV5AncoYf0+Ro7LlGzAKiKHshmlwNIUuhwEG\n\tudoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version\n\t:content-transfer-encoding;\n\tbh=ZIOFgTRl1luit0QX4N3dGRimU9cgronAZKKPzU0Udp8=;\n\tb=ct+dtp5Gi9zM6sjLpghZlZquB74acUU1bfRFFOZIaC5Z2/2SeWyk0nPzEenkp4Ujg2\n\t9Jucf8evOY59o9twYqgLBMtuIk906OZpCmYPSpAxm0LDNRUAgUGxELKkTaAod+CrJZMS\n\t5tk9J+JuOqx+zwvEp7BaiR6visEURVJI1ZQP+/6iIrZMG4NS82ys5Et/YZvrBJachb6B\n\t2jjQ2esl52xl3KHBiRUMWdJO2UEJc+Bn3ajoydrxTz6YjEggqR4k25pfP0CRELP+LCMk\n\tO34ceITF7BLfq3KgPokB+kSnPMUfxwFzsTaEgKhUoNytY5/mz//MAzl/Lu0XoESAoqEp\n\tBO0Q==","X-Gm-Message-State":"AHYfb5iMl9+GJweX+ArsYJHYdWsCubW9UJDtsa8kNTuKDKOOLGbgtKUR\n\t1n1VkFs1AraBI/sV","X-Received":"by 10.99.140.14 with SMTP id m14mr2373749pgd.106.1504114380671; \n\tWed, 30 Aug 2017 10:33:00 -0700 (PDT)","Message-ID":"<1504114378.11498.124.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"[PATCH net-next] xen-netfront: be more drop monitor friendly","From":"Eric Dumazet ","To":"David Miller ","Cc":"netdev ","Date":"Wed, 30 Aug 2017 10:32:58 -0700","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Eric Dumazet \n\nxennet_start_xmit() might copy skb with inappropriate layout\ninto a fresh one.\n\nOld skb is freed, and at this point it is not a drop, but\na consume. New skb will then be either consumed or dropped. \n\nSigned-off-by: Eric Dumazet \n---\n drivers/net/xen-netfront.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c\nindex 7b61adb6270c..523387e71a80 100644\n--- a/drivers/net/xen-netfront.c\n+++ b/drivers/net/xen-netfront.c\n@@ -611,7 +611,7 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)\n \t\tnskb = skb_copy(skb, GFP_ATOMIC);\n \t\tif (!nskb)\n \t\t\tgoto drop;\n-\t\tdev_kfree_skb_any(skb);\n+\t\tdev_consume_skb_any(skb);\n \t\tskb = nskb;\n \t\tpage = virt_to_page(skb->data);\n \t\toffset = offset_in_page(skb->data);\n","prefixes":["net-next"]}