{"id":807778,"url":"http://patchwork.ozlabs.org/api/patches/807778/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-45-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-45-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:52","name":"[PULL,44/44] s390x/pci: fixup trap_msix()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5910ecaac8b9d5ecf3bf4d263ba0ca2872d04e63","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-45-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807778/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807778/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjC7r6qNlz9sN5\n\tfor ;\n\tThu, 31 Aug 2017 03:25:28 +1000 (AEST)","from localhost ([::1]:51760 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6k2-00057v-Jv\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:25:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57946)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6Hm-0004d2-TH\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6Hm-0006P4-5z\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:56:14 -0400","from mx1.redhat.com ([209.132.183.28]:43302)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn6Hm-0006OJ-0F; Wed, 30 Aug 2017 12:56:14 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AFD63155B9;\n\tWed, 30 Aug 2017 16:56:12 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 58C1070911;\n\tWed, 30 Aug 2017 16:56:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AFD63155B9","From":"Cornelia Huck ","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:52 +0200","Message-Id":"<20170830165252.13421-45-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 30 Aug 2017 16:56:13 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 44/44] s390x/pci: fixup trap_msix()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Yi Min Zhao ,\n\tdavid@redhat.com, \n\tqemu-stable@nongnu.org, Cornelia Huck ,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\trth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Yi Min Zhao \n\nThe function trap_msix() is to check if pcistg instruction would access\nmsix table entries. The correct boundary condition should be\n[table_offset, table_offset+entries*entry_size). But the current\ncondition calculated misses the last entry. So let's fixup it.\n\nAcked-by: Dong Jia Shi \nReviewed-by: Pierre Morel \nSigned-off-by: Yi Min Zhao \nMessage-Id: <1503907487-2764-2-git-send-email-zyimin@linux.vnet.ibm.com>\nCc: qemu-stable@nongnu.org\nSigned-off-by: Cornelia Huck \n---\n hw/s390x/s390-pci-inst.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex b7beb8c36a..eba9ffb5f2 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -440,8 +440,8 @@ static int trap_msix(S390PCIBusDevice *pbdev, uint64_t offset, uint8_t pcias)\n {\n if (pbdev->msix.available && pbdev->msix.table_bar == pcias &&\n offset >= pbdev->msix.table_offset &&\n- offset <= pbdev->msix.table_offset +\n- (pbdev->msix.entries - 1) * PCI_MSIX_ENTRY_SIZE) {\n+ offset < (pbdev->msix.table_offset +\n+ pbdev->msix.entries * PCI_MSIX_ENTRY_SIZE)) {\n return 1;\n } else {\n return 0;\n","prefixes":["PULL","44/44"]}