{"id":807763,"url":"http://patchwork.ozlabs.org/api/patches/807763/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-23-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-23-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:30","name":"[PULL,22/44] s390x/s390-skeys: Mark the storage key devices with user_creatable = false","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1e50c2f947f47eb73c26c8992b45712a9804f587","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-23-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807763/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807763/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBy901q8z9s8P\n\tfor ;\n\tThu, 31 Aug 2017 03:17:04 +1000 (AEST)","from localhost ([::1]:51723 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6bu-0006Gx-HH\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:17:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57220)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6GI-0002cT-38\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:54:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6GH-0005Vq-7O\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:54:42 -0400","from mx1.redhat.com ([209.132.183.28]:59534)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn6GH-0005Vd-0w\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:54:41 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E030D356FC;\n\tWed, 30 Aug 2017 16:54:39 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6592280E72;\n\tWed, 30 Aug 2017 16:54:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E030D356FC","From":"Cornelia Huck ","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:30 +0200","Message-Id":"<20170830165252.13421-23-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 30 Aug 2017 16:54:40 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 22/44] s390x/s390-skeys: Mark the storage key\n\tdevices with user_creatable = false","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, david@redhat.com, Cornelia Huck ,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\trth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Thomas Huth \n\nQEMU currently aborts if the user tries to create a skey device:\n\n$ s390x-softmmu/qemu-system-s390x -nographic -device s390-skeys-qemu\nqemu-system-s390x: hw/s390x/s390-skeys.c:30: s390_get_skeys_device:\n Assertion `ss' failed.\nAborted (core dumped)\n\nThe storage key devices are only meant to be instantiated one time,\ninternally. They can not be used by the user, so mark them with\nuser_creatable = false.\n\nSigned-off-by: Thomas Huth \nMessage-Id: <1503569328-22197-1-git-send-email-thuth@redhat.com>\nReviewed-by: Claudio Imbrenda \nReviewed-by: Halil Pasic \nSigned-off-by: Cornelia Huck \n---\n hw/s390x/s390-skeys-kvm.c | 4 ++++\n hw/s390x/s390-skeys.c | 4 ++++\n 2 files changed, 8 insertions(+)","diff":"diff --git a/hw/s390x/s390-skeys-kvm.c b/hw/s390x/s390-skeys-kvm.c\nindex 131da56bbe..dc54ed8b11 100644\n--- a/hw/s390x/s390-skeys-kvm.c\n+++ b/hw/s390x/s390-skeys-kvm.c\n@@ -54,10 +54,14 @@ static int kvm_s390_skeys_set(S390SKeysState *ss, uint64_t start_gfn,\n static void kvm_s390_skeys_class_init(ObjectClass *oc, void *data)\n {\n S390SKeysClass *skeyclass = S390_SKEYS_CLASS(oc);\n+ DeviceClass *dc = DEVICE_CLASS(oc);\n \n skeyclass->skeys_enabled = kvm_s390_skeys_enabled;\n skeyclass->get_skeys = kvm_s390_skeys_get;\n skeyclass->set_skeys = kvm_s390_skeys_set;\n+\n+ /* Reason: Internal device (only one skeys device for the whole memory) */\n+ dc->user_creatable = false;\n }\n \n static const TypeInfo kvm_s390_skeys_info = {\ndiff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c\nindex c0de3b0c35..53ad5d38d4 100644\n--- a/hw/s390x/s390-skeys.c\n+++ b/hw/s390x/s390-skeys.c\n@@ -229,10 +229,14 @@ static int qemu_s390_skeys_get(S390SKeysState *ss, uint64_t start_gfn,\n static void qemu_s390_skeys_class_init(ObjectClass *oc, void *data)\n {\n S390SKeysClass *skeyclass = S390_SKEYS_CLASS(oc);\n+ DeviceClass *dc = DEVICE_CLASS(oc);\n \n skeyclass->skeys_enabled = qemu_s390_skeys_enabled;\n skeyclass->get_skeys = qemu_s390_skeys_get;\n skeyclass->set_skeys = qemu_s390_skeys_set;\n+\n+ /* Reason: Internal device (only one skeys device for the whole memory) */\n+ dc->user_creatable = false;\n }\n \n static const TypeInfo qemu_s390_skeys_info = {\n","prefixes":["PULL","22/44"]}