{"id":807751,"url":"http://patchwork.ozlabs.org/api/patches/807751/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830164602.GA16413@embeddedgus/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830164602.GA16413@embeddedgus>","list_archive_url":null,"date":"2017-08-30T16:46:02","name":"rtlwifi: refactor code in halbtcoutsrc module","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"bf2ce8e2dbf673b571bbb257d7d0b813b07c1e3c","submitter":{"id":72003,"url":"http://patchwork.ozlabs.org/api/people/72003/?format=json","name":"Gustavo A. R. Silva","email":"gustavo@embeddedor.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830164602.GA16413@embeddedgus/mbox/","series":[{"id":661,"url":"http://patchwork.ozlabs.org/api/series/661/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=661","date":"2017-08-30T16:46:02","name":"rtlwifi: refactor code in halbtcoutsrc module","version":1,"mbox":"http://patchwork.ozlabs.org/series/661/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807751/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807751/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjBmT3Kk2z9sNn\n\tfor ;\n\tThu, 31 Aug 2017 03:08:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751351AbdH3RIi (ORCPT );\n\tWed, 30 Aug 2017 13:08:38 -0400","from gateway23.websitewelcome.com ([192.185.48.84]:19344 \"EHLO\n\tgateway23.websitewelcome.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751857AbdH3RIh (ORCPT\n\t); Wed, 30 Aug 2017 13:08:37 -0400","from cm12.websitewelcome.com (cm12.websitewelcome.com\n\t[100.42.49.8])\n\tby gateway23.websitewelcome.com (Postfix) with ESMTP id 2D6FD16578\n\tfor ; Wed, 30 Aug 2017 11:46:08 -0500 (CDT)","from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid n673dCFmCdHTnn673dY3JG; Wed, 30 Aug 2017 11:45:09 -0500","from [189.152.158.27] (port=48948 helo=embeddedgus)\n\tby gator4166.hostgator.com with esmtpa (Exim 4.87)\n\t(envelope-from )\n\tid 1dn67z-000VxD-Qt; Wed, 30 Aug 2017 11:46:07 -0500"],"Date":"Wed, 30 Aug 2017 11:46:02 -0500","From":"\"Gustavo A. R. Silva\" ","To":"Larry Finger ,\n\tChaoming Li ,\n\tKalle Valo ","Cc":"linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" ","Subject":"[PATCH] rtlwifi: refactor code in halbtcoutsrc module","Message-ID":"<20170830164602.GA16413@embeddedgus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - gator4166.hostgator.com","Original Domain - vger.kernel.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - embeddedor.com"],"X-BWhitelist":"no","X-Source-IP":"189.152.158.27","X-Exim-ID":"1dn67z-000VxD-Qt","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Source-Sender":"(embeddedgus) [189.152.158.27]:48948","X-Source-Auth":"gustavo@embeddedor.com","X-Email-Count":"5","X-Source-Cap":"Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=","X-Local-Domain":"yes","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Function halbtc_get_wifi_rssi always returns rtlpriv->dm.undec_sm_pwdb.\nSo this function can be removed and the value of\nrtlpriv->dm.undec_sm_pwdb assigned to *s32_tmp directly.\n\nThis issue was first reported by Coverity as \"identical code for different\nbranches\" in function halbtc_get_wifi_rssi.\n\nAddresses-Coverity-ID: 1226793\nSigned-off-by: Gustavo A. R. Silva \n---\nThis code was reported by Coverity and it was tested by compilation only.\nChances are this may be a copy/paste error in function\nhalbtc_get_wifi_rssi. Please, verify.\nAlso, notice this code has been there since 2014.\n\n .../net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 13 +------------\n 1 file changed, 1 insertion(+), 12 deletions(-)","diff":"diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\nindex c1eacd8..2a47b97 100644\n--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c\n@@ -373,17 +373,6 @@ u32 halbtc_get_wifi_link_status(struct btc_coexist *btcoexist)\n \treturn ret_val;\n }\n \n-static s32 halbtc_get_wifi_rssi(struct rtl_priv *rtlpriv)\n-{\n-\tint undec_sm_pwdb = 0;\n-\n-\tif (rtlpriv->mac80211.link_state >= MAC80211_LINKED)\n-\t\tundec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;\n-\telse /* associated entry pwdb */\n-\t\tundec_sm_pwdb = rtlpriv->dm.undec_sm_pwdb;\n-\treturn undec_sm_pwdb;\n-}\n-\n static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)\n {\n \tstruct btc_coexist *btcoexist = (struct btc_coexist *)void_btcoexist;\n@@ -479,7 +468,7 @@ static bool halbtc_get(void *void_btcoexist, u8 get_type, void *out_buf)\n \t\t*bool_tmp = false;\n \t\tbreak;\n \tcase BTC_GET_S4_WIFI_RSSI:\n-\t\t*s32_tmp = halbtc_get_wifi_rssi(rtlpriv);\n+\t\t*s32_tmp = rtlpriv->dm.undec_sm_pwdb;\n \t\tbreak;\n \tcase BTC_GET_S4_HS_RSSI:\n \t\t*s32_tmp = 0;\n","prefixes":[]}