{"id":807740,"url":"http://patchwork.ozlabs.org/api/patches/807740/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-13-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-13-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:20","name":"[PULL,12/44] configure: enable --s390-pgste linker option","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e671103af5dff1765779837b78fe45e1d6d91822","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-13-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807740/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807740/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBhH5DM1z9s8P\n\tfor ;\n\tThu, 31 Aug 2017 03:05:03 +1000 (AEST)","from localhost ([::1]:51671 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6QG-0003RY-Ti\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:05:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56768)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6FU-0001tf-Jv\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6FQ-0005C6-Mf\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:52 -0400","from mx1.redhat.com ([209.132.183.28]:44310)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn6FQ-0005Br-D8\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:48 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 41BB24A6E6;\n\tWed, 30 Aug 2017 16:53:47 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 045A35D722;\n\tWed, 30 Aug 2017 16:53:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 41BB24A6E6","From":"Cornelia Huck ","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:20 +0200","Message-Id":"<20170830165252.13421-13-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 30 Aug 2017 16:53:47 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 12/44] configure: enable --s390-pgste linker\n\toption","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, david@redhat.com, Cornelia Huck ,\n\tagraf@suse.de, Christian Ehrhardt , \n\tqemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tDan Horak , rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Christian Borntraeger \n\nKVM guests on s390 need a different page table layout than normal\nprocesses (2kb page table + 2kb page status extensions vs 2kb page table\nonly). As of today this has to be enabled via the vm.allocate_pgste\nsysctl.\n\nNewer kernels (>= 4.12) on s390 check for an S390_PGSTE program header\nand enable the pgste page table extensions in that case. This makes the\nvm.allocate_pgste sysctl unnecessary. We enable this program header for\nthe s390 system emulation (qemu-system-s390x) if we build on s390\n- for s390 system emulation\n- the linker supports --s390-pgste (binutils >= 2.29)\n- KVM is enabled\n\nThis will allow distributions to disable the global vm.allocate_pgste\nsysctl, which will improve the page table allocation for non KVM\nprocesses as only 2kb chunks are necessary.\n\nCc: Christian Ehrhardt \nCc: Alexander Graf \nCc: Dan Horak \nCc: David Hildenbrand \nSigned-off-by: Christian Borntraeger \nAcked-by: Janosch Frank \nReviewed-by: Thomas Huth \nMessage-Id: <1503483383-199649-1-git-send-email-borntraeger@de.ibm.com>\nReviewed-by: David Hildenbrand \nSigned-off-by: Cornelia Huck \n---\n configure | 21 ++++++++++++++++++++-\n 1 file changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/configure b/configure\nindex dd73cce62f..fb7e34a901 100755\n--- a/configure\n+++ b/configure\n@@ -240,6 +240,11 @@ supported_target() {\n return 1\n }\n \n+\n+ld_has() {\n+ $ld --help 2>/dev/null | grep \".$1\" >/dev/null 2>&1\n+}\n+\n # default parameters\n source_path=$(dirname \"$0\")\n cpu=\"\"\n@@ -5043,7 +5048,7 @@ fi\n # Use ASLR, no-SEH and DEP if available\n if test \"$mingw32\" = \"yes\" ; then\n for flag in --dynamicbase --no-seh --nxcompat; do\n- if $ld --help 2>/dev/null | grep \".$flag\" >/dev/null 2>/dev/null ; then\n+ if ld_has $flag ; then\n LDFLAGS=\"-Wl,$flag $LDFLAGS\"\n fi\n done\n@@ -6522,6 +6527,20 @@ if test \"$target_linux_user\" = \"yes\" -o \"$target_bsd_user\" = \"yes\" ; then\n ldflags=\"$ldflags $textseg_ldflags\"\n fi\n \n+# Newer kernels on s390 check for an S390_PGSTE program header and\n+# enable the pgste page table extensions in that case. This makes\n+# the vm.allocate_pgste sysctl unnecessary. We enable this program\n+# header if\n+# - we build on s390x\n+# - we build the system emulation for s390x (qemu-system-s390x)\n+# - KVM is enabled\n+# - the linker supports --s390-pgste\n+if test \"$TARGET_ARCH\" = \"s390x\" -a \"$target_softmmu\" = \"yes\" -a \"$ARCH\" = \"s390x\" -a \"$kvm\" = \"yes\"; then\n+ if ld_has --s390-pgste ; then\n+ ldflags=\"-Wl,--s390-pgste $ldflags\"\n+ fi\n+fi\n+\n echo \"LDFLAGS+=$ldflags\" >> $config_target_mak\n echo \"QEMU_CFLAGS+=$cflags\" >> $config_target_mak\n \n","prefixes":["PULL","12/44"]}