{"id":807737,"url":"http://patchwork.ozlabs.org/api/patches/807737/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830170424.GA19424@embeddedgus/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830170424.GA19424@embeddedgus>","list_archive_url":null,"date":"2017-08-30T17:04:24","name":"rtlwifi: rtl8723be: fix duplicated code for different branches","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"5d5a5dc2b957d91394d5884233be3d4af5f40337","submitter":{"id":72003,"url":"http://patchwork.ozlabs.org/api/people/72003/?format=json","name":"Gustavo A. R. Silva","email":"gustavo@embeddedor.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830170424.GA19424@embeddedgus/mbox/","series":[{"id":658,"url":"http://patchwork.ozlabs.org/api/series/658/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=658","date":"2017-08-30T17:04:24","name":"rtlwifi: rtl8723be: fix duplicated code for different branches","version":1,"mbox":"http://patchwork.ozlabs.org/series/658/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807737/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807737/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjBgk4sKsz9s8P\n\tfor ;\n\tThu, 31 Aug 2017 03:04:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752092AbdH3RE1 (ORCPT );\n\tWed, 30 Aug 2017 13:04:27 -0400","from gateway22.websitewelcome.com ([192.185.46.187]:29891 \"EHLO\n\tgateway22.websitewelcome.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751415AbdH3RE0 (ORCPT\n\t); Wed, 30 Aug 2017 13:04:26 -0400","from cm14.websitewelcome.com (cm14.websitewelcome.com\n\t[100.42.49.7])\n\tby gateway22.websitewelcome.com (Postfix) with ESMTP id 994411A4B3\n\tfor ; Wed, 30 Aug 2017 12:04:25 -0500 (CDT)","from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid n6P4dP0RkyM9yn6P4d9gV6; Wed, 30 Aug 2017 12:03:46 -0500","from [189.152.158.27] (port=49124 helo=embeddedgus)\n\tby gator4166.hostgator.com with esmtpa (Exim 4.87)\n\t(envelope-from )\n\tid 1dn6Ph-000jWN-8k; Wed, 30 Aug 2017 12:04:25 -0500"],"Date":"Wed, 30 Aug 2017 12:04:24 -0500","From":"\"Gustavo A. R. Silva\" ","To":"Larry Finger ,\n\tChaoming Li ,\n\tKalle Valo ","Cc":"linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" ","Subject":"[PATCH] rtlwifi: rtl8723be: fix duplicated code for different\n\tbranches","Message-ID":"<20170830170424.GA19424@embeddedgus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - gator4166.hostgator.com","Original Domain - vger.kernel.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - embeddedor.com"],"X-BWhitelist":"no","X-Source-IP":"189.152.158.27","X-Exim-ID":"1dn6Ph-000jWN-8k","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Source-Sender":"(embeddedgus) [189.152.158.27]:49124","X-Source-Auth":"gustavo@embeddedor.com","X-Email-Count":"5","X-Source-Cap":"Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=","X-Local-Domain":"yes","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Refactor code in order to avoid identical code for different branches.\n\nAddresses-Coverity-ID: 1248728\nSigned-off-by: Gustavo A. R. Silva \n---\nThis issue was reported by Coverity and it was tested by compilation only.\nPlease, verify if this is not a copy/paste error.\nAlso, notice this code has been there since 2014.\n\n drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c\nindex 131c0d1..15c117e 100644\n--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c\n+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/dm.c\n@@ -883,12 +883,8 @@ static void rtl8723be_dm_txpower_tracking_callback_thermalmeter(\n \tif ((rtldm->power_index_offset[RF90_PATH_A] != 0) &&\n \t (rtldm->txpower_track_control)) {\n \t\trtldm->done_txpower = true;\n-\t\tif (thermalvalue > rtlefuse->eeprom_thermalmeter)\n-\t\t\trtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,\n-\t\t\t\t\t\t\t index_for_channel);\n-\t\telse\n-\t\t\trtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,\n-\t\t\t\t\t\t\t index_for_channel);\n+\t\trtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,\n+\t\t\t\t\t\t index_for_channel);\n \n \t\trtldm->swing_idx_cck_base = rtldm->swing_idx_cck;\n \t\trtldm->swing_idx_ofdm_base[RF90_PATH_A] =\n","prefixes":[]}