{"id":807734,"url":"http://patchwork.ozlabs.org/api/patches/807734/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-8-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-8-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:15","name":"[PULL,07/44] tests: Run filter-redirector and -mirror test only on POSIX systems","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"56ec343bd870ac2b0290484c129cc9ecbb717ee2","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-8-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807734/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807734/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBd00xr1z9s7C\n\tfor ;\n\tThu, 31 Aug 2017 03:02:12 +1000 (AEST)","from localhost ([::1]:51662 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6NV-0001C5-Qi\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:02:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56538)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6F9-0001ZN-3q\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6F6-00053U-KS\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:31 -0400","from mx1.redhat.com ([209.132.183.28]:60564)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn6F6-00052w-BA\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:28 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4AECE7EA8C;\n\tWed, 30 Aug 2017 16:53:27 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id B117517AE3;\n\tWed, 30 Aug 2017 16:53:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4AECE7EA8C","From":"Cornelia Huck ","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:15 +0200","Message-Id":"<20170830165252.13421-8-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 30 Aug 2017 16:53:27 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 07/44] tests: Run filter-redirector and -mirror\n\ttest only on POSIX systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, david@redhat.com, Cornelia Huck ,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\trth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Thomas Huth \n\nThis way we can get rid of the ugly #ifdefs in the code which makes\nit easier to extend later.\n\nSigned-off-by: Thomas Huth \nReviewed-by: Cornelia Huck \nMessage-Id: <1502951113-4246-2-git-send-email-thuth@redhat.com>\nReviewed-by: David Hildenbrand \nReviewed-by: Zhang Chen \nSigned-off-by: Cornelia Huck \n---\n tests/Makefile.include | 8 ++++----\n tests/test-filter-mirror.c | 5 -----\n tests/test-filter-redirector.c | 10 ----------\n 3 files changed, 4 insertions(+), 19 deletions(-)","diff":"diff --git a/tests/Makefile.include b/tests/Makefile.include\nindex ea0f15f70b..871791d2fc 100644\n--- a/tests/Makefile.include\n+++ b/tests/Makefile.include\n@@ -283,8 +283,8 @@ ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)\n check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) += tests/vhost-user-test$(EXESUF)\n endif\n check-qtest-i386-$(CONFIG_SLIRP) += tests/test-netfilter$(EXESUF)\n-check-qtest-i386-y += tests/test-filter-mirror$(EXESUF)\n-check-qtest-i386-y += tests/test-filter-redirector$(EXESUF)\n+check-qtest-i386-$(CONFIG_POSIX) += tests/test-filter-mirror$(EXESUF)\n+check-qtest-i386-$(CONFIG_POSIX) += tests/test-filter-redirector$(EXESUF)\n check-qtest-i386-y += tests/postcopy-test$(EXESUF)\n check-qtest-i386-y += tests/test-x86-cpuid-compat$(EXESUF)\n check-qtest-i386-y += tests/numa-test$(EXESUF)\n@@ -325,8 +325,8 @@ check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF)\n gcov-files-ppc64-y += hw/usb/hcd-xhci.c\n check-qtest-ppc64-y += $(check-qtest-virtio-y)\n check-qtest-ppc64-$(CONFIG_SLIRP) += tests/test-netfilter$(EXESUF)\n-check-qtest-ppc64-y += tests/test-filter-mirror$(EXESUF)\n-check-qtest-ppc64-y += tests/test-filter-redirector$(EXESUF)\n+check-qtest-ppc64-$(CONFIG_POSIX) += tests/test-filter-mirror$(EXESUF)\n+check-qtest-ppc64-$(CONFIG_POSIX) += tests/test-filter-redirector$(EXESUF)\n check-qtest-ppc64-y += tests/display-vga-test$(EXESUF)\n check-qtest-ppc64-y += tests/numa-test$(EXESUF)\n check-qtest-ppc64-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF)\ndiff --git a/tests/test-filter-mirror.c b/tests/test-filter-mirror.c\nindex 9f84402493..a1d5865ef7 100644\n--- a/tests/test-filter-mirror.c\n+++ b/tests/test-filter-mirror.c\n@@ -17,9 +17,6 @@\n \n static void test_mirror(void)\n {\n-#ifndef _WIN32\n-/* socketpair(PF_UNIX) which does not exist on windows */\n-\n int send_sock[2], recv_sock;\n char *cmdline;\n uint32_t ret = 0, len = 0;\n@@ -74,8 +71,6 @@ static void test_mirror(void)\n g_free(recv_buf);\n close(recv_sock);\n unlink(sock_path);\n-\n-#endif\n }\n \n int main(int argc, char **argv)\ndiff --git a/tests/test-filter-redirector.c b/tests/test-filter-redirector.c\nindex 0c4b8d52ef..69c663b183 100644\n--- a/tests/test-filter-redirector.c\n+++ b/tests/test-filter-redirector.c\n@@ -59,9 +59,6 @@\n \n static void test_redirector_tx(void)\n {\n-#ifndef _WIN32\n-/* socketpair(PF_UNIX) which does not exist on windows */\n-\n int backend_sock[2], recv_sock;\n char *cmdline;\n uint32_t ret = 0, len = 0;\n@@ -129,15 +126,10 @@ static void test_redirector_tx(void)\n unlink(sock_path0);\n unlink(sock_path1);\n qtest_end();\n-\n-#endif\n }\n \n static void test_redirector_rx(void)\n {\n-#ifndef _WIN32\n-/* socketpair(PF_UNIX) which does not exist on windows */\n-\n int backend_sock[2], send_sock;\n char *cmdline;\n uint32_t ret = 0, len = 0;\n@@ -203,8 +195,6 @@ static void test_redirector_rx(void)\n unlink(sock_path0);\n unlink(sock_path1);\n qtest_end();\n-\n-#endif\n }\n \n int main(int argc, char **argv)\n","prefixes":["PULL","07/44"]}