{"id":807732,"url":"http://patchwork.ozlabs.org/api/patches/807732/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-11-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-11-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:18","name":"[PULL,10/44] watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"00a4f43c0c2d870a220d4a3098defd6de6818b2a","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-11-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807732/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807732/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBZr11wKz9sNn\n\tfor ;\n\tThu, 31 Aug 2017 03:00:20 +1000 (AEST)","from localhost ([::1]:51647 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn6Lh-0007Yi-R6\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:00:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56672)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn6FJ-0001ju-Pq\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn6FI-00059O-FC\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:41 -0400","from mx1.redhat.com ([209.132.183.28]:52282)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dn6FI-000590-7R\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:40 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1349EC0587E6;\n\tWed, 30 Aug 2017 16:53:39 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 94C215DD64;\n\tWed, 30 Aug 2017 16:53:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1349EC0587E6","From":"Cornelia Huck ","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:18 +0200","Message-Id":"<20170830165252.13421-11-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 30 Aug 2017 16:53:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 10/44] watchdog/wdt_diag288: Mark diag288\n\twatchdog as non-hotpluggable","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, david@redhat.com, Cornelia Huck ,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\trth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Thomas Huth \n\nQEMU currently aborts when the user tries to hot-unplug a diag288\ndevice:\n\n$ qemu-system-s390x -nographic -nodefaults -S -monitor stdio\nQEMU 2.9.92 monitor - type 'help' for more information\n(qemu) device_add diag288,id=x\n(qemu) device_del x\n**\nERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)\nAborted (core dumped)\n\nThe device is not designed as hot-pluggable (it should only be used\nvia the \"-watchdog\" parameter), so let's simply remove the possibility\nto hotplug it to prevent that users can run into this ugly situation.\n\nSigned-off-by: Thomas Huth \nMessage-Id: <1502892528-22618-1-git-send-email-thuth@redhat.com>\nReviewed-by: David Hildenbrand \nSigned-off-by: Cornelia Huck \n---\n hw/watchdog/wdt_diag288.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c\nindex a7b64e2c40..47f289216a 100644\n--- a/hw/watchdog/wdt_diag288.c\n+++ b/hw/watchdog/wdt_diag288.c\n@@ -121,6 +121,7 @@ static void wdt_diag288_class_init(ObjectClass *klass, void *data)\n dc->realize = wdt_diag288_realize;\n dc->unrealize = wdt_diag288_unrealize;\n dc->reset = wdt_diag288_reset;\n+ dc->hotpluggable = false;\n set_bit(DEVICE_CATEGORY_MISC, dc->categories);\n dc->vmsd = &vmstate_diag288;\n diag288->handle_timer = wdt_diag288_handle_timer;\n","prefixes":["PULL","10/44"]}