{"id":807723,"url":"http://patchwork.ozlabs.org/api/patches/807723/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-2-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830165252.13421-2-cohuck@redhat.com>","list_archive_url":null,"date":"2017-08-30T16:52:09","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"69be996167ca600128fc8f5474831dfc655fe060","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-2-cohuck@redhat.com/mbox/","series":[{"id":656,"url":"http://patchwork.ozlabs.org/api/series/656/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656","date":"2017-08-30T16:52:08","name":"[PULL,01/44] s390x/css: use macro for event-information pending error recover code","version":1,"mbox":"http://patchwork.ozlabs.org/series/656/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807723/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807723/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBSh1RdCz9sPt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 02:55:00 +1000 (AEST)","from localhost ([::1]:51616 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn6GX-0002F9-SW\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 12:54:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56269)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dn6Ej-0001E0-AV\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dn6Ei-0004up-GO\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:05 -0400","from mx1.redhat.com ([209.132.183.28]:64580)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dn6Ei-0004uQ-AB\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:04 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3854080C05;\n\tWed, 30 Aug 2017 16:53:03 +0000 (UTC)","from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 7476F9815D;\n\tWed, 30 Aug 2017 16:53:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3854080C05","From":"Cornelia Huck <cohuck@redhat.com>","To":"peter.maydell@linaro.org","Date":"Wed, 30 Aug 2017 18:52:09 +0200","Message-Id":"<20170830165252.13421-2-cohuck@redhat.com>","In-Reply-To":"<20170830165252.13421-1-cohuck@redhat.com>","References":"<20170830165252.13421-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 30 Aug 2017 16:53:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 01/44] s390x/css: use macro for\n\tevent-information pending error recover code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"thuth@redhat.com, david@redhat.com, Cornelia Huck <cohuck@redhat.com>,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tDong Jia Shi <bjsdjshi@linux.vnet.ibm.com>, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\n\nLet's use a macro for the ERC (error recover code) when generating a\nChannel Subsystem Event-information pending CRW (channel report word).\n\nWhile we are at it, let's also add all other ERCs.\n\nSigned-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\nReviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>\nMessage-Id: <20170803003527.86979-2-bjsdjshi@linux.vnet.ibm.com>\nSigned-off-by: Cornelia Huck <cohuck@redhat.com>\n---\n hw/s390x/css.c            |  2 +-\n include/hw/s390x/ioinst.h | 12 ++++++++++--\n 2 files changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/s390x/css.c b/hw/s390x/css.c\nindex 1880b1a0ff..0be4eb093d 100644\n--- a/hw/s390x/css.c\n+++ b/hw/s390x/css.c\n@@ -2108,7 +2108,7 @@ void css_generate_chp_crws(uint8_t cssid, uint8_t chpid)\n void css_generate_css_crws(uint8_t cssid)\n {\n     if (!channel_subsys.sei_pending) {\n-        css_queue_crw(CRW_RSC_CSS, 0, 0, cssid);\n+        css_queue_crw(CRW_RSC_CSS, CRW_ERC_EVENT, 0, cssid);\n     }\n     channel_subsys.sei_pending = true;\n }\ndiff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h\nindex 92d15655e4..5f2db6949d 100644\n--- a/include/hw/s390x/ioinst.h\n+++ b/include/hw/s390x/ioinst.h\n@@ -201,8 +201,16 @@ typedef struct CRW {\n #define CRW_FLAGS_MASK_A 0x0080\n #define CRW_FLAGS_MASK_ERC 0x003f\n \n-#define CRW_ERC_INIT 0x02\n-#define CRW_ERC_IPI  0x04\n+#define CRW_ERC_EVENT    0x00 /* event information pending */\n+#define CRW_ERC_AVAIL    0x01 /* available */\n+#define CRW_ERC_INIT     0x02 /* initialized */\n+#define CRW_ERC_TERROR   0x03 /* temporary error */\n+#define CRW_ERC_IPI      0x04 /* installed parm initialized */\n+#define CRW_ERC_TERM     0x05 /* terminal */\n+#define CRW_ERC_PERRN    0x06 /* perm. error, facility not init */\n+#define CRW_ERC_PERRI    0x07 /* perm. error, facility init */\n+#define CRW_ERC_PMOD     0x08 /* installed parameters modified */\n+#define CRW_ERC_IPR      0x0A /* installed parameters restored */\n \n #define CRW_RSC_SUBCH 0x3\n #define CRW_RSC_CHP   0x4\n","prefixes":["PULL","01/44"]}