{"id":807696,"url":"http://patchwork.ozlabs.org/api/patches/807696/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/1504109704-17033-1-git-send-email-keith.busch@intel.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504109704-17033-1-git-send-email-keith.busch@intel.com>","list_archive_url":null,"date":"2017-08-30T16:15:04","name":"vmd: Remove IRQ affinity","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"57df6126e77ba39bf9b25935898ad501eeda9d04","submitter":{"id":19950,"url":"http://patchwork.ozlabs.org/api/people/19950/?format=json","name":"Keith Busch","email":"keith.busch@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/1504109704-17033-1-git-send-email-keith.busch@intel.com/mbox/","series":[{"id":644,"url":"http://patchwork.ozlabs.org/api/series/644/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=644","date":"2017-08-30T16:15:04","name":"vmd: Remove IRQ affinity","version":1,"mbox":"http://patchwork.ozlabs.org/series/644/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807696/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807696/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj9SV5SqYz9sP5\n\tfor ;\n\tThu, 31 Aug 2017 02:09:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751443AbdH3QJp (ORCPT );\n\tWed, 30 Aug 2017 12:09:45 -0400","from mga02.intel.com ([134.134.136.20]:26011 \"EHLO mga02.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751409AbdH3QJp (ORCPT );\n\tWed, 30 Aug 2017 12:09:45 -0400","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Aug 2017 09:09:28 -0700","from unknown (HELO localhost.lm.intel.com) ([10.232.112.96])\n\tby orsmga002.jf.intel.com with ESMTP; 30 Aug 2017 09:09:27 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,449,1498546800\"; d=\"scan'208\";a=\"129983596\"","From":"Keith Busch ","To":"linux-pci@vger.kernel.org, Bjorn Helgaas ","Cc":"Jon Derrick ,\n\tKeith Busch ","Subject":"[PATCH] vmd: Remove IRQ affinity","Date":"Wed, 30 Aug 2017 12:15:04 -0400","Message-Id":"<1504109704-17033-1-git-send-email-keith.busch@intel.com>","X-Mailer":"git-send-email 2.5.5","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"},"content":"VMD hardware has to share its vectors among child devices in its PCI\ndomain so we should allocate as many as possible rather than just ones\nthat can be affinitized.\n\nReported-by: Brad Goodman \nSigned-off-by: Keith Busch \n---\n drivers/pci/host/vmd.c | 12 ++----------\n 1 file changed, 2 insertions(+), 10 deletions(-)","diff":"diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c\nindex 4fe1756..509893b 100644\n--- a/drivers/pci/host/vmd.c\n+++ b/drivers/pci/host/vmd.c\n@@ -671,14 +671,6 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)\n \tstruct vmd_dev *vmd;\n \tint i, err;\n \n-\t/*\n-\t * The first vector is reserved for special use, so start affinity at\n-\t * the second vector\n-\t */\n-\tstruct irq_affinity affd = {\n-\t\t.pre_vectors = 1,\n-\t};\n-\n \tif (resource_size(&dev->resource[VMD_CFGBAR]) < (1 << 20))\n \t\treturn -ENOMEM;\n \n@@ -704,8 +696,8 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)\n \tif (vmd->msix_count < 0)\n \t\treturn -ENODEV;\n \n-\tvmd->msix_count = pci_alloc_irq_vectors_affinity(dev, 1, vmd->msix_count,\n-\t\t\t\t\tPCI_IRQ_MSIX | PCI_IRQ_AFFINITY, &affd);\n+\tvmd->msix_count = pci_alloc_irq_vectors(dev, 1, vmd->msix_count,\n+\t\t\t\t\tPCI_IRQ_MSIX);\n \tif (vmd->msix_count < 0)\n \t\treturn vmd->msix_count;\n \n","prefixes":[]}