{"id":807653,"url":"http://patchwork.ozlabs.org/api/patches/807653/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20170830141313.11283-1-agruenba@redhat.com/","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830141313.11283-1-agruenba@redhat.com>","list_archive_url":null,"date":"2017-08-30T14:13:13","name":"vfs: Return -ENXIO for negative SEEK_HOLE / SEEK_DATA offsets","commit_ref":null,"pull_url":null,"state":"new","archived":true,"hash":"e04df6ecbe36480e26f7e28122990411fff83b41","submitter":{"id":67290,"url":"http://patchwork.ozlabs.org/api/people/67290/?format=json","name":"Andreas Gruenbacher","email":"agruenba@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20170830141313.11283-1-agruenba@redhat.com/mbox/","series":[{"id":622,"url":"http://patchwork.ozlabs.org/api/series/622/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-ext4/list/?series=622","date":"2017-08-30T14:13:13","name":"vfs: Return -ENXIO for negative SEEK_HOLE / SEEK_DATA offsets","version":1,"mbox":"http://patchwork.ozlabs.org/series/622/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807653/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807653/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=agruenba@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj6t905tGz9sPt\n\tfor ;\n\tThu, 31 Aug 2017 00:13:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751951AbdH3ONT (ORCPT );\n\tWed, 30 Aug 2017 10:13:19 -0400","from mx1.redhat.com ([209.132.183.28]:55862 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751759AbdH3ONR (ORCPT );\n\tWed, 30 Aug 2017 10:13:17 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0CBA713A5C;\n\tWed, 30 Aug 2017 14:13:17 +0000 (UTC)","from max.home.com (ovpn-116-105.ams2.redhat.com [10.36.116.105])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 51A8760BEB;\n\tWed, 30 Aug 2017 14:13:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0CBA713A5C","From":"Andreas Gruenbacher ","To":"Alexander Viro ","Cc":"Andreas Gruenbacher ,\n\tlinux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n\t\"Theodore Ts'o\" , Jan Kara ,\n\tstable@vger.kernel.org","Subject":"[PATCH] vfs: Return -ENXIO for negative SEEK_HOLE / SEEK_DATA\n\toffsets","Date":"Wed, 30 Aug 2017 16:13:13 +0200","Message-Id":"<20170830141313.11283-1-agruenba@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 30 Aug 2017 14:13:17 +0000 (UTC)","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"},"content":"In generic_file_llseek_size, return -ENXIO for negative offsets as well.\n\nFixes xfstest generic/448.\n\nSigned-off-by: Andreas Gruenbacher \nCc: stable@vger.kernel.org\n---\n fs/read_write.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/read_write.c b/fs/read_write.c\nindex 0cc7033aa413..52872c1e57dd 100644\n--- a/fs/read_write.c\n+++ b/fs/read_write.c\n@@ -112,7 +112,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,\n \t\t * In the generic case the entire file is data, so as long as\n \t\t * offset isn't at the end of the file then the offset is data.\n \t\t */\n-\t\tif (offset >= eof)\n+\t\tif ((unsigned long long)offset >= eof)\n \t\t\treturn -ENXIO;\n \t\tbreak;\n \tcase SEEK_HOLE:\n@@ -120,7 +120,7 @@ generic_file_llseek_size(struct file *file, loff_t offset, int whence,\n \t\t * There is a virtual hole at the end of the file, so as long as\n \t\t * offset isn't i_size or larger, return i_size.\n \t\t */\n-\t\tif (offset >= eof)\n+\t\tif ((unsigned long long)offset >= eof)\n \t\t\treturn -ENXIO;\n \t\toffset = eof;\n \t\tbreak;\n","prefixes":[]}