{"id":807652,"url":"http://patchwork.ozlabs.org/api/patches/807652/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830134223.GA13596@embeddedgus/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830134223.GA13596@embeddedgus>","list_archive_url":null,"date":"2017-08-30T13:42:23","name":"rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"8aa0add4c92b34e7e42972dce612ccaeffb1c8f6","submitter":{"id":72003,"url":"http://patchwork.ozlabs.org/api/people/72003/?format=json","name":"Gustavo A. R. Silva","email":"gustavo@embeddedor.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830134223.GA13596@embeddedgus/mbox/","series":[{"id":621,"url":"http://patchwork.ozlabs.org/api/series/621/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=621","date":"2017-08-30T13:42:23","name":"rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches","version":1,"mbox":"http://patchwork.ozlabs.org/series/621/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807652/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807652/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj6hR0gchz9s8J\n\tfor ;\n\tThu, 31 Aug 2017 00:04:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751600AbdH3OEw (ORCPT );\n\tWed, 30 Aug 2017 10:04:52 -0400","from gateway22.websitewelcome.com ([192.185.46.142]:23690 \"EHLO\n\tgateway22.websitewelcome.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751326AbdH3OEv (ORCPT\n\t); Wed, 30 Aug 2017 10:04:51 -0400","from cm14.websitewelcome.com (cm14.websitewelcome.com\n\t[100.42.49.7])\n\tby gateway22.websitewelcome.com (Postfix) with ESMTP id CB17F1B5ED\n\tfor ; Wed, 30 Aug 2017 08:42:25 -0500 (CDT)","from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP\n\tid n3FadKrgbyM9yn3Fad5ZMY; Wed, 30 Aug 2017 08:41:46 -0500","from [189.152.158.27] (port=48078 helo=embeddedgus)\n\tby gator4166.hostgator.com with esmtpa (Exim 4.87)\n\t(envelope-from )\n\tid 1dn3GD-002Sil-AY; Wed, 30 Aug 2017 08:42:25 -0500"],"X-Greylist":"delayed 1345 seconds by postgrey-1.27 at vger.kernel.org;\n\tWed, 30 Aug 2017 10:04:51 EDT","Date":"Wed, 30 Aug 2017 08:42:23 -0500","From":"\"Gustavo A. R. Silva\" ","To":"Larry Finger ,\n\tChaoming Li ,\n\tKalle Valo ","Cc":"linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\t\"Gustavo A. R. Silva\" ","Subject":"[PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different\n\tbranches","Message-ID":"<20170830134223.GA13596@embeddedgus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - gator4166.hostgator.com","Original Domain - vger.kernel.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - embeddedor.com"],"X-BWhitelist":"no","X-Source-IP":"189.152.158.27","X-Exim-ID":"1dn3GD-002Sil-AY","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-Source-Sender":"(embeddedgus) [189.152.158.27]:48078","X-Source-Auth":"gustavo@embeddedor.com","X-Email-Count":"9","X-Source-Cap":"Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=","X-Local-Domain":"yes","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Refactor code in order to avoid identical code for different branches.\n\nThis issue was detected with the help of Coccinelle.\n\nAddresses-Coverity-ID: 1226788\nSigned-off-by: Gustavo A. R. Silva \n---\nThis issue was reported by Coverity and it was tested by compilation only.\nI'm suspicious this may be a copy/paste error. Please, verify.\n\n .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c\nindex c044252..960ce80f 100644\n--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c\n+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c\n@@ -2260,14 +2260,8 @@ static void halbtc8723b1ant_run_coexist_mechanism(struct btc_coexist *btcoexist)\n \n \t\tif (iot_peer != BTC_IOT_PEER_CISCO &&\n \t\t iot_peer != BTC_IOT_PEER_BROADCOM) {\n-\t\t\tif (bt_link_info->sco_exist)\n-\t\t\t\thalbtc8723b1ant_limited_rx(btcoexist,\n-\t\t\t\t\t\t\t NORMAL_EXEC, false,\n-\t\t\t\t\t\t\t false, 0x5);\n-\t\t\telse\n-\t\t\t\thalbtc8723b1ant_limited_rx(btcoexist,\n-\t\t\t\t\t\t\t NORMAL_EXEC, false,\n-\t\t\t\t\t\t\t false, 0x5);\n+\t\t\thalbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC,\n+\t\t\t\t\t\t false, false, 0x5);\n \t\t} else {\n \t\t\tif (bt_link_info->sco_exist) {\n \t\t\t\thalbtc8723b1ant_limited_rx(btcoexist,\n","prefixes":[]}