{"id":807642,"url":"http://patchwork.ozlabs.org/api/patches/807642/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504100343-26607-1-git-send-email-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","list_archive_url":null,"date":"2017-08-30T13:39:03","name":"[for-2.11] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d9b93cdf9bc0af6ac8c64c22c6d34079db54510a","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1504100343-26607-1-git-send-email-thuth@redhat.com/mbox/","series":[{"id":614,"url":"http://patchwork.ozlabs.org/api/series/614/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=614","date":"2017-08-30T13:39:03","name":"[for-2.11] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems","version":1,"mbox":"http://patchwork.ozlabs.org/series/614/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807642/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807642/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj6DW5LpWz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 23:44:11 +1000 (AEST)","from localhost ([::1]:50689 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dn3Ht-00084C-HI\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 09:44:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56469)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dn3DA-0004I7-JN\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:39:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dn3D7-0004UT-Be\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:39:16 -0400","from mx1.redhat.com ([209.132.183.28]:60106)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dn3D7-0004Sk-54; Wed, 30 Aug 2017 09:39:13 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 67F518763A;\n\tWed, 30 Aug 2017 13:39:09 +0000 (UTC)","from thh440s.redhat.com (ovpn-116-68.ams2.redhat.com\n\t[10.36.116.68])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D92848D543;\n\tWed, 30 Aug 2017 13:39:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 67F518763A","From":"Thomas Huth ","To":"qemu-devel@nongnu.org","Date":"Wed, 30 Aug 2017 15:39:03 +0200","Message-Id":"<1504100343-26607-1-git-send-email-thuth@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 30 Aug 2017 13:39:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix\n\tivshmem_recv_msg() to also work on big endian systems","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-trivial@nongnu.org, Laurent Vivier ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The \"slow\" ivshmem-tests currently fail when they are running on a\nbig endian host:\n\n$ uname -m\nppc64\n$ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/ivshmem-test -m slow\n/x86_64/ivshmem/single: OK\n/x86_64/ivshmem/hotplug: OK\n/x86_64/ivshmem/memdev: OK\n/x86_64/ivshmem/pair: OK\n/x86_64/ivshmem/server-msi: qemu-system-x86_64:\n -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid ID message\nBroken pipe\n\nThe problem is that the server side code in ivshmem_server_send_one_msg()\ncorrectly translates all messages IDs into little endian 64-bit values,\nbut the client side code in the ivshmem_recv_msg() function does not swap\nthe byte order back. Fix it by passing the value through le64_to_cpu().\n\nSigned-off-by: Thomas Huth \n---\n hw/misc/ivshmem.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c\nindex 47a015f..b3ef3ec 100644\n--- a/hw/misc/ivshmem.c\n+++ b/hw/misc/ivshmem.c\n@@ -653,7 +653,7 @@ static int64_t ivshmem_recv_msg(IVShmemState *s, int *pfd, Error **errp)\n } while (n < sizeof(msg));\n \n *pfd = qemu_chr_fe_get_msgfd(&s->server_chr);\n- return msg;\n+ return le64_to_cpu(msg);\n }\n \n static void ivshmem_recv_setup(IVShmemState *s, Error **errp)\n","prefixes":["for-2.11"]}