{"id":807631,"url":"http://patchwork.ozlabs.org/api/patches/807631/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/1504099510-25445-1-git-send-email-dedeckeh@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504099510-25445-1-git-send-email-dedeckeh@gmail.com>","list_archive_url":null,"date":"2017-08-30T13:25:10","name":"[LEDE-DEV,ubox,3/3] kmodloader: fix possible segfaults","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b644207497bc6a7741a0982eefa8f34fdb62b804","submitter":{"id":65331,"url":"http://patchwork.ozlabs.org/api/people/65331/?format=json","name":"Hans Dedecker","email":"dedeckeh@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/1504099510-25445-1-git-send-email-dedeckeh@gmail.com/mbox/","series":[{"id":611,"url":"http://patchwork.ozlabs.org/api/series/611/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/list/?series=611","date":"2017-08-30T13:23:58","name":"[LEDE-DEV,ubox,1/3] kmodloader: fix endianess check","version":1,"mbox":"http://patchwork.ozlabs.org/series/611/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807631/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807631/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"f0P8ERF9\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Mc5aWS/b\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj5qM0dpfz9sN7\n\tfor ;\n\tWed, 30 Aug 2017 23:25:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn304-0005Ud-2H; Wed, 30 Aug 2017 13:25:44 +0000","from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dn2zx-0004ek-3h\n\tfor lede-dev@lists.infradead.org; Wed, 30 Aug 2017 13:25:41 +0000","by mail-io0-x242.google.com with SMTP id k22so708746iod.1\n\tfor ;\n\tWed, 30 Aug 2017 06:25:16 -0700 (PDT)","from cplx43.eu.thmulti.com ([141.11.62.7])\n\tby smtp.gmail.com with ESMTPSA id\n\tj92sm2587508ioi.38.2017.08.30.06.25.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 30 Aug 2017 06:25:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=ew/MLPJmYLcHWKIH8EEN8ez1ES9u2/MKyNFh8KB5fYo=;\n\tb=f0P8ERF9tDye7Z\n\tQNQiew9YpiNMfwelQ9p/rZovry5Bljyt2M0NCxBwrUbvc1F+LkDUxNLWKdgj9C3C3EgEbw1p8+ZBv\n\tJH/VrC435mFdwjRQEY55/AKdtYQ48+BBB1aJ7XYltaNAStc5HqTSvjsnRigbCxH96QIdYc8X49U02\n\toAkaR1NXxUOPXCb5OaIfFg2QrNH96uVStZxy6jynx6xDTbHNIGx4eLBTAQBvqAvHNHpOyn9cNLFN8\n\tqhUsaUH2PmCzVlzTHC78vskSo7Ealbwj4rIFoy7rbtE1O3G1snZ35La1bXOWryN6EGo1GilTeFzLi\n\tpCpvliuS/BrwZEEsMraQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=2w9u3nUGvirFzV6O4lmVEfGIpnOogQMChtLPQX490nc=;\n\tb=Mc5aWS/b+h/c2v7SpyU4q5tu5YU3TJ+VUBspdTwBQA2q/n9TYSfSzgPGSGSJ+H738f\n\tDsUemA+RELRW7bFWibYpIjnP3nwcvkW9K2hptLHLg/VggDuI4gkCBB6mDWiZ9BEEDiog\n\tVeRwpKSANJTlo8MYqMJ8I/aHkbp9SpxFcITLdchHxKTs18NNUxUj+0OPoHhNj5C/jH+b\n\tlLbWGR7YxK8YDxSTdS40vLuiUizrEITFP8sYvUvOfZBieYX35rigxxDZ6nXT7v6S8BOa\n\tz6dGoiXjsQCbF1SMU97nqaBUgalKBq36nn+FoS+n/CtdjUswUmjkiEYH73utrkee45Cw\n\tbXpw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=2w9u3nUGvirFzV6O4lmVEfGIpnOogQMChtLPQX490nc=;\n\tb=HQk1twEM21+Ghxq5oAdiwef2j4bFdWA+crUQ/uKq5kH4UuiUvGiuItLcxxGmf+nvWV\n\tVAb9VxGkMvSI0qTyjhk0bZTko7ojjg+FwwRtXK7LVEP8WDZQ3N8RlwWT3H4gACx7wYq0\n\tVPdyglOUORjTcH1aswjtEa6S8pRrYPkHRKlu+CSmgi9n/JWiSfLoO9DrvMWHOCwlNpP1\n\tLFFBaZ/i4qHkc1dC8DKO3PhvpYzfyA5oC4O8615Uq/QkNaVCn9nXGC/Rb/GdHODo0PR6\n\tulo+l2haefcCD+oUFgAsNP/dCh4+jyw6BP8If0YPYg61EEuurTwVD9u/Q8hp0+ZKkdHa\n\t/R5g==","X-Gm-Message-State":"AHPjjUhonsAHHTZ6iGY/4RzNdv9qw1nRDMm39JetVkuLrMhv7MrhV4XB\n\t3YervEZnVTDDAWpN","X-Received":"by 10.107.153.204 with SMTP id\n\tb195mr1276953ioe.235.1504099516075; \n\tWed, 30 Aug 2017 06:25:16 -0700 (PDT)","From":"Hans Dedecker ","To":"john@phrozen.org,\n\tlede-dev@lists.infradead.org","Date":"Wed, 30 Aug 2017 15:25:10 +0200","Message-Id":"<1504099510-25445-1-git-send-email-dedeckeh@gmail.com>","X-Mailer":"git-send-email 1.9.1","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170830_062537_476807_B661E184 ","X-CRM114-Status":"UNSURE ( 9.18 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (dedeckeh[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH ubox 3/3] kmodloader: fix possible segfaults","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hans Dedecker ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Signed-off-by: Hans Dedecker \n---\n kmodloader.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/kmodloader.c b/kmodloader.c\nindex 2ece0c2..1ddde0d 100644\n--- a/kmodloader.c\n+++ b/kmodloader.c\n@@ -565,6 +565,9 @@ static int insert_module(char *path, const char *options)\n \t}\n \n \tdata = malloc(s.st_size);\n+\tif (!data)\n+\t\tgoto out;\n+\n \tif (read(fd, data, s.st_size) == s.st_size) {\n \t\tret = syscall(__NR_init_module, data, (unsigned long) s.st_size, options);\n \t\tif (errno == EEXIST)\n@@ -573,6 +576,7 @@ static int insert_module(char *path, const char *options)\n \telse\n \t\tULOG_ERR(\"failed to read full module %s\\n\", path);\n \n+out:\n \tclose(fd);\n \tfree(data);\n \n@@ -694,6 +698,11 @@ static int main_insmod(int argc, char **argv)\n \t\tlen += strlen(argv[i]) + 1;\n \n \toptions = malloc(len);\n+\tif (!options) {\n+\t\tret = -1;\n+\t\tgoto err;\n+\t}\n+\n \toptions[0] = 0;\n \tcur = options;\n \tfor (i = 2; i < argc; i++) {\n@@ -899,6 +908,9 @@ static int main_loader(int argc, char **argv)\n \t\tdir = argv[1];\n \n \tpath = malloc(strlen(dir) + 2);\n+\tif (!path)\n+\t\treturn -1;\n+\n \tstrcpy(path, dir);\n \tstrcat(path, \"*\");\n \n","prefixes":["LEDE-DEV","ubox","3/3"]}