{"id":807592,"url":"http://patchwork.ozlabs.org/api/patches/807592/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170830110603.12372-1-salil.mehta@huawei.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170830110603.12372-1-salil.mehta@huawei.com>","list_archive_url":null,"date":"2017-08-30T11:06:03","name":"[net-next] net: hns3: Fixes the wrong IS_ERR check on the returned phydev value","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"5c3ad733736ee4a9ef8161bc09f6e2a0b3651991","submitter":{"id":67454,"url":"http://patchwork.ozlabs.org/api/people/67454/?format=json","name":"Salil Mehta","email":"salil.mehta@huawei.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170830110603.12372-1-salil.mehta@huawei.com/mbox/","series":[{"id":588,"url":"http://patchwork.ozlabs.org/api/series/588/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=588","date":"2017-08-30T11:06:03","name":"[net-next] net: hns3: Fixes the wrong IS_ERR check on the returned phydev value","version":1,"mbox":"http://patchwork.ozlabs.org/series/588/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807592/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807592/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj2kx5d3fz9sMN\n\tfor ;\n\tWed, 30 Aug 2017 21:06:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751334AbdH3LGi (ORCPT );\n\tWed, 30 Aug 2017 07:06:38 -0400","from szxga04-in.huawei.com ([45.249.212.190]:5495 \"EHLO\n\tszxga04-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751263AbdH3LGg (ORCPT\n\t); Wed, 30 Aug 2017 07:06:36 -0400","from 172.30.72.59 (EHLO DGGEMS408-HUB.china.huawei.com)\n\t([172.30.72.59])\n\tby dggrg04-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DGE67880; Wed, 30 Aug 2017 19:06:31 +0800 (CST)","from S00293818-DELL1.china.huawei.com (10.203.181.162) by\n\tDGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP\n\tServer id 14.3.301.0; Wed, 30 Aug 2017 19:06:23 +0800"],"From":"Salil Mehta ","To":"","CC":", ,\n\t, ,\n\t, ","Subject":"[PATCH net-next] net: hns3: Fixes the wrong IS_ERR check on the\n\treturned phydev value","Date":"Wed, 30 Aug 2017 12:06:03 +0100","Message-ID":"<20170830110603.12372-1-salil.mehta@huawei.com>","X-Mailer":"git-send-email 2.8.3","MIME-Version":"1.0","Content-Type":"text/plain","X-Originating-IP":"[10.203.181.162]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A090205.59A69C39.016F, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"1ac1ed7805995f8af4a87afb11d48762","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"This patch removes the wrong check being done for the phy device being\nreturned by the mdiobus_get_phy() function. This function never returns\nthe error pointers.\n\nFixes: 256727da7395 (\"net: hns3: Add MDIO support to HNS3 Ethernet\nDriver for hip08 SoC\")\nReported-by: Dan Carpenter \nSigned-off-by: Salil Mehta \n---\n drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c\nindex a2add8b..f32d719 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c\n@@ -150,7 +150,7 @@ int hclge_mac_mdio_config(struct hclge_dev *hdev)\n \t}\n \n \tphydev = mdiobus_get_phy(mdio_bus, mac->phy_addr);\n-\tif (!phydev || IS_ERR(phydev)) {\n+\tif (!phydev) {\n \t\tdev_err(mdio_bus->parent, \"Failed to get phy device\\n\");\n \t\tmdiobus_unregister(mdio_bus);\n \t\treturn -EIO;\n","prefixes":["net-next"]}