{"id":807527,"url":"http://patchwork.ozlabs.org/api/patches/807527/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/ac6fe8f6-5e16-1a5f-ae1b-193a50f03065@suse.cz/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<ac6fe8f6-5e16-1a5f-ae1b-193a50f03065@suse.cz>","list_archive_url":null,"date":"2017-08-30T09:12:47","name":"Fix IPA ICF with ASM statements (PR inline-asm/82001).","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fc1caeb6f58ea2b489a9c9f464d0626d15945289","submitter":{"id":62010,"url":"http://patchwork.ozlabs.org/api/people/62010/?format=json","name":"Martin Liška","email":"mliska@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/ac6fe8f6-5e16-1a5f-ae1b-193a50f03065@suse.cz/mbox/","series":[{"id":556,"url":"http://patchwork.ozlabs.org/api/series/556/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=556","date":"2017-08-30T09:12:47","name":"Fix IPA ICF with ASM statements (PR inline-asm/82001).","version":1,"mbox":"http://patchwork.ozlabs.org/series/556/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807527/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807527/checks/","tags":{},"related":[],"headers":{"Return-Path":"<gcc-patches-return-461138-incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461138-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"liMuPnFh\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj0Cd5ssSz9t2Q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 19:12:59 +1000 (AEST)","(qmail 60612 invoked by alias); 30 Aug 2017 09:12:51 -0000","(qmail 60560 invoked by uid 89); 30 Aug 2017 09:12:51 -0000","from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 30 Aug 2017 09:12:50 +0000","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\tby\n\tmx1.suse.de (Postfix) with ESMTP id E57CAAC10\tfor\n\t<gcc-patches@gcc.gnu.org>; Wed, 30 Aug 2017 09:12:47 +0000 (UTC)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:subject:to:message-id:date:mime-version:content-type; q=dns; s=\n\tdefault; b=sYVgeo2mIJUoR509RkzgaLJ5DWIWh3URZY/eQj5zqWcUA6jA1bdEo\n\tdPlUh2W4oab8gGR0qBvF6Ud5yMsE4Y7JUHIzP2+tKvKZP1Ok6PvwQQxlNlqyIpxt\n\tk+o+iPwp8iX1VYE4Eigt0pV2v6ZwsNgjx/s3Miw59FFOfOCDjIPAAc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:subject:to:message-id:date:mime-version:content-type; s=\n\tdefault; bh=JDugYyc0izdXAK+auZsQGqIBvdE=; b=liMuPnFhM6Yg4Joj5FkP\n\ttTRzQLpkgXeSvxfHTHqCsiZFd6TQAshkMumjMFQWnCoNbVUDfQb7kXzbX4OPXOiy\n\tG03sZ7s/38dFk0vY6s+oHU4hKI0zYRuxCXLINRULlblKCAQfcxiiudJJecLLqw+r\n\tNYAkDvigEwe6h4MZaW7LHeY=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"<gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>","List-Archive":"<http://gcc.gnu.org/ml/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-help@gcc.gnu.org>","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.suse.de","From":"=?utf-8?q?Martin_Li=C5=A1ka?= <mliska@suse.cz>","Subject":"[PATCH] Fix IPA ICF with ASM statements (PR inline-asm/82001).","To":"gcc-patches@gcc.gnu.org","Message-ID":"<ac6fe8f6-5e16-1a5f-ae1b-193a50f03065@suse.cz>","Date":"Wed, 30 Aug 2017 11:12:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.2.1","MIME-Version":"1.0","Content-Type":"multipart/mixed;\n\tboundary=\"------------1287D9ED3C6BA1CAFF89BD8C\"","X-IsSubscribed":"yes"},"content":"Hi.\n\nFollowing patch compares also constraints of input and output operands of ASM statements.\nPatch can bootstrap on ppc64le-redhat-linux and survives regression tests.\n\nReady to be installed?\nMartin\n\ngcc/ChangeLog:\n\n2017-08-28  Martin Liska  <mliska@suse.cz>\n\n\tPR inline-asm/82001\n\t* ipa-icf-gimple.c (func_checker::compare_tree_list_operand):\n\tCompare TREE_PURPOSE of asm inputs and outputs.\n\ngcc/testsuite/ChangeLog:\n\n2017-08-28  Martin Liska  <mliska@suse.cz>\n\n\tPR inline-asm/82001\n\t* gcc.dg/ipa/pr82001.c: New test.\n---\n gcc/ipa-icf-gimple.c               | 10 ++++++++++\n gcc/testsuite/gcc.dg/ipa/pr82001.c | 21 +++++++++++++++++++++\n 2 files changed, 31 insertions(+)\n create mode 100644 gcc/testsuite/gcc.dg/ipa/pr82001.c","diff":"diff --git a/gcc/ipa-icf-gimple.c b/gcc/ipa-icf-gimple.c\nindex f44a995f580..c08a43c1cdc 100644\n--- a/gcc/ipa-icf-gimple.c\n+++ b/gcc/ipa-icf-gimple.c\n@@ -560,6 +560,16 @@ func_checker::compare_tree_list_operand (tree t1, tree t2)\n       if (!compare_operand (TREE_VALUE (t1), TREE_VALUE (t2)))\n \treturn return_false ();\n \n+      tree p1 = TREE_PURPOSE (t1);\n+      tree p2 = TREE_PURPOSE (t2);\n+\n+      gcc_assert (TREE_CODE (p1) == TREE_LIST);\n+      gcc_assert (TREE_CODE (p2) == TREE_LIST);\n+\n+      if (strcmp (TREE_STRING_POINTER (TREE_VALUE (p1)),\n+\t\t  TREE_STRING_POINTER (TREE_VALUE (p2))) != 0)\n+\treturn return_false ();\n+\n       t2 = TREE_CHAIN (t2);\n     }\n \ndiff --git a/gcc/testsuite/gcc.dg/ipa/pr82001.c b/gcc/testsuite/gcc.dg/ipa/pr82001.c\nnew file mode 100644\nindex 00000000000..05e32b10ef5\n--- /dev/null\n+++ b/gcc/testsuite/gcc.dg/ipa/pr82001.c\n@@ -0,0 +1,21 @@\n+/* { dg-do compile { target i?86-*-* x86_64-*-* } } */\n+/* { dg-options \"-O2 -fdump-ipa-icf-details\"  } */\n+\n+int\n+mullo (int a, int b)\n+{\n+  asm(\"mul %%edx   # %%1 was %1\"\n+      : \"+\"\n+\t\"a\"(a),\n+\t\"+d\"(b));\n+  return a;\n+}\n+\n+int\n+mulhi (int a, int b)\n+{\n+  asm(\"mul %%edx   # %%1 was %1\" : \"+d\"(a), \"+a\"(b));\n+  return a;\n+}\n+\n+/* { dg-final { scan-ipa-dump \"Equal symbols: 0\" \"icf\"  } } */\n\n","prefixes":[]}