{"id":807329,"url":"http://patchwork.ozlabs.org/api/patches/807329/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829220337.23427-1-ehabkost@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170829220337.23427-1-ehabkost@redhat.com>","list_archive_url":null,"date":"2017-08-29T22:03:37","name":"qom: Remove unused errp parameter from can_be_deleted()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fad6344c0ddc3a7269e0fc9a39c40a4474609d91","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/?format=json","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829220337.23427-1-ehabkost@redhat.com/mbox/","series":[{"id":491,"url":"http://patchwork.ozlabs.org/api/series/491/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491","date":"2017-08-29T22:03:37","name":"qom: Remove unused errp parameter from can_be_deleted()","version":1,"mbox":"http://patchwork.ozlabs.org/series/491/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807329/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807329/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhjMz6z4Dz9s8w\n\tfor ;\n\tWed, 30 Aug 2017 08:04:15 +1000 (AEST)","from localhost ([::1]:47219 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmocH-00074O-MG\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 18:04:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38729)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmobq-00074G-Pd\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 18:03:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmobk-0000YC-Kt\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 18:03:46 -0400","from mx1.redhat.com ([209.132.183.28]:34408)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dmobk-0000Xn-CK\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 18:03:40 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2BEFCC0587C1;\n\tTue, 29 Aug 2017 22:03:39 +0000 (UTC)","from localhost (ovpn-116-31.gru2.redhat.com [10.97.116.31])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B6C986933B;\n\tTue, 29 Aug 2017 22:03:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2BEFCC0587C1","From":"Eduardo Habkost ","To":"qemu-devel@nongnu.org","Date":"Tue, 29 Aug 2017 19:03:37 -0300","Message-Id":"<20170829220337.23427-1-ehabkost@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 29 Aug 2017 22:03:39 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH] qom: Remove unused errp parameter from\n\tcan_be_deleted()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , Gonglei ,\n\tLin Ma , =?utf-8?q?Andreas_F=C3=A4rber?=\n\t, \tIgor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"The errp argument is ignored by all implementations of the\nmethod, and user_creatable_del() would break if any\nimplementation set an error (because it calls error_setg(errp) if\nthe function returns false). Remove the unused parameter.\n\nSigned-off-by: Eduardo Habkost \n---\n include/qom/object_interfaces.h | 5 ++---\n backends/cryptodev.c | 2 +-\n backends/hostmem.c | 2 +-\n qom/object_interfaces.c | 6 +++---\n 4 files changed, 7 insertions(+), 8 deletions(-)","diff":"diff --git a/include/qom/object_interfaces.h b/include/qom/object_interfaces.h\nindex fdd7603..d63c1c2 100644\n--- a/include/qom/object_interfaces.h\n+++ b/include/qom/object_interfaces.h\n@@ -51,7 +51,7 @@ typedef struct UserCreatableClass {\n \n /* */\n void (*complete)(UserCreatable *uc, Error **errp);\n- bool (*can_be_deleted)(UserCreatable *uc, Error **errp);\n+ bool (*can_be_deleted)(UserCreatable *uc);\n } UserCreatableClass;\n \n /**\n@@ -68,12 +68,11 @@ void user_creatable_complete(Object *obj, Error **errp);\n /**\n * user_creatable_can_be_deleted:\n * @uc: the object whose can_be_deleted() method is called if implemented\n- * @errp: if an error occurs, a pointer to an area to store the error\n *\n * Wrapper to call can_be_deleted() method if one of types it's inherited\n * from implements USER_CREATABLE interface.\n */\n-bool user_creatable_can_be_deleted(UserCreatable *uc, Error **errp);\n+bool user_creatable_can_be_deleted(UserCreatable *uc);\n \n /**\n * user_creatable_add_type:\ndiff --git a/backends/cryptodev.c b/backends/cryptodev.c\nindex 1764c17..67edfa5 100644\n--- a/backends/cryptodev.c\n+++ b/backends/cryptodev.c\n@@ -215,7 +215,7 @@ bool cryptodev_backend_is_ready(CryptoDevBackend *backend)\n }\n \n static bool\n-cryptodev_backend_can_be_deleted(UserCreatable *uc, Error **errp)\n+cryptodev_backend_can_be_deleted(UserCreatable *uc)\n {\n return !cryptodev_backend_is_used(CRYPTODEV_BACKEND(uc));\n }\ndiff --git a/backends/hostmem.c b/backends/hostmem.c\nindex 4606b73..34550b9 100644\n--- a/backends/hostmem.c\n+++ b/backends/hostmem.c\n@@ -342,7 +342,7 @@ out:\n }\n \n static bool\n-host_memory_backend_can_be_deleted(UserCreatable *uc, Error **errp)\n+host_memory_backend_can_be_deleted(UserCreatable *uc)\n {\n if (host_memory_backend_is_mapped(MEMORY_BACKEND(uc))) {\n return false;\ndiff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\nindex ff27e06..3bb8959 100644\n--- a/qom/object_interfaces.c\n+++ b/qom/object_interfaces.c\n@@ -23,13 +23,13 @@ void user_creatable_complete(Object *obj, Error **errp)\n }\n }\n \n-bool user_creatable_can_be_deleted(UserCreatable *uc, Error **errp)\n+bool user_creatable_can_be_deleted(UserCreatable *uc)\n {\n \n UserCreatableClass *ucc = USER_CREATABLE_GET_CLASS(uc);\n \n if (ucc->can_be_deleted) {\n- return ucc->can_be_deleted(uc, errp);\n+ return ucc->can_be_deleted(uc);\n } else {\n return true;\n }\n@@ -178,7 +178,7 @@ void user_creatable_del(const char *id, Error **errp)\n return;\n }\n \n- if (!user_creatable_can_be_deleted(USER_CREATABLE(obj), errp)) {\n+ if (!user_creatable_can_be_deleted(USER_CREATABLE(obj))) {\n error_setg(errp, \"object '%s' is in use, can not be deleted\", id);\n return;\n }\n","prefixes":[]}