{"id":807231,"url":"http://patchwork.ozlabs.org/api/patches/807231/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504032890-25229-1-git-send-email-himanshujha199640@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504032890-25229-1-git-send-email-himanshujha199640@gmail.com>","list_archive_url":null,"date":"2017-08-29T18:54:50","name":"rsi: remove memset before memcpy","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"ad2d4c2df0c828f933c95702a04c333b00e41db6","submitter":{"id":72201,"url":"http://patchwork.ozlabs.org/api/people/72201/?format=json","name":"Himanshu Jha","email":"himanshujha199640@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504032890-25229-1-git-send-email-himanshujha199640@gmail.com/mbox/","series":[{"id":438,"url":"http://patchwork.ozlabs.org/api/series/438/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=438","date":"2017-08-29T18:54:50","name":"rsi: remove memset before memcpy","version":1,"mbox":"http://patchwork.ozlabs.org/series/438/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807231/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807231/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sx2W4/Pu\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhd9x5zC4z9t0M\n\tfor ;\n\tWed, 30 Aug 2017 04:55:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751349AbdH2SzG (ORCPT );\n\tTue, 29 Aug 2017 14:55:06 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:34292 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751186AbdH2SzE (ORCPT\n\t); Tue, 29 Aug 2017 14:55:04 -0400","by mail-pg0-f67.google.com with SMTP id 63so3342611pgc.1;\n\tTue, 29 Aug 2017 11:55:04 -0700 (PDT)","from localhost.localdomain ([103.254.204.108])\n\tby smtp.gmail.com with ESMTPSA id\n\tg1sm6001126pge.69.2017.08.29.11.55.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 29 Aug 2017 11:55:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=Xl8mNhouS1JUixt/vNZMuif43K6EYvWvQUsxvZwDy+o=;\n\tb=sx2W4/PuGTYEcWzg+ffcplqpSMrg9i5b9Wa5voXVTeh8h/s1txocOvysxjBO3l7IZm\n\tGWGI7zC99FVt/NvuYf/as/IzET3YLnHTapIY+vAl3sg1IR8g1BpUAgL1wBXKy9r7kEka\n\tRaJLPe4bwscb5ScrcDGpX9NsXfa7XsTxR4lES+5f0IRch9xs3bmgNbaO5PsxEc4zA/hr\n\t7Hsq6CD3B38Ks+nTTVOL4IFFSvrZROXNb9Jneem+t1MewKOuPllxuWpvXn54/fxdWzqt\n\t3/bNpfY3+RiDEl5NIYIe5ft08lVbyqkQ/Ob6X1hoVYfiuAgX+ffmTwGNAoiY3b5sXfb8\n\tDHeA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=Xl8mNhouS1JUixt/vNZMuif43K6EYvWvQUsxvZwDy+o=;\n\tb=mKKy3cUZeSNZofWNZddC6UyrzQ9D34azZT3t/lJypmBGN4/GtPrOooWRJbDqss3UJV\n\tsed935kPKBRkcCMhTBjSf4vBfy4z90xG6XbxMAr2P+RAT/5ozk484T/rZCJCKSsMEoWo\n\tPNZE1SkQst6JaFPv0cBZZyeMXV/rOTGEtqOtSr9e6NWTSg+SgTgcTs4mnA7Foz3GuZ50\n\tmnzkvZQGZl/JDW2ErawxshVG6YL3Fnx5UY/RqLr2R9Do2Swhj6IPbQT74Gr1/LyuR6MB\n\tUt5ihpPo/F0vLiFEdJS6OwO0Mc+CplCreJajoQtyUH0ILVjBqIN/cF9mt+BUsECXTY5w\n\tNhsw==","X-Gm-Message-State":"AHYfb5hUeL2Mr0nW0nBcSa5hvzsADlmHfocOlx9Bx77gOsYf6Gven7qo\n\tbipaXXP+SQRntA==","X-Google-Smtp-Source":"ADKCNb7ISS9l63QIJgar9zKuKvOi6OO3A0ZsQhS4bedvJFWsf545dQxDM05O18TClJOqNj6mb+D0BQ==","X-Received":"by 10.84.194.228 with SMTP id h91mr1574222pld.447.1504032904073; \n\tTue, 29 Aug 2017 11:55:04 -0700 (PDT)","From":"Himanshu Jha ","To":"kvalo@codeaurora.org","Cc":"amit.karwar@redpinesignals.com, linux-wireless@vger.kernel.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tHimanshu Jha ","Subject":"[PATCH] rsi: remove memset before memcpy","Date":"Wed, 30 Aug 2017 00:24:50 +0530","Message-Id":"<1504032890-25229-1-git-send-email-himanshujha199640@gmail.com>","X-Mailer":"git-send-email 2.7.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"calling memcpy immediately after memset with the same region of memory\nmakes memset redundant.\n\nSigned-off-by: Himanshu Jha \n---\n drivers/net/wireless/rsi/rsi_91x_sdio.c | 1 -\n drivers/net/wireless/rsi/rsi_91x_usb.c | 1 -\n 2 files changed, 2 deletions(-)","diff":"diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c\nindex 742f6cd..8d3a483 100644\n--- a/drivers/net/wireless/rsi/rsi_91x_sdio.c\n+++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c\n@@ -584,7 +584,6 @@ static int rsi_sdio_load_data_master_write(struct rsi_hw *adapter,\n \t}\n \n \tfor (offset = 0, i = 0; i < num_blocks; i++, offset += block_size) {\n-\t\tmemset(temp_buf, 0, block_size);\n \t\tmemcpy(temp_buf, ta_firmware + offset, block_size);\n \t\tlsb_address = (u16)base_address;\n \t\tstatus = rsi_sdio_write_register_multiple\ndiff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c\nindex 9097f7e..81df09d 100644\n--- a/drivers/net/wireless/rsi/rsi_91x_usb.c\n+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c\n@@ -439,7 +439,6 @@ static int rsi_usb_load_data_master_write(struct rsi_hw *adapter,\n \trsi_dbg(INFO_ZONE, \"num_blocks: %d\\n\", num_blocks);\n \n \tfor (cur_indx = 0, i = 0; i < num_blocks; i++, cur_indx += block_size) {\n-\t\tmemset(temp_buf, 0, block_size);\n \t\tmemcpy(temp_buf, ta_firmware + cur_indx, block_size);\n \t\tstatus = rsi_usb_write_register_multiple(adapter, base_address,\n \t\t\t\t\t\t\t (u8 *)(temp_buf),\n","prefixes":[]}