{"id":807220,"url":"http://patchwork.ozlabs.org/api/patches/807220/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1504031188-11434-1-git-send-email-nikolay@cumulusnetworks.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504031188-11434-1-git-send-email-nikolay@cumulusnetworks.com>","list_archive_url":null,"date":"2017-08-29T18:26:28","name":"[net] sch_multiq: fix double free on init failure","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"7bd4671f06962d28c0b22f5c1bcf61f100752474","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/?format=json","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1504031188-11434-1-git-send-email-nikolay@cumulusnetworks.com/mbox/","series":[{"id":431,"url":"http://patchwork.ozlabs.org/api/series/431/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=431","date":"2017-08-29T18:26:28","name":"[net] sch_multiq: fix double free on init failure","version":1,"mbox":"http://patchwork.ozlabs.org/series/431/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807220/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807220/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"hlGl00P2\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhcZ93DK8z9sN5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 04:27:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751275AbdH2S1m (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 14:27:42 -0400","from mail-wr0-f171.google.com ([209.85.128.171]:37394 \"EHLO\n\tmail-wr0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751227AbdH2S1l (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 29 Aug 2017 14:27:41 -0400","by mail-wr0-f171.google.com with SMTP id k9so298888wre.4\n\tfor <netdev@vger.kernel.org>; Tue, 29 Aug 2017 11:27:40 -0700 (PDT)","from debil.mediahub-bg.com (46-10-142-144.ip.btc-net.bg.\n\t[46.10.142.144]) by smtp.gmail.com with ESMTPSA id\n\tc1sm2992942wre.83.2017.08.29.11.27.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 29 Aug 2017 11:27:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=6TKZanqYCEoS2CTvTaodoXUs1b1oyoRtFfmh4SD+3Nw=;\n\tb=hlGl00P2pdDKYT91a+MDFiHTdm1SYX3WrBqRYeRVC/WPeALg46lS+3XKekXh27+9n4\n\tO9FfrI3ZrB2M5l4Ks9C+LTw2ZhEFk0ExAHJOpOHGc6evnM1KkX4trWk6KHsWE0weAz+G\n\tKvINr/XGZbFrTi0nJafdBjWJ3zWtLW9rr1lBw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=6TKZanqYCEoS2CTvTaodoXUs1b1oyoRtFfmh4SD+3Nw=;\n\tb=FoSy5Uba1siKHJa8JnhsB58EAqsk9zWxJ+7ysLhAn1hWJo62V5d3HGptKSpW6jB7hh\n\tWSYCQnCYG/ywYwIndH+qnfiwlAh+OkffC5ojwVUneZp84OvlkfoBaLZfwOsBs5LsOXrY\n\tgrBO1h8al1SpLNhH84lVQDf/8mYc0ddcevPTmXno1zmbjtafxOuHDBcY5GFKaGxzIoGl\n\tRVqJNEhDc7py2a7go6hT87BeKdEDfSOaWYrc8OpX+vAmezkKg9WolykwTnnDzlYmZaD3\n\t/J4gJct3AYw58FVJI6YqBbPwOH4RgjlBcttIg4MNnOZQ5Q3/vG7f4DSs58Cy4rOB3TWK\n\t6bbg==","X-Gm-Message-State":"AHYfb5hFaHohpQkcvCc6kNXyed/0P942+wtHF+9BknBrYoo6XD58Bj0k\n\t3Xyj4/WvQhOPuE5ipj8=","X-Received":"by 10.223.163.66 with SMTP id d2mr756012wrb.157.1504031259470;\n\tTue, 29 Aug 2017 11:27:39 -0700 (PDT)","From":"Nikolay Aleksandrov <nikolay@cumulusnetworks.com>","To":"netdev@vger.kernel.org","Cc":"edumazet@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us, roopa@cumulusnetworks.com,\n\tNikolay Aleksandrov <nikolay@cumulusnetworks.com>","Subject":"[PATCH net] sch_multiq: fix double free on init failure","Date":"Tue, 29 Aug 2017 21:26:28 +0300","Message-Id":"<1504031188-11434-1-git-send-email-nikolay@cumulusnetworks.com>","X-Mailer":"git-send-email 2.1.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The below commit added a call to ->destroy() on init failure, but multiq\nstill frees ->queues on error in init, but ->queues is also freed by\n->destroy() thus we get double free and corrupted memory.\n\nVery easy to reproduce (eth0 not multiqueue):\n$ tc qdisc add dev eth0 root multiq\nRTNETLINK answers: Operation not supported\n$ ip l add dumdum type dummy\n(crash)\n\nTrace log:\n[ 3929.467747] general protection fault: 0000 [#1] SMP\n[ 3929.468083] Modules linked in:\n[ 3929.468302] CPU: 3 PID: 967 Comm: ip Not tainted 4.13.0-rc6+ #56\n[ 3929.468625] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014\n[ 3929.469124] task: ffff88003716a700 task.stack: ffff88005872c000\n[ 3929.469449] RIP: 0010:__kmalloc_track_caller+0x117/0x1be\n[ 3929.469746] RSP: 0018:ffff88005872f6a0 EFLAGS: 00010246\n[ 3929.470042] RAX: 00000000000002de RBX: 0000000058a59000 RCX: 00000000000002df\n[ 3929.470406] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff821f7020\n[ 3929.470770] RBP: ffff88005872f6e8 R08: 000000000001f010 R09: 0000000000000000\n[ 3929.471133] R10: ffff88005872f730 R11: 0000000000008cdd R12: ff006d75646d7564\n[ 3929.471496] R13: 00000000014000c0 R14: ffff88005b403c00 R15: ffff88005b403c00\n[ 3929.471869] FS:  00007f0b70480740(0000) GS:ffff88005d980000(0000) knlGS:0000000000000000\n[ 3929.472286] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n[ 3929.472677] CR2: 00007ffcee4f3000 CR3: 0000000059d45000 CR4: 00000000000406e0\n[ 3929.473209] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000\n[ 3929.474109] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400\n[ 3929.474873] Call Trace:\n[ 3929.475337]  ? kstrdup_const+0x23/0x25\n[ 3929.475863]  kstrdup+0x2e/0x4b\n[ 3929.476338]  kstrdup_const+0x23/0x25\n[ 3929.478084]  __kernfs_new_node+0x28/0xbc\n[ 3929.478478]  kernfs_new_node+0x35/0x55\n[ 3929.478929]  kernfs_create_link+0x23/0x76\n[ 3929.479478]  sysfs_do_create_link_sd.isra.2+0x85/0xd7\n[ 3929.480096]  sysfs_create_link+0x33/0x35\n[ 3929.480649]  device_add+0x200/0x589\n[ 3929.481184]  netdev_register_kobject+0x7c/0x12f\n[ 3929.481711]  register_netdevice+0x373/0x471\n[ 3929.482174]  rtnl_newlink+0x614/0x729\n[ 3929.482610]  ? rtnl_newlink+0x17f/0x729\n[ 3929.483080]  rtnetlink_rcv_msg+0x188/0x197\n[ 3929.483533]  ? rcu_read_unlock+0x3e/0x5f\n[ 3929.483984]  ? rtnl_newlink+0x729/0x729\n[ 3929.484420]  netlink_rcv_skb+0x6c/0xce\n[ 3929.484858]  rtnetlink_rcv+0x23/0x2a\n[ 3929.485291]  netlink_unicast+0x103/0x181\n[ 3929.485735]  netlink_sendmsg+0x326/0x337\n[ 3929.486181]  sock_sendmsg_nosec+0x14/0x3f\n[ 3929.486614]  sock_sendmsg+0x29/0x2e\n[ 3929.486973]  ___sys_sendmsg+0x209/0x28b\n[ 3929.487340]  ? do_raw_spin_unlock+0xcd/0xf8\n[ 3929.487719]  ? _raw_spin_unlock+0x27/0x31\n[ 3929.488092]  ? __handle_mm_fault+0x651/0xdb1\n[ 3929.488471]  ? check_chain_key+0xb0/0xfd\n[ 3929.488847]  __sys_sendmsg+0x45/0x63\n[ 3929.489206]  ? __sys_sendmsg+0x45/0x63\n[ 3929.489576]  SyS_sendmsg+0x19/0x1b\n[ 3929.489901]  entry_SYSCALL_64_fastpath+0x23/0xc2\n[ 3929.490172] RIP: 0033:0x7f0b6fb93690\n[ 3929.490423] RSP: 002b:00007ffcee4ed588 EFLAGS: 00000246 ORIG_RAX: 000000000000002e\n[ 3929.490881] RAX: ffffffffffffffda RBX: ffffffff810d278c RCX: 00007f0b6fb93690\n[ 3929.491198] RDX: 0000000000000000 RSI: 00007ffcee4ed5d0 RDI: 0000000000000003\n[ 3929.491521] RBP: ffff88005872ff98 R08: 0000000000000001 R09: 0000000000000000\n[ 3929.491801] R10: 00007ffcee4ed350 R11: 0000000000000246 R12: 0000000000000002\n[ 3929.492075] R13: 000000000066f1a0 R14: 00007ffcee4f5680 R15: 0000000000000000\n[ 3929.492352]  ? trace_hardirqs_off_caller+0xa7/0xcf\n[ 3929.492590] Code: 8b 45 c0 48 8b 45 b8 74 17 48 8b 4d c8 83 ca ff 44\n89 ee 4c 89 f7 e8 83 ca ff ff 49 89 c4 eb 49 49 63 56 20 48 8d 48 01 4d\n8b 06 <49> 8b 1c 14 48 89 c2 4c 89 e0 65 49 0f c7 08 0f 94 c0 83 f0 01\n[ 3929.493335] RIP: __kmalloc_track_caller+0x117/0x1be RSP: ffff88005872f6a0\n\nFixes: 87b60cfacf9f (\"net_sched: fix error recovery at qdisc creation\")\nSigned-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>\n---\n net/sched/sch_multiq.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c\nindex f143b7bbaa0d..b07f8b01aa07 100644\n--- a/net/sched/sch_multiq.c\n+++ b/net/sched/sch_multiq.c\n@@ -259,9 +259,6 @@ static int multiq_init(struct Qdisc *sch, struct nlattr *opt)\n \n \terr = multiq_tune(sch, opt);\n \n-\tif (err)\n-\t\tkfree(q->queues);\n-\n \treturn err;\n }\n \n","prefixes":["net"]}