{"id":807208,"url":"http://patchwork.ozlabs.org/api/patches/807208/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170829093242.41026-11-alice.michael@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170829093242.41026-11-alice.michael@intel.com>","list_archive_url":null,"date":"2017-08-29T09:32:40","name":"[next,S79-V2,11/13] i40e: do not enter PHY debug mode while setting LEDs behaviour","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a1d2a15144a7b052591924c433570e215244f6a7","submitter":{"id":71123,"url":"http://patchwork.ozlabs.org/api/people/71123/?format=json","name":"Michael, Alice","email":"alice.michael@intel.com"},"delegate":{"id":68,"url":"http://patchwork.ozlabs.org/api/users/68/?format=json","username":"jtkirshe","first_name":"Jeff","last_name":"Kirsher","email":"jeffrey.t.kirsher@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170829093242.41026-11-alice.michael@intel.com/mbox/","series":[{"id":423,"url":"http://patchwork.ozlabs.org/api/series/423/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=423","date":"2017-08-29T09:32:31","name":"[next,S79-V2,01/13] i40e: add private flag to control source pruning","version":1,"mbox":"http://patchwork.ozlabs.org/series/423/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807208/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807208/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhbSS41N3z9t3R\n\tfor ;\n\tWed, 30 Aug 2017 03:37:44 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CE23287220;\n\tTue, 29 Aug 2017 17:37:42 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eKcsgPve6lly; Tue, 29 Aug 2017 17:37:40 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 50EB186F87;\n\tTue, 29 Aug 2017 17:37:40 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7BF4E1CE993\n\tfor ;\n\tTue, 29 Aug 2017 17:37:35 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 78222889CA\n\tfor ;\n\tTue, 29 Aug 2017 17:37:35 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id llLm-+u1vlPB for ;\n\tTue, 29 Aug 2017 17:37:35 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id E7F6688B95\n\tfor ;\n\tTue, 29 Aug 2017 17:37:34 +0000 (UTC)","from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP; 29 Aug 2017 10:37:33 -0700","from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 29 Aug 2017 10:37:33 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.41,445,1498546800\"; d=\"scan'208\";\n\ta=\"1008934133\"","From":"Alice Michael ","To":"alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org","Date":"Tue, 29 Aug 2017 05:32:40 -0400","Message-Id":"<20170829093242.41026-11-alice.michael@intel.com>","X-Mailer":"git-send-email 2.9.4","In-Reply-To":"<20170829093242.41026-1-alice.michael@intel.com>","References":"<20170829093242.41026-1-alice.michael@intel.com>","Cc":"Mariusz Stachura ","Subject":"[Intel-wired-lan] [next PATCH S79-V2 11/13] i40e: do not enter PHY\n\tdebug mode while setting LEDs behaviour","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Mariusz Stachura \n\nPrevious implementation of LED set/get functions required to enter\nPHY debug mode, in order to prevent access to it from FW and SW at\nthe same time. Reset of all ports was a unwanted side effect.\n\nSigned-off-by: Mariusz Stachura \n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 5fab6c5..72da511 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -2010,7 +2010,9 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \t\tif (!(pf->hw_features & I40E_HW_PHY_CONTROLS_LEDS)) {\n \t\t\tpf->led_status = i40e_led_get(hw);\n \t\t} else {\n-\t\t\ti40e_aq_set_phy_debug(hw, I40E_PHY_DEBUG_ALL, NULL);\n+\t\t\tif (!(hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE))\n+\t\t\t\ti40e_aq_set_phy_debug(hw, I40E_PHY_DEBUG_ALL,\n+\t\t\t\t\t\t NULL);\n \t\t\tret = i40e_led_get_phy(hw, &temp_status,\n \t\t\t\t\t &pf->phy_led_val);\n \t\t\tpf->led_status = temp_status;\n@@ -2035,7 +2037,8 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \t\t\tret = i40e_led_set_phy(hw, false, pf->led_status,\n \t\t\t\t\t (pf->phy_led_val |\n \t\t\t\t\t I40E_PHY_LED_MODE_ORIG));\n-\t\t\ti40e_aq_set_phy_debug(hw, 0, NULL);\n+\t\t\tif (!(hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE))\n+\t\t\t\ti40e_aq_set_phy_debug(hw, 0, NULL);\n \t\t}\n \t\tbreak;\n \tdefault:\n","prefixes":["next","S79-V2","11/13"]}