{"id":806799,"url":"http://patchwork.ozlabs.org/api/patches/806799/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1503958460-20765-1-git-send-email-dsahern@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503958460-20765-1-git-send-email-dsahern@gmail.com>","list_archive_url":null,"date":"2017-08-28T22:14:20","name":"[net-next] net: Add comment that early_demux can change via sysctl","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"d41534f4c4552a6627873d20c044a1471e21ba4d","submitter":{"id":6918,"url":"http://patchwork.ozlabs.org/api/people/6918/?format=json","name":"David Ahern","email":"dsahern@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503958460-20765-1-git-send-email-dsahern@gmail.com/mbox/","series":[{"id":272,"url":"http://patchwork.ozlabs.org/api/series/272/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=272","date":"2017-08-28T22:14:20","name":"[net-next] net: Add comment that early_demux can change via sysctl","version":1,"mbox":"http://patchwork.ozlabs.org/series/272/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/806799/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806799/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rUHtTT0e\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xh5fL6SZ9z9s65\n\tfor ;\n\tTue, 29 Aug 2017 08:14:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751237AbdH1WOc (ORCPT );\n\tMon, 28 Aug 2017 18:14:32 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:33754 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751207AbdH1WOb (ORCPT\n\t); Mon, 28 Aug 2017 18:14:31 -0400","by mail-pg0-f65.google.com with SMTP id m15so1298941pgc.0\n\tfor ; Mon, 28 Aug 2017 15:14:31 -0700 (PDT)","from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com.\n\t[216.129.126.126]) by smtp.googlemail.com with ESMTPSA id\n\td184sm2020540pfa.9.2017.08.28.15.14.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 15:14:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=8a09cBseK/tk2hiIpWHnMGctTPHczFvbwnkq6zEH7PI=;\n\tb=rUHtTT0eeQ6/pvPAHqdb6w5O1SLUs9Nz7eVzKFvySuVZApVkd1r3ibM+ilGdh/Q/hK\n\tkpRVHOynqlIDiFbbySHvUqiRgMWiK9eWg5Fpy1tA/KLNJqhaXgbKmIwO7U9VWC5p0fEb\n\tsAWzAQVJIt1nB/B67nYUr2j+nN3fa+9YrL8s6PKB9plTloHw39siXXQjLfaktJSpV/yL\n\tcJZ9v+HRwV5QK46b7/s089ZW0QIiuZdWTzyoiMBMkNx5XN/+CTMo2hLutLb0zntk7rn0\n\tHGGYPOE/iaARE1loQQyJ53yAZgNCZ8Y1ScmrXXn3II06Y2AtoonPuopgQOFZ1bZ/MPld\n\tq0fQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=8a09cBseK/tk2hiIpWHnMGctTPHczFvbwnkq6zEH7PI=;\n\tb=L1km/+wlPgqIMz4zp4dFVHT7wKr8tcVMi3C6LBpM30IAT/6ffhisTKHnxu9qwbbDso\n\t/6X/XCqDt2VDeqeY5ug2MJzTWygr5oO5Tmey7PaxHna+/QJ0wkJ33M2URjPWVu00filn\n\tIrD1TsSPZ0efDJeD4rIxeGObpOSZ/8hHzdKVGuM7LrwQ3439wNITTXJCTWjsvmR96xiQ\n\tvBgYln8LQvq0eBQsiSAT2uUg+9xHho4abGDV7TEdiAEpcxRvq1r7lOBBGBXqB6RvVDrJ\n\t9xuxDruJzS6pplZAL3yNkGYCRELeqDZHbYoTJsKWalwDrw9Hb+ikUFqva4qG7GYEzgQv\n\tWmww==","X-Gm-Message-State":"AHYfb5hl10wUQqqucAYMd2uXhnvJaVwZSN6Abjuu6WvSuOYOkq74ey72\n\t2NjKqTtntsBDQ9ij","X-Received":"by 10.84.236.66 with SMTP id h2mr2383427pln.321.1503958471328;\n\tMon, 28 Aug 2017 15:14:31 -0700 (PDT)","From":"David Ahern ","To":"netdev@vger.kernel.org","Cc":"David Ahern ","Subject":"[PATCH net-next] net: Add comment that early_demux can change via\n\tsysctl","Date":"Mon, 28 Aug 2017 15:14:20 -0700","Message-Id":"<1503958460-20765-1-git-send-email-dsahern@gmail.com>","X-Mailer":"git-send-email 2.1.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Twice patches trying to constify inet{6}_protocol have been reverted:\n39294c3df2a8 (\"Revert \"ipv6: constify inet6_protocol structures\"\") to\nrevert 3a3a4e3054137 and then 03157937fe0b5 (\"Revert \"ipv4: make\nnet_protocol const\"\") to revert aa8db499ea67.\n\nAdd a comment that the structures can not be const because the\nearly_demux field can change based on a sysctl.\n\nSigned-off-by: David Ahern \n---\n net/ipv4/af_inet.c | 6 ++++++\n net/ipv6/tcp_ipv6.c | 3 +++\n net/ipv6/udp.c | 3 +++\n 3 files changed, 12 insertions(+)","diff":"diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c\nindex d678820e4306..e31108e5ef79 100644\n--- a/net/ipv4/af_inet.c\n+++ b/net/ipv4/af_inet.c\n@@ -1596,6 +1596,9 @@ static const struct net_protocol igmp_protocol = {\n };\n #endif\n \n+/* thinking of making this const? Don't.\n+ * early_demux can change based on sysctl.\n+ */\n static struct net_protocol tcp_protocol = {\n \t.early_demux\t=\ttcp_v4_early_demux,\n \t.early_demux_handler = tcp_v4_early_demux,\n@@ -1606,6 +1609,9 @@ static struct net_protocol tcp_protocol = {\n \t.icmp_strict_tag_validation = 1,\n };\n \n+/* thinking of making this const? Don't.\n+ * early_demux can change based on sysctl.\n+ */\n static struct net_protocol udp_protocol = {\n \t.early_demux =\tudp_v4_early_demux,\n \t.early_demux_handler =\tudp_v4_early_demux,\ndiff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c\nindex abba3bc2a3d9..38f76d8b231e 100644\n--- a/net/ipv6/tcp_ipv6.c\n+++ b/net/ipv6/tcp_ipv6.c\n@@ -1949,6 +1949,9 @@ struct proto tcpv6_prot = {\n \t.diag_destroy\t\t= tcp_abort,\n };\n \n+/* thinking of making this const? Don't.\n+ * early_demux can change based on sysctl.\n+ */\n static struct inet6_protocol tcpv6_protocol = {\n \t.early_demux\t=\ttcp_v6_early_demux,\n \t.early_demux_handler = tcp_v6_early_demux,\ndiff --git a/net/ipv6/udp.c b/net/ipv6/udp.c\nindex 2a15f1bb6ef8..976f30391356 100644\n--- a/net/ipv6/udp.c\n+++ b/net/ipv6/udp.c\n@@ -1472,6 +1472,9 @@ int compat_udpv6_getsockopt(struct sock *sk, int level, int optname,\n }\n #endif\n \n+/* thinking of making this const? Don't.\n+ * early_demux can change based on sysctl.\n+ */\n static struct inet6_protocol udpv6_protocol = {\n \t.early_demux\t=\tudp_v6_early_demux,\n \t.early_demux_handler = udp_v6_early_demux,\n","prefixes":["net-next"]}