{"id":806185,"url":"http://patchwork.ozlabs.org/api/patches/806185/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170826225328.7550-4-xypron.glpk@gmx.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170826225328.7550-4-xypron.glpk@gmx.de>","list_archive_url":null,"date":"2017-08-26T22:53:22","name":"[U-Boot,13/23] efi_loader: non-static efi_open_protocol, efi_close_protocol","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"ac2b0fa289ec52b34afe812b3bc06805896d5d5f","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/?format=json","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170826225328.7550-4-xypron.glpk@gmx.de/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806185/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806185/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xftw22MP0z9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Aug 2017 09:07:14 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1206CC22241; Sat, 26 Aug 2017 22:58:27 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5A75DC22138;\n\tSat, 26 Aug 2017 22:57:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3437DC221F8; Sat, 26 Aug 2017 22:54:27 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lists.denx.de (Postfix) with ESMTPS id 8C171C221D9\n\tfor <u-boot@lists.denx.de>; Sat, 26 Aug 2017 22:54:23 +0000 (UTC)","from localhost.localdomain ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0MOwY7-1drUz001XL-006QzV; Sun, 27 Aug 2017 00:53:37 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable\n\tautolearn_force=no version=3.4.0","From":"Heinrich Schuchardt <xypron.glpk@gmx.de>","To":"Alexander Graf <agraf@suse.de>","Date":"Sun, 27 Aug 2017 00:53:22 +0200","Message-Id":"<20170826225328.7550-4-xypron.glpk@gmx.de>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170826225328.7550-1-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>","X-Provags-ID":"V03:K0:HkpDvZfKYvo+9YJMz6R/QvWec6M0Pgw6ldUDgrfROmExRgC3tnW\n\tfKSYhgxH76tkqk/NLxaDN95vwo+CrOCqcOre8KDE12VNggnqvCC0cPtMveggjxKmYUnkSBW\n\tLrdcDVlEI3/kg1NEKGNh9AcnKLxWpf2VYq+fMGN5ds3BVGo/9mM6drajNECBx1bXcnMbmev\n\tZVFedJ3EeRAktdnMshXAw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:ZXl9HyA416M=:wLgvdm+i6My+1be8omo6Gs\n\t1qo4rNkn6EcdXpFiIhqRASuo+1Hd90F0Enm3fCtdFOWaH8cE/ABMe8Px3npcAQQRsV5emSR9d\n\tmRifhzOSwcVMg/3FTbnX8a9wGvKd6OZ+VgN/o7B/WsOGfb5/b7MbnI2Z8XbF3Z7zKDbYxmiJf\n\tTXDhB5rW9Psp18rxse+c96oqD61kOr74Gn2xtfZY21tdHBNiEhEBWyQYn81LtG8eqxfLBMZT/\n\tCvN53EEAO018mVKAxL/OXcBJ4DWXB1LQ06CuwxCDrur+cwUNW2X+MQvElugVJfuoT2SALYmCC\n\tpBxKCNRx67yYxzdHSXcP0v0g+uoh3YNg4QgZU7zuk8fZ1jfP2T/JZtywg0tDcgirvyBKN16OH\n\tfy0w2aztJyA+pvxvElSCJI+b0zkF2NmlobH+uCveXFQwkxWJK84HtDk5LFAPRhJzFsokoJdzt\n\tAyFLIwcopk0Z2HpIWkCoSNfXwZphPteC9B3pMvL8wSCc0gOhqURqTcXPkrHjj01hXyX+I3jSg\n\tIyCP0/HlIq4ye8uqb7xavQnxQ7TkhkflwaAYJp84nKoCP65ekByRnPqyip7yoEcE96Xl+2/t1\n\t9HrVYe/2fR/W5TzMW7FjRrIwf2CzQG4U6aOYGDx41G20MOMbzeTa38ZUMFToqifl/6Cxx+Fgf\n\taBKzkxkD9ENcZ2RaBfdh5jjQ+tl8sYp2oJkMBsJNw4q/h/L0ZaR+jg2cayf2xlGXnDbxsadCP\n\tiGryyZDvAJzeXi9ms3CKzoQ6OHgh5gJXsdQqrpTp0EWKtCW9g+PNmmhnX9bq7QA6luVysNCHW\n\tU3GxZ+AmBVf6PU/5XCuo4N41C+s7w==","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>, u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 13/23] efi_loader: non-static efi_open_protocol,\n\tefi_close_protocol","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"We need efi_open_protocol and efi_close_protocol for\nimplementing other functions. So they shouldn't be static.\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n include/efi_loader.h          | 9 +++++++++\n lib/efi_loader/efi_boottime.c | 9 ++++-----\n 2 files changed, 13 insertions(+), 5 deletions(-)","diff":"diff --git a/include/efi_loader.h b/include/efi_loader.h\nindex 2c3360534b..2a98bf66b8 100644\n--- a/include/efi_loader.h\n+++ b/include/efi_loader.h\n@@ -181,6 +181,15 @@ efi_status_t efi_set_timer(struct efi_event *event, enum efi_timer_delay type,\n \t\t\t   uint64_t trigger_time);\n /* Call this to signal an event */\n void efi_signal_event(struct efi_event *event);\n+/* Call this with EFI_CALL to close a protocol */\n+efi_status_t EFIAPI efi_close_protocol(void *handle, efi_guid_t *protocol,\n+\t\t\t\t       void *agent_handle,\n+\t\t\t\t       void *controller_handle);\n+/* Call this with EFI_CALL to open a protocol */\n+efi_status_t EFIAPI efi_open_protocol(\n+\t\t\tvoid *handle, efi_guid_t *protocol,\n+\t\t\tvoid **protocol_interface, void *agent_handle,\n+\t\t\tvoid *controller_handle, uint32_t attributes);\n \n /* Generic EFI memory allocator, call this to get memory */\n void *efi_alloc(uint64_t len, int memory_type);\ndiff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\nindex 23b8894e73..ad8733d3e5 100644\n--- a/lib/efi_loader/efi_boottime.c\n+++ b/lib/efi_loader/efi_boottime.c\n@@ -939,10 +939,9 @@ static efi_status_t EFIAPI efi_disconnect_controller(void *controller_handle,\n \treturn EFI_EXIT(EFI_INVALID_PARAMETER);\n }\n \n-static efi_status_t EFIAPI efi_close_protocol(void *handle,\n-\t\t\t\t\t      efi_guid_t *protocol,\n-\t\t\t\t\t      void *agent_handle,\n-\t\t\t\t\t      void *controller_handle)\n+efi_status_t EFIAPI efi_close_protocol(void *handle, efi_guid_t *protocol,\n+\t\t\t\t       void *agent_handle,\n+\t\t\t\t       void *controller_handle)\n {\n \tstruct efi_handler *handler;\n \tsize_t i;\n@@ -1326,7 +1325,7 @@ static efi_status_t efi_protocol_open(\n \treturn EFI_SUCCESS;\n }\n \n-static efi_status_t EFIAPI efi_open_protocol(\n+efi_status_t EFIAPI efi_open_protocol(\n \t\t\tvoid *handle, efi_guid_t *protocol,\n \t\t\tvoid **protocol_interface, void *agent_handle,\n \t\t\tvoid *controller_handle, uint32_t attributes)\n","prefixes":["U-Boot","13/23"]}