{"id":806174,"url":"http://patchwork.ozlabs.org/api/patches/806174/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170826225328.7550-9-xypron.glpk@gmx.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170826225328.7550-9-xypron.glpk@gmx.de>","list_archive_url":null,"date":"2017-08-26T22:53:27","name":"[U-Boot,18/23] efi_net: return EFI_UNSUPPORTED where appropriate","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"cad5592182840001f64f50ed154635836850a671","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/?format=json","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170826225328.7550-9-xypron.glpk@gmx.de/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806174/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806174/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xftlM520hz9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Aug 2017 08:59:43 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 69F97C221B9; Sat, 26 Aug 2017 22:58:12 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 015C4C221D6;\n\tSat, 26 Aug 2017 22:57:39 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5B778C221DE; Sat, 26 Aug 2017 22:54:27 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id EC406C221D1\n\tfor <u-boot@lists.denx.de>; Sat, 26 Aug 2017 22:54:22 +0000 (UTC)","from localhost.localdomain ([84.118.154.110]) by mail.gmx.com\n\t(mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0MAQMg-1dfe4u2eEs-00Be3U; Sun, 27 Aug 2017 00:53:38 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable\n\tautolearn_force=no version=3.4.0","From":"Heinrich Schuchardt <xypron.glpk@gmx.de>","To":"Alexander Graf <agraf@suse.de>","Date":"Sun, 27 Aug 2017 00:53:27 +0200","Message-Id":"<20170826225328.7550-9-xypron.glpk@gmx.de>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<20170826225328.7550-1-xypron.glpk@gmx.de>","References":"<20170826225110.7381-1-xypron.glpk@gmx.de>\n\t<20170826225328.7550-1-xypron.glpk@gmx.de>","X-Provags-ID":"V03:K0:5ETEQWXmQd2xLsqGNTj2rAZXJsimX4fn2d+dbFj6VKekMhf51Lm\n\t/zyDZKvPBE968FIl+QYaetl0mFEJjwBnpz7cBsHQKt1hBpga9yTzuyCCX8zS3mbAZ17JMcQ\n\tHbz3DzNbC6Un8Qv+NhXdgdSH0DWOhYfhnmz4nR1qDJpeR15OSzepNqQ+c3f+tGS3+h5nAqw\n\twPy8BuXoPbQWWoVmpWpdA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:Tw+3U2cwums=:MX6duCyqR29He/7iYU9R/e\n\tN/R1NU8xWJNGsAlhSNFVMQEWj4vDp9d0ntw12M/+gfhmGqTVZXX/tERx3LLN0ZTwQerJjlaaA\n\tCQEZlK24gn7xpOAfB18YAVvFAzRNAlus1ruFnCMOcXd4QkyVqBteFDcvUZCpfg/EJrtK+lTIy\n\tTeQf2s7eHu2AbQqZ1EReeTw12vwlbpGGspLo3ytvhwEsdCVhGVCFk/b6HErPyUts4otc4YxeJ\n\td3Nd8ZmAl9pWRfmqT94N41zIFogyPDAPf3d+tGtGwp2Gm/nfcqW8IvNbYqz4FpWzfp9ItMQH7\n\tD6XomjTVp597t9oL/zoT4k5kEgBhAmRkSlmmf2S30B03a4M4lT+MJ2p7DPdHs7+ws97bvSDD7\n\thQayfn8GbeqJ1VJz1SBsSqeyiQkQZfoLp9SFbFE1LBN+Bk0U8ORymeUEEDzRLRAzM3FN2YRmf\n\ttWfYEuw5JrK8smqXHLili1t+9MaLlt8c12ue34nTArSqLbWtsRMaHtjrM0kvfWYgiZaG679bY\n\t3HTshWULQTBqSTtmhiXMtIvCVKX7MxCuSFzVuZGfY4eCcFYKKi/UOPyUvOjgRu9uNMj2T3ffQ\n\tuydk2rnj+7QchPwPHcmtVR+eeTlcOgaD5mppzAkwnhSiuVko+xBfvPPMvMMA1/NNHQOGZS76i\n\td+osrL9AGIRdmKnk5sCGzOgfRPaeJ+lZJDxfZsS9eLEwaxrCb0FZDRVYzNZ201K1SI1BQIWtV\n\th8Il3V1fj8rIsHbPV5pXLjaVcHRpq1pidvUsq6AHoDWJJF9EmlR6LfMBZk7JZslv0qCVQ3e26\n\tJ6jpFxJuJ1BNMOpzz8nM6fLzWOZwQ==","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>, u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH 18/23] efi_net: return EFI_UNSUPPORTED where\n\tappropriate","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"U-Boot does not implement all functions of the simple network\nprotocol. The unimplemented functions return either of\nEFI_SUCCESS and EFI_INVALID_PARAMETER.\n\nThe UEFI spec foresees to return EFI_UNSUPPORTED in these cases.\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n lib/efi_loader/efi_net.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c\nindex 75d7974b0e..38a3a4fac4 100644\n--- a/lib/efi_loader/efi_net.c\n+++ b/lib/efi_loader/efi_net.c\n@@ -81,9 +81,7 @@ static efi_status_t EFIAPI efi_net_receive_filters(\n \tEFI_ENTRY(\"%p, %x, %x, %x, %lx, %p\", this, enable, disable,\n \t\t  reset_mcast_filter, mcast_filter_count, mcast_filter);\n \n-\t/* XXX Do we care? */\n-\n-\treturn EFI_EXIT(EFI_SUCCESS);\n+\treturn EFI_EXIT(EFI_UNSUPPORTED);\n }\n \n static efi_status_t EFIAPI efi_net_station_address(\n@@ -92,7 +90,7 @@ static efi_status_t EFIAPI efi_net_station_address(\n {\n \tEFI_ENTRY(\"%p, %x, %p\", this, reset, new_mac);\n \n-\treturn EFI_EXIT(EFI_INVALID_PARAMETER);\n+\treturn EFI_EXIT(EFI_UNSUPPORTED);\n }\n \n static efi_status_t EFIAPI efi_net_statistics(struct efi_simple_network *this,\n@@ -101,7 +99,7 @@ static efi_status_t EFIAPI efi_net_statistics(struct efi_simple_network *this,\n {\n \tEFI_ENTRY(\"%p, %x, %p, %p\", this, reset, stat_size, stat_table);\n \n-\treturn EFI_EXIT(EFI_INVALID_PARAMETER);\n+\treturn EFI_EXIT(EFI_UNSUPPORTED);\n }\n \n static efi_status_t EFIAPI efi_net_mcastiptomac(struct efi_simple_network *this,\n@@ -121,7 +119,7 @@ static efi_status_t EFIAPI efi_net_nvdata(struct efi_simple_network *this,\n \tEFI_ENTRY(\"%p, %x, %lx, %lx, %p\", this, read_write, offset, buffer_size,\n \t\t  buffer);\n \n-\treturn EFI_EXIT(EFI_INVALID_PARAMETER);\n+\treturn EFI_EXIT(EFI_UNSUPPORTED);\n }\n \n static efi_status_t EFIAPI efi_net_get_status(struct efi_simple_network *this,\n","prefixes":["U-Boot","18/23"]}