{"id":806129,"url":"http://patchwork.ozlabs.org/api/patches/806129/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1503760140-9095-3-git-send-email-minipli@googlemail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503760140-9095-3-git-send-email-minipli@googlemail.com>","list_archive_url":null,"date":"2017-08-26T15:08:58","name":"[net,2/4] xfrm_user: fix info leak in xfrm_notify_sa()","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"40844dd961193b29aa4fd0d511c3de58b41869c4","submitter":{"id":6743,"url":"http://patchwork.ozlabs.org/api/people/6743/?format=json","name":"Mathias Krause","email":"minipli@googlemail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503760140-9095-3-git-send-email-minipli@googlemail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806129/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806129/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"b3QPKAOB\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfhKQ628dz9t5Y\n\tfor ;\n\tSun, 27 Aug 2017 01:10:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751189AbdHZPKA (ORCPT );\n\tSat, 26 Aug 2017 11:10:00 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:36449 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751085AbdHZPJ3 (ORCPT\n\t); Sat, 26 Aug 2017 11:09:29 -0400","by mail-wm0-f65.google.com with SMTP id j72so2586583wmi.3\n\tfor ; Sat, 26 Aug 2017 08:09:28 -0700 (PDT)","from jig.fritz.box (ip-90-186-2-57.web.vodafone.de. [90.186.2.57])\n\tby smtp.gmail.com with ESMTPSA id\n\tj15sm7126308wmg.14.2017.08.26.08.09.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 26 Aug 2017 08:09:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=rdSJz8dPcFdthIGqbywGOVRGicM+6ep6RNjfa4aAUkQ=;\n\tb=b3QPKAOBwkuzc9GNM6Aj3QLYe0uJp1dq+ydzC/luiV1TeF/eRlwC0Vt+0jwWiB7Ynj\n\t/ioDL0BtnVoeqilm4tQN9o5qH2O/nC/dtFAX5Ld4RpuvVKfeH3xYt+OH0dXBq2pB7a1t\n\tf+KU3F8gWcIVMor39mmEGRizE73uETLxg87JN6MeHBYwmcFFi5hsdIgbeauRrXyI/PD6\n\t97lkmKB29NVTDzaYHFhTZiKSjjRf8kYm0eAZL/fGYFhuAbtghXFkGiuGsl9YJSg3WpfE\n\txvw+YekKjugPxFyw8kq3aYoYk0g/C7SPpPBrk6W3Z2kaUBOdBnSlyil/WAUMy/DRsxb4\n\tJbmQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=rdSJz8dPcFdthIGqbywGOVRGicM+6ep6RNjfa4aAUkQ=;\n\tb=V3ktscyK8OL08TSiPbXbhoZjoOUe3LTgh/I9zx5swGCog2YfO2CQqITiNfhx4L9uaY\n\tVO+aySs43CV/1DFJOhTHt0EucGUR/p82DOVsfA16Z4CUn599vNfkr56sJy/gLeKUESl5\n\tq2AfiuGHoVID0Kt/DrzqI32ecqfFeZRCNPeM9FyzTLTdxtDVV6FPNHWF5neMxSqUYXEb\n\tiAnVWzin6TaPwoBULd6d5S4N3iVZuRoF6HTPxyd3WD5f2g3rQIzkiUxZGd+P/gBCtw88\n\t1qJz2cGNGU9tZyaGn1qBGTqhaJEfP1yWLDKivUefNB2oLNrwtCwEPVMCXogHQHS9vBNW\n\txfvQ==","X-Gm-Message-State":"AHYfb5iRtPZXs4INLmt1sFJ1/JuRoHXkXVge8iXrj76po+vweQH5qMwY\n\t+Ti2exHu08FfsA==","X-Received":"by 10.28.128.196 with SMTP id b187mr523258wmd.102.1503760168308; \n\tSat, 26 Aug 2017 08:09:28 -0700 (PDT)","From":"Mathias Krause ","To":"Steffen Klassert ,\n\t\"David S. Miller\" ,\n\tHerbert Xu ","Cc":"netdev@vger.kernel.org, Mathias Krause ","Subject":"[PATCH net 2/4] xfrm_user: fix info leak in xfrm_notify_sa()","Date":"Sat, 26 Aug 2017 17:08:58 +0200","Message-Id":"<1503760140-9095-3-git-send-email-minipli@googlemail.com>","X-Mailer":"git-send-email 1.7.10.4","In-Reply-To":"<1503760140-9095-1-git-send-email-minipli@googlemail.com>","References":"<1503760140-9095-1-git-send-email-minipli@googlemail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The memory reserved to dump the ID of the xfrm state includes a padding\nbyte in struct xfrm_usersa_id added by the compiler for alignment. To\nprevent the heap info leak, memset(0) the whole struct before filling\nit.\n\nCc: Herbert Xu \nFixes: 0603eac0d6b7 (\"[IPSEC]: Add XFRMA_SA/XFRMA_POLICY for delete notification\")\nSigned-off-by: Mathias Krause \n---\n net/xfrm/xfrm_user.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c\nindex 3259555ae7d7..c33516ef52f2 100644\n--- a/net/xfrm/xfrm_user.c\n+++ b/net/xfrm/xfrm_user.c\n@@ -2715,6 +2715,7 @@ static int xfrm_notify_sa(struct xfrm_state *x, const struct km_event *c)\n \t\tstruct nlattr *attr;\n \n \t\tid = nlmsg_data(nlh);\n+\t\tmemset(id, 0, sizeof(*id));\n \t\tmemcpy(&id->daddr, &x->id.daddr, sizeof(id->daddr));\n \t\tid->spi = x->id.spi;\n \t\tid->family = x->props.family;\n","prefixes":["net","2/4"]}