{"id":806019,"url":"http://patchwork.ozlabs.org/api/patches/806019/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/1503695470-27811-1-git-send-email-dev.kurt@vandijck-laurijssen.be/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503695470-27811-1-git-send-email-dev.kurt@vandijck-laurijssen.be>","list_archive_url":null,"date":"2017-08-25T21:11:10","name":"[V2] bcusdk: eibd: drop local clock_gettime in USB backends","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0dd8f2a475e7723f57cc9e78dbffe20d1f4edf51","submitter":{"id":68140,"url":"http://patchwork.ozlabs.org/api/people/68140/?format=json","name":"Kurt Van Dijck","email":"dev.kurt@vandijck-laurijssen.be"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/1503695470-27811-1-git-send-email-dev.kurt@vandijck-laurijssen.be/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806019/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806019/checks/","tags":{},"related":[],"headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xfDP83pRlz9sP5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 26 Aug 2017 07:11:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5095B89754;\n\tFri, 25 Aug 2017 21:11:35 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MQKn276C-msY; Fri, 25 Aug 2017 21:11:33 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A773D8974B;\n\tFri, 25 Aug 2017 21:11:33 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 707C61BFBAD\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 25 Aug 2017 21:11:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 65C108974B\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 25 Aug 2017 21:11:32 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KDzpPCIl0V0E for <buildroot@lists.busybox.net>;\n\tFri, 25 Aug 2017 21:11:31 +0000 (UTC)","from relay-b03.edpnet.be (relay-b03.edpnet.be [212.71.1.220])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 7C69989650\n\tfor <buildroot@busybox.net>; Fri, 25 Aug 2017 21:11:31 +0000 (UTC)","from zotac.vandijck-laurijssen.be\n\t(77.109.102.73.adsl.dyn.edpnet.net\n\t[77.109.102.73]) by relay-b03.edpnet.be with ESMTP id\n\tB7FQr2MgIoXuPYYW for\n\t<buildroot@busybox.net>; Fri, 25 Aug 2017 23:11:29 +0200 (CEST)","from airbook.vandijk-laurijssen.be (kurt.vandijck-laurijssen.be\n\t[192.168.0.70])\n\tby zotac.vandijck-laurijssen.be (Postfix) with ESMTPSA id 5484A39EB94;\n\tFri, 25 Aug 2017 23:11:29 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org","by bsmtpd at edpnet.be"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","X-ASG-Debug-ID":"1503695489-0a8818159c930c40001-A1ldta","X-Barracuda-Envelope-From":"dev.kurt@vandijck-laurijssen.be","X-Barracuda-Effective-Source-IP":"77.109.102.73.adsl.dyn.edpnet.net[77.109.102.73]","X-Barracuda-Apparent-Source-IP":"77.109.102.73","From":"Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>","To":"buildroot@busybox.net","Date":"Fri, 25 Aug 2017 23:11:10 +0200","X-ASG-Orig-Subj":"[PATCH V2] bcusdk: eibd: drop local clock_gettime in USB\n\tbackends","Message-Id":"<1503695470-27811-1-git-send-email-dev.kurt@vandijck-laurijssen.be>","X-Mailer":"git-send-email 1.8.5.rc3","X-Barracuda-Connect":"77.109.102.73.adsl.dyn.edpnet.net[77.109.102.73]","X-Barracuda-Start-Time":"1503695489","X-Barracuda-URL":"https://212.71.1.220:443/cgi-mod/mark.cgi","X-Barracuda-Scan-Msg-Size":"2026","X-Barracuda-BRTS-Status":"1","X-Barracuda-Bayes":"INNOCENT GLOBAL 0.5498 1.0000 0.7500","X-Barracuda-Spam-Score":"0.75","X-Barracuda-Spam-Status":"No,\n\tSCORE=0.75 using global scores of TAG_LEVEL=1000.0\n\tQUARANTINE_LEVEL=1000.0 KILL_LEVEL=6.0 tests=","X-Barracuda-Spam-Report":"Code version 3.2, rules version 3.2.3.42318\n\tRule breakdown below\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------","Cc":"Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>","Subject":"[Buildroot] [PATCH V2] bcusdk: eibd: drop local clock_gettime in\n\tUSB backends","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"},"content":"clock_gettime is defined locally, and calls pth_int_time, which\nin turn calls clock_gettime.\nThe USB backend shouldn't overrule clock_gettime in the first place.\nThis patch fixes this endless recursion by removing the local defition.\n\nSigned-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>\n---\n ...endless-recursion-when-using-USB-backends.patch | 35 ++++++++++++++++++++++\n 1 file changed, 35 insertions(+)\n create mode 100644 package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch","diff":"diff --git a/package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch b/package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch\nnew file mode 100644\nindex 0000000..3b90289\n--- /dev/null\n+++ b/package/bcusdk/0002-eibd-fix-endless-recursion-when-using-USB-backends.patch\n@@ -0,0 +1,35 @@\n+From 6bd1b4958e949d83468e053c34bf6c89d14d687a Mon Sep 17 00:00:00 2001\n+From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>\n+Date: Fri, 25 Aug 2017 23:01:14 +0200\n+Subject: [PATCH] eibd: drop local clock_gettime in USB backends\n+\n+clock_gettime is defined locally, and calls pth_int_time, which\n+in turn calls clock_gettime.\n+The USB backend shouldn't overrule clock_gettime in the first place.\n+This patch fixes this endless recursion by removing the local defition.\n+\n+Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>\n+---\n+ eibd/usb/linux_usbfs.c | 6 ------\n+ 1 file changed, 6 deletions(-)\n+\n+diff --git a/eibd/usb/linux_usbfs.c b/eibd/usb/linux_usbfs.c\n+index c3ec410..957b908 100644\n+--- a/eibd/usb/linux_usbfs.c\n++++ b/eibd/usb/linux_usbfs.c\n+@@ -52,12 +52,6 @@ int pthread_mutex_trylock(pthread_mutex_t *mutex)\n+ \treturn 0;\n+ }\n+ \n+-int clock_gettime(clockid_t clk_id, struct timespec *tp)\n+-{\n+-\tpth_int_time (tp);\n+-\treturn 0;\n+-}\n+-\n+ /* sysfs vs usbfs:\n+  * opening a usbfs node causes the device to be resumed, so we attempt to\n+  * avoid this during enumeration.\n+-- \n+1.8.5.rc3\n+\n","prefixes":["V2"]}