{"id":805918,"url":"http://patchwork.ozlabs.org/api/patches/805918/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170825143805.21733-1-clabbe.montjoie@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170825143805.21733-1-clabbe.montjoie@gmail.com>","list_archive_url":null,"date":"2017-08-25T14:38:05","name":"net: stmmac: dwmac-sun8i: Use reset exclusive","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"c8648ea07da3206d39ad9766df6ad2218e6c7096","submitter":{"id":64152,"url":"http://patchwork.ozlabs.org/api/people/64152/?format=json","name":"Corentin Labbe","email":"clabbe.montjoie@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170825143805.21733-1-clabbe.montjoie@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805918/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805918/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"OYbLFCpw\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf3jv4lDGz9sN5\n\tfor ;\n\tSat, 26 Aug 2017 00:40:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756952AbdHYOkY (ORCPT );\n\tFri, 25 Aug 2017 10:40:24 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:37966 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756256AbdHYOkW (ORCPT\n\t); Fri, 25 Aug 2017 10:40:22 -0400","by mail-wr0-f194.google.com with SMTP id o76so1225777wrb.5;\n\tFri, 25 Aug 2017 07:40:22 -0700 (PDT)","from Red.local (LFbn1-1-65-78.w90-118.abo.wanadoo.fr.\n\t[90.118.156.78]) by smtp.googlemail.com with ESMTPSA id\n\th66sm1549071wmd.38.2017.08.25.07.40.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 25 Aug 2017 07:40:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=3BXrJv8zP4XEFEzPLrDU/mO6bAo77tUoLLbUfz4qlOE=;\n\tb=OYbLFCpwnAip6QlBNVQwBUgcsCaGgwa9CNO8M+xTh4qfeB/mGgN4bjjO6qqcVoztX7\n\t/J6f2ZBZVEJkSDEDiHIDb01aInj5teeyA23Or8noL/hNDktu6955rAjSRxZJ5P32AlFQ\n\thXqkBTDLi0q/xQZsGs9PNVHbYW3szAY8SwIrKTHqQtd5TlzW+0iEFmzFa01Eb6d+XdL4\n\tVzK1o7ZC7kXGMWGQlNkrpCNvx4A6kc5TbefYkn35Y8eARRPr/br85U3AfxyRJfu3gyyu\n\tec6bcaZuj8kEpuMpL+9KQ2NolOUhzWm41DneLQ6+XZh1U1wHK7ML9AbrGG6SqzFD/Un4\n\txB6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=3BXrJv8zP4XEFEzPLrDU/mO6bAo77tUoLLbUfz4qlOE=;\n\tb=m+wB+vAiUJEJt0ee1WOlQ9nHAYMpBb/XjhzWSe+EIwLsW0QQcIRUkc2oxke5l3bqax\n\t9kTZy8WU12eHLxyiCVOxMqScWWxAiZj9YA/s7scTfWk+a3irqSAXd7/+RHB9daMfl0PW\n\tO1G1gz5moU5doLV8A4MhuqJQwpzz4j+Df2OZHwd4MW/PqmA5ffL7uCz7XrYw9hwpwnK6\n\tYLFx0w/iyTwzspJWFG2ECE0o7rReBocpZygS8PO6dm8pqw5yijupHH3297SMF3AXo6e5\n\tObCNmBsnW7kgaj2OV/zVvZq4a10h1HeXC2CLar+SsWpquWe1lPECqcmbZ3B6QkI6FGPf\n\t6tgA==","X-Gm-Message-State":"AHYfb5hD5A3fz2OXIZql7MMb12bWvIFzXO7t4Esn/fNPtOVxlABhcpEh\n\tHa5xdlddv1xxS72t","X-Received":"by 10.223.136.39 with SMTP id d36mr5621383wrd.136.1503672021622; \n\tFri, 25 Aug 2017 07:40:21 -0700 (PDT)","From":"Corentin Labbe ","To":"peppe.cavallaro@st.com, alexandre.torgue@st.com,\n\tmaxime.ripard@free-electrons.com, wens@csie.org","Cc":"netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org, Corentin Labbe ","Subject":"[PATCH] net: stmmac: dwmac-sun8i: Use reset exclusive","Date":"Fri, 25 Aug 2017 16:38:05 +0200","Message-Id":"<20170825143805.21733-1-clabbe.montjoie@gmail.com>","X-Mailer":"git-send-email 2.13.5","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The current dwmac_sun8i module cannot be rmmod/modprobe due to that\nthe reset controller was not released when removed.\n\nThis patch remove ambiguity, by using of_reset_control_get_exclusive and\nadd the missing reset_control_put().\n\nSigned-off-by: Corentin Labbe \n---\n drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\nindex fffd6d5fc907..675a09629d85 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n@@ -782,6 +782,7 @@ static int sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)\n \n \tclk_disable_unprepare(gmac->ephy_clk);\n \treset_control_assert(gmac->rst_ephy);\n+\treset_control_put(gmac->rst_ephy);\n \treturn 0;\n }\n \n@@ -942,7 +943,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)\n \t\t\treturn -EINVAL;\n \t\t}\n \n-\t\tgmac->rst_ephy = of_reset_control_get(plat_dat->phy_node, NULL);\n+\t\tgmac->rst_ephy = of_reset_control_get_exclusive(plat_dat->phy_node, NULL);\n \t\tif (IS_ERR(gmac->rst_ephy)) {\n \t\t\tret = PTR_ERR(gmac->rst_ephy);\n \t\t\tif (ret == -EPROBE_DEFER)\n","prefixes":[]}