{"id":805885,"url":"http://patchwork.ozlabs.org/api/patches/805885/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170825141420.14027-2-antoine.tenart@free-electrons.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170825141420.14027-2-antoine.tenart@free-electrons.com>","list_archive_url":null,"date":"2017-08-25T14:14:17","name":"[net,v2,1/4] net: mvpp2: fix the mac address used when using PPv2.2","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"0eb881457216604d2747aa21246fcdf225747aa2","submitter":{"id":61603,"url":"http://patchwork.ozlabs.org/api/people/61603/?format=json","name":"Antoine Tenart","email":"antoine.tenart@free-electrons.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170825141420.14027-2-antoine.tenart@free-electrons.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805885/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805885/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xf39t0mDNz9sPs\n\tfor ;\n\tSat, 26 Aug 2017 00:16:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932986AbdHYOPO (ORCPT );\n\tFri, 25 Aug 2017 10:15:14 -0400","from mail.free-electrons.com ([62.4.15.54]:43081 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756520AbdHYOPN (ORCPT\n\t); Fri, 25 Aug 2017 10:15:13 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid E5D4920959; Fri, 25 Aug 2017 16:15:10 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id BCC09207F5;\n\tFri, 25 Aug 2017 16:15:00 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Antoine Tenart ","To":"davem@davemloft.net, thomas.petazzoni@free-electrons.com","Cc":"Antoine Tenart , andrew@lunn.ch,\n\tgregory.clement@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org","Subject":"[PATCH net v2 1/4] net: mvpp2: fix the mac address used when using\n\tPPv2.2","Date":"Fri, 25 Aug 2017 16:14:17 +0200","Message-Id":"<20170825141420.14027-2-antoine.tenart@free-electrons.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>","References":"<20170825141420.14027-1-antoine.tenart@free-electrons.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The mac address is only retrieved from h/w when using PPv2.1. Otherwise\nthe variable holding it is still checked and used if it contains a valid\nvalue. As the variable isn't initialized to an invalid mac address\nvalue, we end up with random mac addresses which can be the same for all\nthe ports handled by this PPv2 driver.\n\nFixes this by initializing the h/w mac address variable to {0}, which is\nan invalid mac address value. This way the random assignation fallback\nis called and all ports end up with their own addresses.\n\nSigned-off-by: Antoine Tenart \nFixes: 2697582144dd (\"net: mvpp2: handle misc PPv2.1/PPv2.2 differences\")\n---\n drivers/net/ethernet/marvell/mvpp2.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c\nindex 48d21c1e09f2..4d598ca8503a 100644\n--- a/drivers/net/ethernet/marvell/mvpp2.c\n+++ b/drivers/net/ethernet/marvell/mvpp2.c\n@@ -6504,7 +6504,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,\n \tstruct resource *res;\n \tconst char *dt_mac_addr;\n \tconst char *mac_from;\n-\tchar hw_mac_addr[ETH_ALEN];\n+\tchar hw_mac_addr[ETH_ALEN] = {0};\n \tu32 id;\n \tint features;\n \tint phy_mode;\n","prefixes":["net","v2","1/4"]}