{"id":805815,"url":"http://patchwork.ozlabs.org/api/patches/805815/?format=json","web_url":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170825095212.GB14035@fergus.ozlabs.ibm.com/","project":{"id":23,"url":"http://patchwork.ozlabs.org/api/projects/23/?format=json","name":"KVM PowerPC development","link_name":"kvm-ppc","list_id":"kvm-ppc.vger.kernel.org","list_email":"kvm-ppc@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170825095212.GB14035@fergus.ozlabs.ibm.com>","list_archive_url":null,"date":"2017-08-25T09:52:12","name":"KVM: PPC: Book3S HV: Fix case where HDEC is treated as 32-bit on POWER9","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b655e138f2c4863336a21d32466ae7751fa5e354","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/?format=json","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/kvm-ppc/patch/20170825095212.GB14035@fergus.ozlabs.ibm.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805815/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805815/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"CFBPsXyF\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xdxM26b2Kz9t2f\n\tfor ;\n\tFri, 25 Aug 2017 19:53:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754668AbdHYJxr (ORCPT );\n\tFri, 25 Aug 2017 05:53:47 -0400","from ozlabs.org ([103.22.144.67]:33217 \"EHLO ozlabs.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754608AbdHYJxo (ORCPT );\n\tFri, 25 Aug 2017 05:53:44 -0400","by ozlabs.org (Postfix, from userid 1003)\n\tid 3xdxLt6slMz9sNd; Fri, 25 Aug 2017 19:53:42 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1503654822; bh=4yVnPkiF+OaGI2gvyCxpcROUrNDEtHZ5eLWvcE8N7Co=;\n\th=Date:From:To:Subject:From;\n\tb=CFBPsXyFdo+yZDUVprU+AVEjNmuKOswoGv7PiO9AZ5v+kSwm0+9P9fE+sCqJmkens\n\tE9rFt079JBRuo3GXZsYh8Jdffm6Z1zpe7pqhfl5AYlw3bYdP2WIvaZEo7OPGdEh4TC\n\tms200rwevtKtJ3nmKImcvb1Q/oVt+LZE7L18jif9s8Dz2U7LpuV1ZdmO6y2enhoA2w\n\tOjzjljJoj7bSCcu3IqT859+UcboUKfdVuqAiaI1+w5va+h36c//lueLBHBrtXMEM9H\n\tAnvO+PuRaBqJJi0SHIp38GIr1V4clt7jZEF7F24N7neWdGjysNRc8rGDYNpgtgOgWi\n\tZxTwh/Ly7s30g==","Date":"Fri, 25 Aug 2017 19:52:12 +1000","From":"Paul Mackerras ","To":"kvm@vger.kernel.org, kvm-ppc@vger.kernel.org","Subject":"[PATCH] KVM: PPC: Book3S HV: Fix case where HDEC is treated as\n\t32-bit on POWER9","Message-ID":"<20170825095212.GB14035@fergus.ozlabs.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"},"content":"Commit 2f2724630f7a (\"KVM: PPC: Book3S HV: Cope with host using large\ndecrementer mode\", 2017-05-22) added code to treat the hypervisor\ndecrementer (HDEC) as a 64-bit value on POWER9 rather than 32-bit.\nUnfortunately, that commit missed one place where HDEC is treated\nas a 32-bit value. This fixes it.\n\nThis bug should not have any user-visible consequences that I can\nthink of, beyond an occasional unnecessary exit to the host kernel.\nIf the hypervisor decrementer has gone negative, then the bottom\n32 bits will be negative for about 4 seconds after that, so as\nlong as we get out of the guest within those 4 seconds we won't\nconclude that the HDEC interrupt is spurious.\n\nReported-by: Suraj Jitindar Singh \nFixes: 2f2724630f7a (\"KVM: PPC: Book3S HV: Cope with host using large decrementer mode\")\nSigned-off-by: Paul Mackerras \n---\n arch/powerpc/kvm/book3s_hv_rmhandlers.S | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S\nindex c52184a..9f1521e 100644\n--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S\n+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S\n@@ -1280,7 +1280,8 @@ END_FTR_SECTION_IFSET(CPU_FTR_HAS_PPR)\n \tcmpwi\tr12,BOOK3S_INTERRUPT_HV_DECREMENTER\n \tbne\t2f\n \tmfspr\tr3,SPRN_HDEC\n-\tcmpwi\tr3,0\n+\tEXTEND_HDEC(r3)\n+\tcmpdi\tr3,0\n \tmr\tr4,r9\n \tbge\tfast_guest_return\n 2:\n","prefixes":[]}